Merge pull request #5910 from rldhont/phpstan-lizmap-class

Lint PHP: Class Lizmap

Author: rldhont

lizmap/modules/lizmap/classes/lizmap.class.php

@@ -40,17 +40,17 @@ class lizmap
     protected static $repositoryInstances = array();
 
     /**
-     * @var lizmapServices The lizmapServices instance for the singleton
+     * @var null|lizmapServices The lizmapServices instance for the singleton
      */
     protected static $lizmapServicesInstance;
 
     /**
-     * @var LogConfig The Lizmap Logger Config instance for the singleton
+     * @var null|LogConfig The Lizmap Logger Config instance for the singleton
      */
     protected static $lizmapLogConfigInstance;
 
     /**
-     * @var JelixContext The jelixContext instance for the singleton
+     * @var null|JelixContext The jelixContext instance for the singleton
      */
     protected static $appContext;
 
@@ -161,8 +161,8 @@ public static function getRepositoryPropertiesOptions()
     /**
      * Get the jForm for a repository.
      *
-     * @param lizmapRepository $rep
-     * @param jFormsBase       $form
+     * @param null|lizmapRepository $rep
+     * @param jFormsBase            $form
      *
      * @return jFormsBase
      */

phpstan-baseline.neon

@@ -95,26 +95,6 @@ parameters:
       count: 4
       path: lizmap/modules/filter/controllers/service.classic.php
 
-    -
-      message: "#^If condition is always true\\.$#"
-      count: 1
-      path: lizmap/modules/lizmap/classes/lizmap.class.php
-
-    -
-      message: "#^Left side of && is always true\\.$#"
-      count: 1
-      path: lizmap/modules/lizmap/classes/lizmap.class.php
-
-    -
-      message: "#^Negated boolean expression is always false\\.$#"
-      count: 2
-      path: lizmap/modules/lizmap/classes/lizmap.class.php
-
-    -
-      message: "#^Static property lizmap\\:\\:\\$lizmapServicesInstance \\(lizmapServices\\) in isset\\(\\) is not nullable\\.$#"
-      count: 1
-      path: lizmap/modules/lizmap/classes/lizmap.class.php
-
     -
       message: "#^If condition is always true\\.$#"
       count: 1