diff --git a/java/openmldb-spark-connector/src/main/java/com/_4paradigm/openmldb/spark/OpenmldbTable.java b/java/openmldb-spark-connector/src/main/java/com/_4paradigm/openmldb/spark/OpenmldbTable.java index e5cbcfe40ca..175c00ee92f 100644 --- a/java/openmldb-spark-connector/src/main/java/com/_4paradigm/openmldb/spark/OpenmldbTable.java +++ b/java/openmldb-spark-connector/src/main/java/com/_4paradigm/openmldb/spark/OpenmldbTable.java @@ -55,7 +55,7 @@ public OpenmldbTable(OpenmldbConfig config) { // no need to check table exists, schema() will check it later } catch (SqlException e) { e.printStackTrace(); - throw new RuntimeException("conn openmldb failed", e); + throw new RuntimeException("connect to openmldb failed", e); // abort immediately } // TODO: cache schema & delete executor? } diff --git a/java/openmldb-taskmanager/src/main/java/com/_4paradigm/openmldb/taskmanager/config/TaskManagerConfig.java b/java/openmldb-taskmanager/src/main/java/com/_4paradigm/openmldb/taskmanager/config/TaskManagerConfig.java index d849137fb3a..8b88bb06062 100644 --- a/java/openmldb-taskmanager/src/main/java/com/_4paradigm/openmldb/taskmanager/config/TaskManagerConfig.java +++ b/java/openmldb-taskmanager/src/main/java/com/_4paradigm/openmldb/taskmanager/config/TaskManagerConfig.java @@ -247,6 +247,7 @@ private void init() throws ConfigException { } // Get properties and check + // server.host will be used by RunBatchSql, it's not good to be null if (props.getProperty("server.host") == null) { props.setProperty("server.host", "0.0.0.0"); } @@ -369,14 +370,13 @@ private void init() throws ConfigException { } } - String SPARK_HOME = firstNonEmpty(props.getProperty("spark.home"), System.getenv("SPARK_HOME")); + String SPARK_HOME = firstNonEmpty(props.getProperty("spark.home")); // isEmpty checks null and empty if (isEmpty(SPARK_HOME)) { throw new ConfigException("spark.home", "should set config 'spark.home' or environment variable 'SPARK_HOME'"); } - if (SPARK_HOME != null) { - props.setProperty("spark.home", SPARK_HOME); - } + // rewrite env for spark submit + props.setProperty("spark.home", SPARK_HOME); // TODO: Check if we can get spark-submit diff --git a/java/openmldb-taskmanager/src/main/java/com/_4paradigm/openmldb/taskmanager/server/TaskManagerServer.java b/java/openmldb-taskmanager/src/main/java/com/_4paradigm/openmldb/taskmanager/server/TaskManagerServer.java index 4dc2b0e5f2c..44edca591a7 100644 --- a/java/openmldb-taskmanager/src/main/java/com/_4paradigm/openmldb/taskmanager/server/TaskManagerServer.java +++ b/java/openmldb-taskmanager/src/main/java/com/_4paradigm/openmldb/taskmanager/server/TaskManagerServer.java @@ -141,7 +141,7 @@ public static void main(String[] args) { server.start(); } catch (Exception e) { e.printStackTrace(); - logger.error(String.format("Fail to start TaskManager, message: ", e.getMessage())); + logger.error("Fail to start TaskManager", e); } }