Merge pull request #23 from API-Flows/validate-criterion-context

Criterion context validation

Author: gcatanese

src/main/java/com/apiflows/parser/OpenAPIWorkflowValidator.java

@@ -311,6 +311,10 @@ List<String> validateCriterion(Criterion criterion, String stepId) {
             errors.add("Step " + stepId + " SuccessCriteria type (" + criterion.getType() + ") is invalid");
         }
 
+        if (criterion.getType() != null && criterion.getContext() == null) {
+            errors.add("Step " + stepId + " SuccessCriteria type is specified but context is not provided");
+        }
+
         return errors;
     }
 

src/test/java/com/apiflows/parser/OpenAPIWorkflowValidatorTest.java

@@ -297,7 +297,8 @@ void validateCriterion() {
 
         Criterion criterion = new Criterion()
                 .condition("$statusCode == 200")
-                .type("simple");
+                .type("simple")
+                .context("$response.body");
 
         assertEquals(0, validator.validateCriterion(criterion, stepId).size());
     }
@@ -317,7 +318,20 @@ void validateCriterionInvalidType() {
 
         Criterion criterion = new Criterion()
                 .condition("$statusCode == 200")
-                .type("dummy");
+                .type("dummy")
+                .context("$response.body");
+
+        assertEquals(1, validator.validateCriterion(criterion, stepId).size());
+    }
+
+    @Test
+    void validateCriterionMissingContext() {
+        String stepId = "step-one";
+
+        Criterion criterion = new Criterion()
+                .condition("$statusCode == 200")
+                .type("simple")
+                .context(null);
 
         assertEquals(1, validator.validateCriterion(criterion, stepId).size());
     }