Merge pull request #30 from API-Flows/validate-parameter-target

Parameter target must be JSON Pointer

Author: gcatanese

src/main/java/com/apiflows/parser/OpenAPIWorkflowValidator.java

@@ -239,6 +239,11 @@ List<String> validateParameter(Parameter parameter, String workflowId ) {
                     errors.add("'Workflow[" + workflowId + "]' parameter has no value");
                 }
             }
+            if(parameter.getTarget() != null) {
+                if(!isValidJsonPointer(parameter.getTarget())) {
+                    errors.add("Parameter '" + name + "' target is not a valid Json Pointer");
+                }
+            }
         }
         return errors;
     }

src/test/java/com/apiflows/parser/OpenAPIWorkflowParserTest.java

@@ -14,7 +14,7 @@ void parseFromFile() {
 
         OpenAPIWorkflowParserResult result = parser.parse(WORKFLOWS_SPEC_FILE);
         assertNotNull(result.getOpenAPIWorkflow());
-        assertEquals("1.0.0", result.getOpenAPIWorkflow().getWorkflowsSpec());
+        assertEquals("1.0.0-prerelease", result.getOpenAPIWorkflow().getWorkflowsSpec());
         assertNotNull(result.getOpenAPIWorkflow().getInfo());
         assertEquals("Petstore - Apply Coupons", result.getOpenAPIWorkflow().getInfo().getTitle());
         assertNotNull(result.getOpenAPIWorkflow().getComponents());

src/test/java/com/apiflows/parser/OpenAPIWorkflowValidatorTest.java

@@ -708,9 +708,9 @@ void invalidJsonPointer() {
         assertFalse(new OpenAPIWorkflowValidator().isValidJsonPointer("user/id"));
     }
 
-//    @Test
-//    void isValidJsonPointer2() {
-//        assertTrue(new OpenAPIWorkflowValidator().isValidJsonPointer("#/petId"));
-//    }
+    @Test
+    void invalidJsonPointerSyntax() {
+        assertFalse(new OpenAPIWorkflowValidator().isValidJsonPointer("#/petId"));
+    }
 
 }

src/test/resources/1.0.0/pet-coupons.workflow.yaml

@@ -1,4 +1,4 @@
-workflowsSpec: 1.0.0
+workflowsSpec: 1.0.0-prerelease
 info:
   title: Petstore - Apply Coupons
   version: 1.0.0
@@ -116,22 +116,22 @@ workflows:
         parameters:
           - name: pet_id
             in: body
-            target: $request.body#/petId
+            target: /petId
             value: $inputs.pet_id
           - name: coupon_code
             in: body
-            target: $request.body#/couponCode
+            target: /couponCode
             value: $inputs.coupon_code
           - name: quantity
             in: body
             value: $inputs.quantity
           - name: status
             in: body
-            target: $request.body#/status
+            target: /status
             value: "placed"
           - name: complete
             in: body
-            target: $request.body#/complete
+            target: /complete
             value: false
         successCriteria:
           - condition: $statusCode == 200
@@ -165,4 +165,4 @@ components:
       format: int32
     pageSize:
       type: integer
-      format: int32
+      format: int32