Skip to content

Commit bf38cee

Browse files
committed
Validate target is a valid Json Pointer
1 parent 452d117 commit bf38cee

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

src/main/java/com/apiflows/parser/OpenAPIWorkflowValidator.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,11 @@ List<String> validateParameter(Parameter parameter, String workflowId ) {
239239
errors.add("'Workflow[" + workflowId + "]' parameter has no value");
240240
}
241241
}
242+
if(parameter.getTarget() != null) {
243+
if(!isValidJsonPointer(parameter.getTarget())) {
244+
errors.add("Parameter '" + name + "' target is not a valid Json Pointer");
245+
}
246+
}
242247
}
243248
return errors;
244249
}

src/test/java/com/apiflows/parser/OpenAPIWorkflowValidatorTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -708,9 +708,9 @@ void invalidJsonPointer() {
708708
assertFalse(new OpenAPIWorkflowValidator().isValidJsonPointer("user/id"));
709709
}
710710

711-
// @Test
712-
// void isValidJsonPointer2() {
713-
// assertTrue(new OpenAPIWorkflowValidator().isValidJsonPointer("#/petId"));
714-
// }
711+
@Test
712+
void invalidJsonPointerSyntax() {
713+
assertFalse(new OpenAPIWorkflowValidator().isValidJsonPointer("#/petId"));
714+
}
715715

716716
}

0 commit comments

Comments
 (0)