From 40d74fbaeea68b32f96ccc8906745dc6ccfbdcd2 Mon Sep 17 00:00:00 2001 From: Peter Harris Date: Mon, 8 Dec 2025 16:47:45 +0000 Subject: [PATCH 1/2] Use typing.Iterable not collections.abc.Iterable --- lglpy/android/adb.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lglpy/android/adb.py b/lglpy/android/adb.py index 3061237..db484bb 100644 --- a/lglpy/android/adb.py +++ b/lglpy/android/adb.py @@ -26,12 +26,11 @@ line tool which can be used to run commands on a connected Android device. ''' -from collections.abc import Iterable import os import shlex import shutil import subprocess as sp -from typing import Optional +from typing import Iterable, Optional class ADBConnect: From b06217a69251f0ee3a80dd0f3482035db2493b0a Mon Sep 17 00:00:00 2001 From: Peter Harris Date: Mon, 8 Dec 2025 16:54:14 +0000 Subject: [PATCH 2/2] Import servers only when used --- lgl_android_install.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lgl_android_install.py b/lgl_android_install.py index 8d99c5f..1b6eb3f 100755 --- a/lgl_android_install.py +++ b/lgl_android_install.py @@ -134,8 +134,6 @@ from lglpy.android.utils import AndroidUtils, NamedTempFile from lglpy.android.filesystem import AndroidFilesystem from lglpy.comms import server -from lglpy.comms import service_gpu_timeline -from lglpy.comms import service_gpu_profile from lglpy.ui import console # Android 9 is the minimum version supported for our method of enabling layers @@ -612,10 +610,14 @@ def configure_server(conn: ADBConnect, instance = server.CommsServer(0) if timeline_file: + # Import late to avoid pulling in transitive deps when unused + from lglpy.comms import service_gpu_timeline service_tl = service_gpu_timeline.GPUTimelineService(timeline_file) instance.register_endpoint(service_tl) if profile_dir: + # Import late to avoid pulling in transitive deps when unused + from lglpy.comms import service_gpu_profile service_prof = service_gpu_profile.GPUProfileService(profile_dir) instance.register_endpoint(service_prof)