Harikishore B - 2nd Year CSE A 180501052 #148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harikishore4461
changed the title
bearlike
added
Submission
jyuvaraj03
reviewed
Oct 13, 2019
| l.append(a) | ||
| print("The students present were:") | ||
| for j in l: | ||
| z="P" in j |
There was a problem hiding this comment.
There's a flaw in your logic here. Checking if 'P' is in the string will lead to marking people with 'P' in their names present, even when they are absent. Think of the following test case:
Priya-A
Your code will mark Priya as present even when absent. Correct the code, commit the changes and comment acknowledging the same.
jyuvaraj03
requested changes
Oct 13, 2019
bearlike
force-pushed
the
master
branch
2 times, most recently
from
506e767 to
ff2ad70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.