analyzer reports warnings that can be suppressed with @nowarn

Author: Roman Janusz

commons-analyzer/src/main/scala/com/avsystem/commons/analyzer/AnalyzerRule.scala

@@ -2,8 +2,8 @@ package com.avsystem.commons
 package analyzer
 
 import java.io.{PrintWriter, StringWriter}
-
 import scala.tools.nsc.Global
+import scala.tools.nsc.Reporting.WarningCategory
 import scala.util.control.NonFatal
 
 abstract class AnalyzerRule(val global: Global, val name: String, defaultLevel: Level = Level.Warn) {
@@ -28,11 +28,16 @@ abstract class AnalyzerRule(val global: Global, val name: String, defaultLevel:
 
   private def adjustMsg(msg: String): String = s"[AVS] $msg"
 
-  protected def report(pos: Position, message: String): Unit =
+  protected final def report(
+    pos: Position,
+    message: String,
+    category: WarningCategory = WarningCategory.Lint,
+    site: Symbol = NoSymbol
+  ): Unit =
     level match {
       case Level.Off =>
       case Level.Info => reporter.echo(pos, adjustMsg(message))
-      case Level.Warn => reporter.warning(pos, adjustMsg(message))
+      case Level.Warn => currentRun.reporting.warning(pos, adjustMsg(message), category, site)
       case Level.Error => reporter.error(pos, adjustMsg(message))
     }
 

commons-analyzer/src/main/scala/com/avsystem/commons/analyzer/ConstantDeclarations.scala

@@ -8,7 +8,7 @@ class ConstantDeclarations(g: Global) extends AnalyzerRule(g, "constantDeclarati
   import global._
 
   def analyze(unit: CompilationUnit): Unit = unit.body.foreach {
-    case t@ValDef(mods, name, tpt, rhs)
+    case t@ValDef(_, name, tpt, rhs)
       if t.symbol.hasGetter && t.symbol.owner.isEffectivelyFinal =>
 
       val getter = t.symbol.getterIn(t.symbol.owner)
@@ -18,15 +18,18 @@ class ConstantDeclarations(g: Global) extends AnalyzerRule(g, "constantDeclarati
           case _ => false
         }
 
+        def doReport(msg: String): Unit =
+          report(t.pos, msg, site = t.symbol)
+
         val firstChar = name.toString.charAt(0)
         if (constantValue && (firstChar.isLower || !getter.isFinal)) {
-          report(t.pos, "a literal-valued constant should be declared as a `final val` with an UpperCamelCase name")
+          doReport("a literal-valued constant should be declared as a `final val` with an UpperCamelCase name")
         }
         if (!constantValue && firstChar.isUpper && !getter.isFinal) {
-          report(t.pos, "a constant with UpperCamelCase name should be declared as a `final val`")
+          doReport("a constant with UpperCamelCase name should be declared as a `final val`")
         }
         if (getter.isFinal && constantValue && !(tpt.tpe =:= rhs.tpe)) {
-          report(t.pos, "a constant with a literal value should not have an explicit type annotation")
+          doReport("a constant with a literal value should not have an explicit type annotation")
         }
       }
     case _ =>