Fix make and pat issue in Dockerfile #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
When working with @sbochem and @nandeeka on the fusemax artifacts repo we noticed that there are some cmake and pat issues. Here is a quick fix, maybe you'll propose a cleaner one.
Thanks!
Flavien
EDIT: I tested the diff only on the commit used by the fusemax artifacts. I'm not certain if it works/is useful in the newer version of this repo. Without this fix, the Dockerfile does not build for fusemax artifacts.
EDIT2: there seems also to be an issue with the RUN just before.