forked from AdaGold/tree-practice
-
Notifications
You must be signed in to change notification settings - Fork 44
Ports - Amy W #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amythetester
wants to merge
5
commits into
Ada-C11:master
Choose a base branch
from
amythetester:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ports - Amy W #11
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,59 +2,127 @@ class TreeNode | |
| attr_reader :key, :value | ||
| attr_accessor :left, :right | ||
|
|
||
| def initialize(key, val) | ||
| def initialize(key, val) | ||
| @key = key | ||
| @value = val | ||
| @left = nil | ||
| @right = nil | ||
| end | ||
| end | ||
| end | ||
|
|
||
| class Tree | ||
| attr_reader :root | ||
|
|
||
| def initialize | ||
| @root = nil | ||
| end | ||
|
|
||
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(n) is worst case if tree is not balanced where n is the height of the tree | ||
| # Space Complexity: O(1) | ||
| def add(key, value) | ||
| raise NotImplementedError | ||
| new_node = TreeNode.new(key, value) | ||
|
|
||
| if @root == nil | ||
| @root = new_node | ||
| return | ||
| end | ||
|
|
||
| current = @root | ||
|
|
||
| while current != nil | ||
| if current.key >= key | ||
| break if current.left == nil | ||
| current = current.left | ||
| else | ||
| break if current.right == nil | ||
| current = current.right | ||
| end | ||
| end | ||
|
|
||
| current.key >= key ? current.left = new_node : current.right = new_node | ||
| end | ||
|
|
||
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(n) is worst case if tree is not balanced where n is the height of the tree | ||
| # Space Complexity: O(1) | ||
| def find(key) | ||
| raise NotImplementedError | ||
| current = @root | ||
|
|
||
| while current != nil | ||
| if current.key > key | ||
| current = current.left | ||
| elsif current.key < key | ||
| current = current.right | ||
| else | ||
| return current.value | ||
| end | ||
| end | ||
| return nil | ||
| end | ||
|
|
||
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(n) where n is the number of nodes in the tree | ||
| # Space Complexity: O(n) where n is the number of nodes in the tree | ||
| def inorder | ||
| raise NotImplementedError | ||
| return inorder_recursion(current = @root, tree = []) | ||
| end | ||
|
|
||
| # Time Complexity: | ||
| # Space Complexity: | ||
| def inorder_recursion(current, tree) | ||
| if current != nil | ||
| inorder_recursion(current.left, tree) | ||
| tree << { key: current.key, value: current.value } | ||
| inorder_recursion(current.right, tree) | ||
| else | ||
| return tree | ||
| end | ||
| end | ||
|
|
||
| # Time Complexity: O(n) where n is the number of nodes in the tree | ||
| # Space Complexity: O(n) where n is the number of nodes in the tree | ||
| def preorder | ||
| raise NotImplementedError | ||
| return preorder_recursion(current = @root, tree = []) | ||
| end | ||
|
|
||
| # Time Complexity: | ||
| # Space Complexity: | ||
| def preorder_recursion(current, tree) | ||
| if current != nil | ||
| tree << { key: current.key, value: current.value } | ||
| preorder_recursion(current.left, tree) | ||
| preorder_recursion(current.right, tree) | ||
| else | ||
| return tree | ||
| end | ||
| end | ||
|
|
||
| # Time Complexity: O(n) where n is the number of nodes in the tree | ||
| # Space Complexity: O(n) where n is the number of nodes in the tree xs4 | ||
| def postorder | ||
| raise NotImplementedError | ||
| return postorder_recursion(current = @root, tree = []) | ||
| end | ||
|
|
||
| # Time Complexity: | ||
| # Space Complexity: | ||
| def height | ||
| raise NotImplementedError | ||
| def postorder_recursion(current, tree) | ||
| if current != nil | ||
| postorder_recursion(current.left, tree) | ||
| postorder_recursion(current.right, tree) | ||
| tree << { key: current.key, value: current.value } | ||
| else | ||
| return tree | ||
| end | ||
| end | ||
|
|
||
| # Time Complexity: O(n) where n is the number of nodes in the tree | ||
| # Space Complexity: O(1) | ||
| def height(current = @root, current_height = 0, max_height = 0) | ||
| return max_height if current == nil | ||
|
|
||
| max_height = current_height if current_height > max_height | ||
| max_height = height(current.left, current_height += 1, max_height) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice use of tail recursion |
||
| current_height -= 1 | ||
| max_height = height(current.right, current_height += 1, max_height) | ||
|
|
||
| return max_height | ||
| end | ||
|
|
||
| # Optional Method | ||
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: | ||
| # Space Complexity: | ||
| def bfs | ||
| raise NotImplementedError | ||
| end | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, but you could streamline the if statements to insert the node here I think.