Earth - Denise Task-List #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I made a mistake when doing my first pull request 2 days ago. I did it to AdaGold, and it can be seen in this link: |
dHelmgren
reviewed
Nov 10, 2020
dHelmgren
left a comment
dHelmgren
left a comment
There was a problem hiding this comment.
Task List
Major Learning Goals/Code Review
| Criteria | yes/no, and optionally any details/lines of code to reference |
|---|---|
| At least 6 commits with meaningful commit messages | ✔️ |
| Routes follow RESTful conventions | ✔️ |
Uses named routes (like _path) |
✔️ |
| Creates Models and migrations | ✔️ |
| Creates styled views | no styling! |
| Handles errors like nonexistant tasks | ✔️ |
Uses form_with to render forms in Rails |
✔️ |
Functional Requirements/Manual Testing
| Functional Requirement | yes/no |
|---|---|
| Successfully handles index & show | ✔️ |
| index & show tests pass | ✔️ |
| Successfully handles: New, Create | ✔️ |
| New, Create tests pass | ✔️ |
| Successfully handles: Edit, Update | ✔️ |
| Edit, Update tests pass with valid & invalid task ids | ✔️ |
| Successfully handles: Destroy, Task Complete | ✔️ |
| Tests for Destroy & Task Complete include tests for valid and invalid task ids | missing |
Overall Feedback
| Overall Feedback | Criteria | yes/no |
|---|---|---|
| Green (Meets/Exceeds Standards) | 5+ in Code Review && 6+ in Functional Requirements | ✔️ |
| Yellow (Approaches Standards) | 3+ in Code Review && 5+ in Functional Requirements, or the instructor judges that this project needs special attention | |
| Red (Not at Standard) | 0-2 in Code Review or 0-4 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention |
| <li> | ||
| <div> | ||
| <%= link_to task.name, task_path(task) %> | ||
| <%= button_to "Mark complete", task_complete_path(task), method: :patch%> |
There was a problem hiding this comment.
I might use the data from the task to optionally include this button. :)
Comment on lines
+161
to
+182
| Task.create(name: "Watch The Mandalorian", description: "Watch recap from last season first", completed_at: nil) | ||
| task_hash = { | ||
| task: { | ||
| name: "new task", | ||
| description: "new task description", | ||
| completed_at: Time.now.to_s, | ||
| }, | ||
| } | ||
| task = Task.first | ||
|
|
||
| # Act-Assert | ||
| expect { | ||
| patch task_path(task.id), params: task_hash | ||
| }.must_differ "Task.count", 0 | ||
|
|
||
| new_task = Task.find_by(name: task_hash[:task][:name]) | ||
| expect(new_task.description).must_equal task_hash[:task][:description] | ||
| expect(new_task.completed_at).must_equal task_hash[:task][:completed_at] | ||
|
|
||
| must_respond_with :redirect | ||
| must_redirect_to task_path(new_task.id) | ||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions