From 50910d5fb8f34fe41d537b018c6803b7c666a925 Mon Sep 17 00:00:00 2001 From: Faith Date: Wed, 27 Oct 2021 23:16:16 -0700 Subject: [PATCH 01/10] set up complete, first task for wave 1 testing in postman --- app/__init__.py | 4 +- app/models/task.py | 5 +- app/routes.py | 25 +++++++- migrations/README | 1 + migrations/alembic.ini | 45 +++++++++++++ migrations/env.py | 96 ++++++++++++++++++++++++++++ migrations/script.py.mako | 24 +++++++ migrations/versions/81574f664e68_.py | 39 +++++++++++ 8 files changed, 235 insertions(+), 4 deletions(-) create mode 100644 migrations/README create mode 100644 migrations/alembic.ini create mode 100644 migrations/env.py create mode 100644 migrations/script.py.mako create mode 100644 migrations/versions/81574f664e68_.py diff --git a/app/__init__.py b/app/__init__.py index 2764c4cc8..181365cb7 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -28,7 +28,7 @@ def create_app(test_config=None): db.init_app(app) migrate.init_app(app, db) - + from .routes import tasks_bp # Register Blueprints here - + app.register_blueprint(tasks_bp) return app diff --git a/app/models/task.py b/app/models/task.py index 39c89cd16..5c1023a7f 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -3,4 +3,7 @@ class Task(db.Model): - task_id = db.Column(db.Integer, primary_key=True) + task_id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String) + description = db.Column(db.String) + completed_at = db.Column(db.DateTime, nullable = True) diff --git a/app/routes.py b/app/routes.py index 8e9dfe684..9b10483ff 100644 --- a/app/routes.py +++ b/app/routes.py @@ -1,2 +1,25 @@ -from flask import Blueprint +from flask import Blueprint, jsonify, request, make_response +from app.models.task import Task +from app import db + +# assign tasks_bp to the new Blueprint instance +tasks_bp = Blueprint("tasks", __name__, url_prefix="/tasks") + +@tasks_bp.route("", methods=["POST"]) +def post_one_task(): + request.method == "POST" + request_body = request.get_json() + new_task = Task(title=request_body["title"], + description=request_body["description"], + completed_at=request_body["completed_at"]) + + db.session.add(new_task) + db.session.commit() + # using is_completed to hold Boolean value of datetime which is the data type + # for new_task.completed_at + is_completed = new_task.completed_at is not None + return make_response({"task": {"id": new_task.task_id, + "title": new_task.title, + "description": new_task.description, + "is_complete": is_completed}}) diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..98e4f9c44 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Generic single-database configuration. \ No newline at end of file diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..f8ed4801f --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,45 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..8b3fb3353 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,96 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from sqlalchemy import engine_from_config +from sqlalchemy import pool +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.engine.url).replace('%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = engine_from_config( + config.get_section(config.config_ini_section), + prefix='sqlalchemy.', + poolclass=pool.NullPool, + ) + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/81574f664e68_.py b/migrations/versions/81574f664e68_.py new file mode 100644 index 000000000..7eea6097a --- /dev/null +++ b/migrations/versions/81574f664e68_.py @@ -0,0 +1,39 @@ +"""empty message + +Revision ID: 81574f664e68 +Revises: +Create Date: 2021-10-27 18:32:46.030621 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '81574f664e68' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('goal_id', sa.Integer(), nullable=False), + sa.PrimaryKeyConstraint('goal_id') + ) + op.create_table('task', + sa.Column('task_id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=True), + sa.Column('description', sa.String(), nullable=True), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.PrimaryKeyConstraint('task_id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### From 3fd1759ad19677bcaf8806cdab9df51e457b2d21 Mon Sep 17 00:00:00 2001 From: Faith Date: Thu, 28 Oct 2021 23:04:52 -0700 Subject: [PATCH 02/10] first wave passing all tests and functional in postman --- app/routes.py | 87 ++++++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 73 insertions(+), 14 deletions(-) diff --git a/app/routes.py b/app/routes.py index 9b10483ff..d64aa1971 100644 --- a/app/routes.py +++ b/app/routes.py @@ -1,4 +1,4 @@ -from flask import Blueprint, jsonify, request, make_response +from flask import Blueprint, jsonify, request, make_response, abort from app.models.task import Task from app import db @@ -7,19 +7,78 @@ @tasks_bp.route("", methods=["POST"]) def post_one_task(): - request.method == "POST" request_body = request.get_json() - new_task = Task(title=request_body["title"], - description=request_body["description"], - completed_at=request_body["completed_at"]) + if 'title' not in request_body or 'description' \ + not in request_body or 'completed_at' not in request_body: + return make_response({"details": "Invalid data"}, 400) + else: + new_task = Task(title=request_body["title"], + description=request_body["description"], + completed_at=request_body["completed_at"]) - db.session.add(new_task) - db.session.commit() - # using is_completed to hold Boolean value of datetime which is the data type - # for new_task.completed_at - is_completed = new_task.completed_at is not None - return make_response({"task": {"id": new_task.task_id, - "title": new_task.title, - "description": new_task.description, - "is_complete": is_completed}}) + db.session.add(new_task) + db.session.commit() + # using is_completed to hold Boolean value of datetime which is the data type + # for new_task.completed_at, essentially converting from Null to False + is_complete = new_task.completed_at is not None + return make_response({"task": {"id": new_task.task_id, + "title": new_task.title, + "description": new_task.description, + "is_complete": is_complete}}, 201) + +@tasks_bp.route("", methods=["GET"]) +def get_all_tasks(): + title_query = request.args.get('title') #query params for wave2 + if title_query: + # filter_by returns a list of objects/ records that match the query params + books = Task.query.filter_by(title = title_query) + else: + tasks = Task.query.all() + # query_all return list of objects. loop through lists and add to empt list, task_response + # as requested formatted JSON objects + task_response = [] + + for task in tasks: + is_complete = task.completed_at is not None + task_response.append({ + 'id': task.task_id, + 'title': task.title, + 'description': task.description, + 'is_complete': is_complete}) + + return jsonify(task_response), 200 +@tasks_bp.route("/", methods=["GET", "PUT", "DELETE"]) +def CRUD_one_task(task_id): + task = Task.query.get(task_id) #either get Task back or None + if task is None: +# couldn't figure out another way to return no response body, researched abort + abort(404) +# returning the object's info in the desired data structure format + is_complete = task.completed_at is not None + if request.method == "GET": + return make_response({"task": {"id": task.task_id, + "title": task.title, + "description": task.description, + "is_complete": is_complete}}, 200) + elif request.method == "PUT": + # form data is a local variable to hold the body of the HTTP request + form_data = request.get_json() + # reassigning attributes of the task object using the dict values that came over + # in the request body + task.title = form_data["title"] + task.description = form_data["description"] + task.completed_at = task.completed_at + + db.session.commit() + + return make_response({"task": {"id": task.task_id, + "title": task.title, + "description": task.description, + "is_complete": is_complete}}, 200) + elif request.method == "DELETE": + db.session.delete(task) + db.session.commit() + return make_response({'details': + f'Task {task.task_id} "{task.title}" successfully deleted'}, 200) + From 1163f5237376ab06835a0a1ee5c61fd474737100 Mon Sep 17 00:00:00 2001 From: Faith Date: Fri, 29 Oct 2021 20:57:11 -0700 Subject: [PATCH 03/10] waves 2 and 3 passing all tests --- app/routes.py | 68 +++++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 58 insertions(+), 10 deletions(-) diff --git a/app/routes.py b/app/routes.py index d64aa1971..6ecdb928f 100644 --- a/app/routes.py +++ b/app/routes.py @@ -1,6 +1,8 @@ from flask import Blueprint, jsonify, request, make_response, abort from app.models.task import Task from app import db +from sqlalchemy import desc +from datetime import date, time, datetime # assign tasks_bp to the new Blueprint instance tasks_bp = Blueprint("tasks", __name__, url_prefix="/tasks") @@ -27,15 +29,24 @@ def post_one_task(): "is_complete": is_complete}}, 201) @tasks_bp.route("", methods=["GET"]) -def get_all_tasks(): +def working_with_all_tasks(): title_query = request.args.get('title') #query params for wave2 + order_by_query = request.args.get('sort') if title_query: # filter_by returns a list of objects/ records that match the query params - books = Task.query.filter_by(title = title_query) - else: - tasks = Task.query.all() - # query_all return list of objects. loop through lists and add to empt list, task_response + + tasks = Task.query.filter_by(title = title_query) + # what part of the Task.query is actually accessing the DB? + elif order_by_query == 'asc': + tasks = Task.query.order_by(Task.title).all() + # query_all return list of objects. loop through objects and add to empt list, task_response # as requested formatted JSON objects + elif order_by_query == 'desc': + tasks = Task.query.order_by(desc(Task.title)).all() + # this else covers any search for all tasks, without any query params + else: + tasks = Task.query.order_by(Task.title).all() + task_response = [] for task in tasks: @@ -48,7 +59,7 @@ def get_all_tasks(): return jsonify(task_response), 200 -@tasks_bp.route("/", methods=["GET", "PUT", "DELETE"]) +@tasks_bp.route("/", methods=["GET", "PUT", "DELETE", "PATCH"]) def CRUD_one_task(task_id): task = Task.query.get(task_id) #either get Task back or None if task is None: @@ -76,9 +87,46 @@ def CRUD_one_task(task_id): "title": task.title, "description": task.description, "is_complete": is_complete}}, 200) - elif request.method == "DELETE": - db.session.delete(task) + elif request.method == "PATCH": + form_data = request.get_json() + if "title" in form_data: + task.title = form_data["title"] + if "description" in form_data: + task.description = form_data["description"] + db.session.commit() - return make_response({'details': - f'Task {task.task_id} "{task.title}" successfully deleted'}, 200) + return make_response({"task": {"id": task.task_id, + "title": task.title, + "description": task.description, + "is_complete": is_complete}}, 200) + +@tasks_bp.route("//mark_complete", methods=["PATCH"]) +def mark_task_complete(task_id): + time_stamp = datetime.now() + task = Task.query.get(task_id) #either get Task back or None + if task is None: + abort(404) + else: + task.completed_at = time_stamp + db.session.commit() + is_complete = task.completed_at is not None + return make_response({"task": {"id": task.task_id, + "title": task.title, + "description": task.description, + "is_complete": is_complete}}, 200) + +@tasks_bp.route("//mark_incomplete", methods=["PATCH"]) +def mark_task_incomplete(task_id): + task = Task.query.get(task_id) #either get Task back or None + if task is None: + abort(404) + else: + task.completed_at = None + db.session.commit() + is_complete = task.completed_at is not None + return make_response({"task": {"id": task.task_id, + "title": task.title, + "description": task.description, + "is_complete": is_complete}}, 200) + From 2452fd5219cd8381a6033c8aae164a2897d07be9 Mon Sep 17 00:00:00 2001 From: Faith Date: Mon, 1 Nov 2021 19:24:17 -0700 Subject: [PATCH 04/10] passing tests waves 1-5, new model Goal added --- app/__init__.py | 2 + app/models/goal.py | 3 +- app/routes.py | 86 +++++++++++++++++++++++++++- migrations/versions/161ad4e57543_.py | 28 +++++++++ tests/test_wave_05.py | 70 +++++++++++----------- 5 files changed, 154 insertions(+), 35 deletions(-) create mode 100644 migrations/versions/161ad4e57543_.py diff --git a/app/__init__.py b/app/__init__.py index 181365cb7..e97fe27ac 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -29,6 +29,8 @@ def create_app(test_config=None): db.init_app(app) migrate.init_app(app, db) from .routes import tasks_bp + from .routes import goals_bp # Register Blueprints here app.register_blueprint(tasks_bp) + app.register_blueprint(goals_bp) return app diff --git a/app/models/goal.py b/app/models/goal.py index 8cad278f8..9f6a0e76b 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -3,4 +3,5 @@ class Goal(db.Model): - goal_id = db.Column(db.Integer, primary_key=True) + goal_id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String) \ No newline at end of file diff --git a/app/routes.py b/app/routes.py index 6ecdb928f..e0e3e5f79 100644 --- a/app/routes.py +++ b/app/routes.py @@ -1,11 +1,19 @@ from flask import Blueprint, jsonify, request, make_response, abort from app.models.task import Task +from app.models.goal import Goal from app import db from sqlalchemy import desc from datetime import date, time, datetime +import requests +import os # assign tasks_bp to the new Blueprint instance tasks_bp = Blueprint("tasks", __name__, url_prefix="/tasks") +# assign goals_bp to the new Blueprint instance +goals_bp = Blueprint("goals", __name__, url_prefix="/goals") +slack_path = "https://slack.com/api/chat.postMessage" + + @tasks_bp.route("", methods=["POST"]) def post_one_task(): @@ -99,6 +107,11 @@ def CRUD_one_task(task_id): "title": task.title, "description": task.description, "is_complete": is_complete}}, 200) + elif request.method == "DELETE": + db.session.delete(task) + db.session.commit() + return make_response({'details': + f'Task {task.task_id} "{task.title}" successfully deleted'}, 200) @tasks_bp.route("//mark_complete", methods=["PATCH"]) def mark_task_complete(task_id): @@ -110,6 +123,10 @@ def mark_task_complete(task_id): task.completed_at = time_stamp db.session.commit() is_complete = task.completed_at is not None + query_params = {"channel": "slack-api-test-channel", + "text": f"Someone just completed the task {task.title}"} + header_param = {"Authorization": "Bearer "+ os.environ.get("slack_oauth_token")} + slack_post_body = requests.post(slack_path, params=query_params, headers= header_param) return make_response({"task": {"id": task.task_id, "title": task.title, "description": task.description, @@ -128,5 +145,72 @@ def mark_task_incomplete(task_id): "title": task.title, "description": task.description, "is_complete": is_complete}}, 200) +# Here we are beginning the code for the Goal Model/ Table +@goals_bp.route("", methods=["POST"]) +def post_one_goal(): + request_body = request.get_json() + if 'title' not in request_body : + return make_response({"details": "Invalid data"}, 400) + else: + new_goal = Goal(title=request_body["title"]) + + db.session.add(new_goal) + db.session.commit() + return make_response({"goal": {"id": new_goal.goal_id, + "title": new_goal.title}}, 201) + +@goals_bp.route("", methods=["GET"]) +def working_with_all_goals(): + title_query = request.args.get('title') #query params + order_by_query = request.args.get('sort') + if title_query: + # filter_by returns a list of objects/ records that match the query params - + goals = Goal.query.filter_by(title = title_query) + # what part of the Goal.query is actually accessing the DB? + elif order_by_query == 'asc': + goals = Goal.query.order_by(Goal.title).all() + # query_all return list of objects. loop through objects and add to empt list, task_response + # as requested formatted JSON objects + elif order_by_query == 'desc': + # chaining methods of Goal together + goals = Goal.query.order_by(desc(Goal.title)).all() + # this else covers any search for all goals, without any query params + else: + goals = Goal.query.order_by(Goal.title).all() + + goal_response = [] + for goal in goals: + goal_response.append({ + 'id': goal.goal_id, + 'title': goal.title}) + return jsonify(goal_response), 200 + +@goals_bp.route("/", methods=["GET", "PUT", "DELETE"]) +def CRUD_one_goal(goal_id): + goal = Goal.query.get(goal_id) #either get Goal back or None +# this guard clause checks if the goal_id exists, if not, it will give 404 + if goal is None: +# couldn't figure out another way to return no response body, researched abort + abort(404) +# returning the object's info in the desired data structure format + if request.method == "GET": + return make_response({"goal": {"id": goal.goal_id, + "title": goal.title}}, 200) + elif request.method == "PUT": + # form data is a local variable to hold the body of the HTTP request + form_data = request.get_json() + # reassigning attributes of the goal object using the dict values that came over + # in the request body + goal.title = form_data["title"] + db.session.commit() + + return make_response({"goal": {"id": goal.goal_id, + "title": goal.title}}, 200) + elif request.method == "DELETE": + db.session.delete(goal) + db.session.commit() + return make_response({'details': + f'Goal {goal.goal_id} "{goal.title}" successfully deleted'}, 200) + + diff --git a/migrations/versions/161ad4e57543_.py b/migrations/versions/161ad4e57543_.py new file mode 100644 index 000000000..3deb7d876 --- /dev/null +++ b/migrations/versions/161ad4e57543_.py @@ -0,0 +1,28 @@ +"""empty message + +Revision ID: 161ad4e57543 +Revises: 81574f664e68 +Create Date: 2021-11-01 14:23:41.998654 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '161ad4e57543' +down_revision = '81574f664e68' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('goal', sa.Column('title', sa.String(), nullable=True)) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_column('goal', 'title') + # ### end Alembic commands ### diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index 6ba60c6fa..46d5917c4 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,4 +1,5 @@ import pytest +from app.models.goal import Goal def test_get_goals_no_saved_goals(client): # Act @@ -41,19 +42,16 @@ def test_get_goal(client, one_goal): } } -@pytest.mark.skip(reason="test to be completed by student") + def test_get_goal_not_found(client): - pass + # Act response = client.get("/goals/1") response_body = response.get_json() # Assert - # ---- Complete Test ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Test ---- - + assert response.status_code == 404 + assert response_body == None def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -71,30 +69,38 @@ def test_create_goal(client): } } -@pytest.mark.skip(reason="test to be completed by student") -def test_update_goal(client, one_goal): - pass - # Act - # ---- Complete Act Here ---- - # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here - # ---- Complete Assertions Here ---- +def test_update_goal(client, one_goal): + + response = client.put("/goals/1", json={ + "title": "Updated Goal Title", + + }) + response_body = response.get_json() + +# Assert + assert response.status_code == 200 + assert "goal" in response_body + assert response_body == { + "goal": { + "id": 1, + "title": "Updated Goal Title" + }} + goal = Goal.query.get(1) + assert goal.title == "Updated Goal Title" + -@pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - pass # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + }) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert response_body == None + def test_delete_goal(client, one_goal): @@ -113,18 +119,16 @@ def test_delete_goal(client, one_goal): response = client.get("/goals/1") assert response.status_code == 404 -@pytest.mark.skip(reason="test to be completed by student") -def test_delete_goal_not_found(client): - pass +def test_delete_goal_not_found(client): # Act - # ---- Complete Act Here ---- + response = client.delete("/goals/1") + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert response_body == None + assert Goal.query.all() == [] def test_create_goal_missing_title(client): From d2b8bb3f3b20151dd629419fa4dd381d6321d286 Mon Sep 17 00:00:00 2001 From: Faith Date: Mon, 1 Nov 2021 23:00:25 -0700 Subject: [PATCH 05/10] created Procfile for Heroku --- Procfile | 1 + 1 file changed, 1 insertion(+) create mode 100644 Procfile diff --git a/Procfile b/Procfile new file mode 100644 index 000000000..62e430aca --- /dev/null +++ b/Procfile @@ -0,0 +1 @@ +web: gunicorn 'app:create_app()' \ No newline at end of file From f71dffbd7616b2b9f828c88a80205fc1a76f11b4 Mon Sep 17 00:00:00 2001 From: Faith Date: Wed, 3 Nov 2021 23:46:50 -0700 Subject: [PATCH 06/10] passing tests through wave 6, updates not deployed to heroku yet --- app/models/goal.py | 4 +++- app/models/task.py | 2 ++ app/routes.py | 35 +++++++++++++++++++++++++++- migrations/versions/9b0fe8c7cadc_.py | 30 ++++++++++++++++++++++++ 4 files changed, 69 insertions(+), 2 deletions(-) create mode 100644 migrations/versions/9b0fe8c7cadc_.py diff --git a/app/models/goal.py b/app/models/goal.py index 9f6a0e76b..d8249d126 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -1,7 +1,9 @@ from flask import current_app +from sqlalchemy.orm import backref from app import db class Goal(db.Model): goal_id = db.Column(db.Integer, primary_key=True, autoincrement=True) - title = db.Column(db.String) \ No newline at end of file + title = db.Column(db.String) + tasks = db.relationship("Task", backref = "goal") \ No newline at end of file diff --git a/app/models/task.py b/app/models/task.py index 5c1023a7f..5fcea086a 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -7,3 +7,5 @@ class Task(db.Model): title = db.Column(db.String) description = db.Column(db.String) completed_at = db.Column(db.DateTime, nullable = True) + goal_id = db.Column(db.Integer, db.ForeignKey("goal.goal_id"), nullable = True) + #goal =db.relationship("Goal", back_populates ="task") diff --git a/app/routes.py b/app/routes.py index e0e3e5f79..4668c3609 100644 --- a/app/routes.py +++ b/app/routes.py @@ -79,6 +79,7 @@ def CRUD_one_task(task_id): return make_response({"task": {"id": task.task_id, "title": task.title, "description": task.description, + "goal_id": task.goal_id, "is_complete": is_complete}}, 200) elif request.method == "PUT": # form data is a local variable to hold the body of the HTTP request @@ -212,5 +213,37 @@ def CRUD_one_goal(goal_id): db.session.commit() return make_response({'details': f'Goal {goal.goal_id} "{goal.title}" successfully deleted'}, 200) +# given one goal id, find 3 task ids and associate them with the goal by changing +# their goal_id column(Foreign Key) from nullable to the goal_id of the goal to be associated +@goals_bp.route("//tasks", methods=["POST", "GET"]) +def associate_tasks_with_goal(goal_id): + request_body = request.get_json() + tasks = Task.query.all() + goal = Goal.query.get(goal_id) #either get Goal back or None +# this guard clause checks if the goal_id exists, if not, it will give 404 + if goal is None: +# couldn't figure out another way to return no response body, researched abort + abort(404) + if request.method == "POST": + for task in tasks: + if task.task_id in request_body["task_ids"]: + task.goal_id = int(goal_id) + db.session.commit() + return make_response({"id": int(goal_id), "task_ids": request_body["task_ids"]}, 200) + elif request.method == "GET": + # getting all tasks (attribute of Goal object) associated with given goal_id + goals_tasks = Goal.query.get(goal_id).tasks + + task_response = [] + for task in goals_tasks: + is_complete = task.completed_at is not None + task_response.append({ + 'id': task.task_id, + 'goal_id': task.goal_id, + 'title': task.title, + 'description': task.description, + 'is_complete': is_complete}) - + return make_response({"id": goal.goal_id, "title": goal.title, "tasks": task_response}, 200) + + diff --git a/migrations/versions/9b0fe8c7cadc_.py b/migrations/versions/9b0fe8c7cadc_.py new file mode 100644 index 000000000..a50976621 --- /dev/null +++ b/migrations/versions/9b0fe8c7cadc_.py @@ -0,0 +1,30 @@ +"""empty message + +Revision ID: 9b0fe8c7cadc +Revises: 161ad4e57543 +Create Date: 2021-11-03 15:49:13.820131 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '9b0fe8c7cadc' +down_revision = '161ad4e57543' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('task', sa.Column('goal_id', sa.Integer(), nullable=True)) + op.create_foreign_key(None, 'task', 'goal', ['goal_id'], ['goal_id']) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_constraint(None, 'task', type_='foreignkey') + op.drop_column('task', 'goal_id') + # ### end Alembic commands ### From 9b82b0c747aeeceb3d4578d3d244b12096e91504 Mon Sep 17 00:00:00 2001 From: Faith Date: Thu, 4 Nov 2021 12:29:41 -0700 Subject: [PATCH 07/10] final version, with comments --- app/routes.py | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/app/routes.py b/app/routes.py index 4668c3609..b50f9adca 100644 --- a/app/routes.py +++ b/app/routes.py @@ -11,21 +11,25 @@ tasks_bp = Blueprint("tasks", __name__, url_prefix="/tasks") # assign goals_bp to the new Blueprint instance goals_bp = Blueprint("goals", __name__, url_prefix="/goals") +# assign slack path for slack integration slack_path = "https://slack.com/api/chat.postMessage" @tasks_bp.route("", methods=["POST"]) def post_one_task(): +# request_body will be the user's input, converted to json. it will be a new record +# for the db, with all fields (a dict) request_body = request.get_json() if 'title' not in request_body or 'description' \ not in request_body or 'completed_at' not in request_body: return make_response({"details": "Invalid data"}, 400) else: +# taking infor fr request_body and converting it to new Task object new_task = Task(title=request_body["title"], description=request_body["description"], completed_at=request_body["completed_at"]) - +# committing changes to db db.session.add(new_task) db.session.commit() # using is_completed to hold Boolean value of datetime which is the data type @@ -46,6 +50,7 @@ def working_with_all_tasks(): tasks = Task.query.filter_by(title = title_query) # what part of the Task.query is actually accessing the DB? elif order_by_query == 'asc': + # getting all tasks fr the db tasks = Task.query.order_by(Task.title).all() # query_all return list of objects. loop through objects and add to empt list, task_response # as requested formatted JSON objects @@ -56,7 +61,8 @@ def working_with_all_tasks(): tasks = Task.query.order_by(Task.title).all() task_response = [] - + # looping through each task, converting to requested format (dict) and adding to + # task_response which will be list of dicts for task in tasks: is_complete = task.completed_at is not None task_response.append({ @@ -96,6 +102,7 @@ def CRUD_one_task(task_id): "title": task.title, "description": task.description, "is_complete": is_complete}}, 200) + # patch will change just one part of the record, not the whole record elif request.method == "PATCH": form_data = request.get_json() if "title" in form_data: @@ -116,18 +123,21 @@ def CRUD_one_task(task_id): @tasks_bp.route("//mark_complete", methods=["PATCH"]) def mark_task_complete(task_id): +# setting current datetime to time_stamp to use to mark task.completed_at time_stamp = datetime.now() task = Task.query.get(task_id) #either get Task back or None if task is None: abort(404) else: task.completed_at = time_stamp +# now db record shows timestamp for completed_at db.session.commit() is_complete = task.completed_at is not None query_params = {"channel": "slack-api-test-channel", "text": f"Someone just completed the task {task.title}"} header_param = {"Authorization": "Bearer "+ os.environ.get("slack_oauth_token")} slack_post_body = requests.post(slack_path, params=query_params, headers= header_param) +# response body doesn't want to show timestamp, just True, so changing is_complete to True return make_response({"task": {"id": task.task_id, "title": task.title, "description": task.description, @@ -222,9 +232,10 @@ def associate_tasks_with_goal(goal_id): goal = Goal.query.get(goal_id) #either get Goal back or None # this guard clause checks if the goal_id exists, if not, it will give 404 if goal is None: -# couldn't figure out another way to return no response body, researched abort abort(404) if request.method == "POST": +# checking all tasks, if that task_id is in the list which came from Request_body, reassign value +# of task.goal_id (need to convert to int bc goal_id is user input and is a string) for task in tasks: if task.task_id in request_body["task_ids"]: task.goal_id = int(goal_id) From 1603bc2e44830c5e9050036966a44fc8508c7da2 Mon Sep 17 00:00:00 2001 From: Faith Date: Thu, 4 Nov 2021 12:44:24 -0700 Subject: [PATCH 08/10] Passing ALL tests --- app/routes.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/routes.py b/app/routes.py index b50f9adca..dd83b4b33 100644 --- a/app/routes.py +++ b/app/routes.py @@ -82,11 +82,17 @@ def CRUD_one_task(task_id): # returning the object's info in the desired data structure format is_complete = task.completed_at is not None if request.method == "GET": - return make_response({"task": {"id": task.task_id, + if task.goal_id: + return make_response({"task": {"id": task.task_id, "title": task.title, "description": task.description, "goal_id": task.goal_id, "is_complete": is_complete}}, 200) + else: + return make_response({"task": {"id": task.task_id, + "title": task.title, + "description": task.description, + "is_complete": is_complete}}, 200) elif request.method == "PUT": # form data is a local variable to hold the body of the HTTP request form_data = request.get_json() From f37cc6e59796e11bb84a1b0b855a767cb058ce58 Mon Sep 17 00:00:00 2001 From: Faith Date: Thu, 4 Nov 2021 20:28:07 -0700 Subject: [PATCH 09/10] Fix for slack API issue --- app/routes.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/app/routes.py b/app/routes.py index dd83b4b33..b2779a08b 100644 --- a/app/routes.py +++ b/app/routes.py @@ -139,10 +139,14 @@ def mark_task_complete(task_id): # now db record shows timestamp for completed_at db.session.commit() is_complete = task.completed_at is not None - query_params = {"channel": "slack-api-test-channel", + + try: + query_params = {"channel": "slack-api-test-channel", "text": f"Someone just completed the task {task.title}"} - header_param = {"Authorization": "Bearer "+ os.environ.get("slack_oauth_token")} - slack_post_body = requests.post(slack_path, params=query_params, headers= header_param) + header_param = {"Authorization": "Bearer "+ os.environ.get("slack_oauth_token")} + slack_post_body = requests.post(slack_path, params=query_params, headers= header_param) + except TypeError: + pass # response body doesn't want to show timestamp, just True, so changing is_complete to True return make_response({"task": {"id": task.task_id, "title": task.title, From 9a7fae11482654107fb224acbe547011d4c71592 Mon Sep 17 00:00:00 2001 From: FaithKauwe <87450451+FaithKauwe@users.noreply.github.com> Date: Wed, 17 Nov 2021 13:41:03 -0800 Subject: [PATCH 10/10] Update app/__init__.py Co-authored-by: Trenisha Goslee <60710670+tgoslee@users.noreply.github.com> --- app/__init__.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/__init__.py b/app/__init__.py index e97fe27ac..7879a7f47 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -28,8 +28,7 @@ def create_app(test_config=None): db.init_app(app) migrate.init_app(app, db) - from .routes import tasks_bp - from .routes import goals_bp + from .routes import tasks_bp, goals_bp # Register Blueprints here app.register_blueprint(tasks_bp) app.register_blueprint(goals_bp)