diff --git a/app/__init__.py b/app/__init__.py index 2764c4cc8..ff7dc40df 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -21,6 +21,8 @@ def create_app(test_config=None): app.config["TESTING"] = True app.config["SQLALCHEMY_DATABASE_URI"] = os.environ.get( "SQLALCHEMY_TEST_DATABASE_URI") + app.config["SLACK_TOKEN"] = os.environ.get("SLACK_TOKEN") + # Import models here for Alembic setup from app.models.task import Task @@ -30,5 +32,8 @@ def create_app(test_config=None): migrate.init_app(app, db) # Register Blueprints here - + from app.routes import tasks_bp + from app.routes import goals_bp + app.register_blueprint(tasks_bp) + app.register_blueprint(goals_bp) return app diff --git a/app/models/goal.py b/app/models/goal.py index b0ed11dd8..433049e4f 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -1,5 +1,12 @@ from app import db - class Goal(db.Model): goal_id = db.Column(db.Integer, primary_key=True) + title = db.Column(db.String(56)) + tasks = db.relationship('Task', backref='goal', lazy=True) + + def to_dict(self): + return{ + "id": self.goal_id, + "title": self.title, + } diff --git a/app/models/task.py b/app/models/task.py index c91ab281f..f04d45f79 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -1,5 +1,22 @@ from app import db - +# create task model, define 'Task' using SQLAlchemy class Task(db.Model): task_id = db.Column(db.Integer, primary_key=True) + title = db.Column(db.String(56)) + description = db.Column(db.String(200)) + completed_at = db.Column(db.DateTime, nullable=True) + goal_id = db.Column(db.Integer, db.ForeignKey("goal.goal_id"), nullable=True) + goal = db.relationship("Goal", back) + def to_dict(self): + task_dict = { + "id": self.task_id, + "title": self.title, + "description": self.description, + "is_complete": True if self.completed_at else False + } + + if self.goal_id: + task_dict["goal_id"] = self.goal_id + + return task_dict \ No newline at end of file diff --git a/app/routes.py b/app/routes.py index 3aae38d49..4572713fc 100644 --- a/app/routes.py +++ b/app/routes.py @@ -1 +1,306 @@ -from flask import Blueprint \ No newline at end of file +from flask import Blueprint, jsonify, request +from app import db +from app.models.task import Task +from app.models.goal import Goal +from datetime import datetime +import requests + +tasks_bp = Blueprint("tasks", __name__, url_prefix=("/tasks")) +goals_bp = Blueprint("goals", __name__, url_prefix="/goals") + +# create route (get) to get all tasks +@tasks_bp.route("", methods=["GET"]) +def get_all_tasks(): + tasks_response = [] + sort = request.args.get("sort") + + if sort == "asc": + tasks = Task.query.order_by(Task.title.asc()).all() + elif sort == "desc": + tasks = Task.query.order_by(Task.title.desc()).all() + else: + tasks = Task.query.all() + + for task in tasks: + tasks_response.append({ + "id": task.task_id, + "title": task.title, + "description": task.description, + "is_complete": task.completed_at != None + }) + + return jsonify(tasks_response) + + +# create a task +@tasks_bp.route("", methods=["POST"]) +def create_task(): + request_body = request.get_json() + + if "title" not in request_body or "description" not in request_body: + return jsonify({"details": "Invalid data"}), 400 + + new_task = Task( + title = request_body.get("title"), + description = request_body.get("description"), + completed_at = request_body.get("completed_at") + ) + + db.session.add(new_task) + db.session.commit() + + return jsonify({ + "task": { + "id": new_task.task_id, + "title": new_task.title, + "description": new_task.description, + "is_complete": new_task.completed_at != None + } + }), 201 + + +# get a specific task +@tasks_bp.route("/", methods=["GET"]) +def get_specific_task(task_id): + task = Task.query.get_or_404(task_id) + + return jsonify({ + "task": { + "id": task.task_id, + "title": task.title, + "description": task.desciption, + "is_complete": task.completed_at != None + } + }) + + + +# update a task +@tasks_bp.route("/", methods=["PUT"]) +def update_task(task_id): + task = Task.query.get(task_id) + request_body = request.get_json() + + if task is None: + return jsonify({"details": f"Task {task_id} was not found."}), 404 + + task.title = request_body.get("title", task.title) + task.description = request_body.get("description", task.description) + + db.session.commit() + + return jsonify({ + "task": { + "id": task.task_id, + "title": task.title, + "description": task.description, + "is_complete": task.completed_at != None + } + }) + + +# detele a task & return 404 + message if not found +@tasks_bp.route("/", methods=["DELETE"]) +def delete_task(task_id): + task = Task.query.get(task_id) + + if task is None: + return jsonify({"details": f"Task {task_id} was not found."}), 404 + + db.session.delete(task) + db.session.commit() + + return jsonify({ + "details": f'Task {task_id} "{task.title}" successfully deleted' + }) + + +# Get task not found +@tasks_bp.route("/", methods=["GET"]) +def get_task_not_found(task_id): + task = Task.query.get(task_id) + + if task is None: + return jsonify({"details": f"Task {task_id} was not found."}), 404 + + return jsonify({ + "task": { + "id": task.task_id, + "title": task.title, + "description": task.description, + "is_complete": task.completed_at != None + } + }) + +# mark task complete +@tasks_bp.route("//mark_complete", methods=["PATCH"]) +def mark_complete(task_id): + task = Task.query.get(task_id) + + if task is None: + return jsonify({"details": f"Task {task_id} was not found."}), 404 + + task.completed_at = datetime.now() + db.session.add(task) + db.session.commit() + + message = f"Task {task.title} is complete." + send_slack_request("study-sesh", message) + + return jsonify({ + "task": { + "id": task.task_id, + "title": task.title, + "description": task.description, + "is_complete": True + } + }) + + +@tasks_bp.route("//mark_incomplete", methods=["PATCH"]) +def mark_incomplete(task_id): + task = Task.query.get(task_id) + + if task is None: + return jsonify({"details": f"Task {task_id} was not found."}), 404 + + task.completed_at = None + db.session.add(task) + db.session.commit() + + return jsonify({ + "task": { + "id": task.task_id, + "title": task.title, + "description": task.description, + "is_complete": False + } + }) + + +# create function that sends request to slack API +def send_slack_request(channel, message): + path = "https://slack.com/api/chat.postMessage" + headers = { + "Type": "application/json", + "Authorization": "xoxb-4715007748918-5273625376965-Fd54AOr5GENxXWt10KbNsgpE" + } + payload = { + "channel": channel, + "text": message + } + response = requests.post(path, headers=headers, json=payload) + response.raise_for_status() + + +# get a goal +@goals_bp.route("", methods=["GET"]) +def get_goals(): + goals = Goal.query.all() + goals_dict = [goal.to_dict() for goal in goals] + return jsonify(goals_dict) + + +# create a new goal +@goals_bp.route("", methods=["POST"]) +def create_goal(): + request_data = request.get_json() + if "title" not in request_data: + return jsonify({"details": "Invalid data"}), 400 + + title = request_data["title"] + goal = Goal(title=title) + db.session.add(goal) + db.session.commit() + + return jsonify({"goal": goal.to_dict()}), 201 + + +# update existing goal +@goals_bp.route("/", methods=["PUT"]) +def update_goal(goal_id): + goal = Goal.query.get(goal_id) + + if goal is None: + return jsonify({"details": f"Goal {goal_id} was not found."}), 404 + + request_data = request.get_json() + goal.title = request_data.get("title", goal.title) + db.session.commit() + + return jsonify({"goal": goal.to_dict()}) + + +# get specific goal/ account for 404 +@goals_bp.route("/", methods=["GET"]) +def get_goal(goal_id): + goal = Goal.query.get(goal_id) + + if goal is None: + return jsonify({"details": f"Goal {goal_id} was not found."}), 404 + + return jsonify({"goal": goal.to_dict()}) + + +# delete a goal +@goals_bp.route("/", methods=["DELETE"]) +def delete_goal(goal_id): + goal = Goal.query.get(goal_id) + + if goal is None: + return jsonify({"details": f"Goal {goal_id} was not found."}), 404 + + db.session.delete(goal) + db.session.commit() + + return jsonify({ + "details": f'Goal {goal.goal_id} "{goal.title}" successfully deleted' + }), 200 + + +# Add a task to a goal +@goals_bp.route("//tasks", methods=["POST"]) +def goal_tasks_post(goal_id): + goal = Goal.query.get(goal_id) + + if not goal: + return {"message": f"Goal {goal_id} not found"}, 404 + + request_body = request.get_json() + + answer = { + "id": goal.goal_id, + "task_ids": request_body["task_ids"], + } + + for task_id in request_body["task_ids"]: + task = Task.query.get(task_id) + if not task: + return { + "message": + f"Task {task_id} not found" + }, 404 + + goal.tasks.append(task) + + db.session.commit() + + return answer, 200 + +# get task for specific goal +@goals_bp.route("//tasks", methods=["GET"]) +def get_task_for_goal(goal_id): + goal = Goal.query.get(goal_id) + if not goal: + return {"message": f"Goal not found"}, 404 + + answer = { + "id": goal.goal_id, + "title": goal.title, + "tasks": [], + } + + for task in goal.tasks: + answer["tasks"].append(task.to_dict()) + + return answer, 200 \ No newline at end of file diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..98e4f9c44 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Generic single-database configuration. \ No newline at end of file diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..f8ed4801f --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,45 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..8b3fb3353 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,96 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from sqlalchemy import engine_from_config +from sqlalchemy import pool +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.engine.url).replace('%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = engine_from_config( + config.get_section(config.config_ini_section), + prefix='sqlalchemy.', + poolclass=pool.NullPool, + ) + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/38bf936215d8_.py b/migrations/versions/38bf936215d8_.py new file mode 100644 index 000000000..977cee128 --- /dev/null +++ b/migrations/versions/38bf936215d8_.py @@ -0,0 +1,42 @@ +"""empty message + +Revision ID: 38bf936215d8 +Revises: +Create Date: 2023-05-24 15:06:53.307585 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '38bf936215d8' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('goal_id', sa.Integer(), nullable=False), + sa.Column('title', sa.String(length=56), nullable=True), + sa.PrimaryKeyConstraint('goal_id') + ) + op.create_table('task', + sa.Column('task_id', sa.Integer(), nullable=False), + sa.Column('title', sa.String(length=56), nullable=True), + sa.Column('description', sa.String(length=200), nullable=True), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.Column('goal_id', sa.Integer(), nullable=True), + sa.ForeignKeyConstraint(['goal_id'], ['goal.goal_id'], ), + sa.PrimaryKeyConstraint('task_id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/requirements.txt b/requirements.txt index 453f0ef6a..552c57235 100644 --- a/requirements.txt +++ b/requirements.txt @@ -5,6 +5,7 @@ blinker==1.4 certifi==2020.12.5 chardet==4.0.0 click==7.1.2 +coverage==7.2.5 Flask==1.1.2 Flask-Migrate==2.6.0 Flask-SQLAlchemy==2.4.4 @@ -30,5 +31,6 @@ requests==2.25.1 six==1.15.0 SQLAlchemy==1.3.23 toml==0.10.2 +tomli==2.0.1 urllib3==1.26.5 Werkzeug==1.0.1 diff --git a/tests/conftest.py b/tests/conftest.py index 6639378e6..4f027cee9 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -39,6 +39,7 @@ def one_task(app): title="Go on my daily walk 🏞", description="Notice something new every day", completed_at=None) db.session.add(new_task) db.session.commit() + return new_task # This fixture gets called in every test that @@ -47,15 +48,18 @@ def one_task(app): # them in the database @pytest.fixture def three_tasks(app): - db.session.add_all([ + tasks = [ Task( title="Water the garden 🌷", description="", completed_at=None), Task( title="Answer forgotten email 📧", description="", completed_at=None), Task( title="Pay my outstanding tickets 😭", description="", completed_at=None) - ]) + ] + db.session.add_all(tasks) db.session.commit() + return tasks + # This fixture gets called in every test that @@ -68,6 +72,7 @@ def completed_task(app): title="Go on my daily walk 🏞", description="Notice something new every day", completed_at=datetime.utcnow()) db.session.add(new_task) db.session.commit() + return new_task # This fixture gets called in every test that @@ -78,6 +83,7 @@ def one_goal(app): new_goal = Goal(title="Build a habit of going outside daily") db.session.add(new_goal) db.session.commit() + return new_goal # This fixture gets called in every test that @@ -91,3 +97,4 @@ def one_task_belongs_to_one_goal(app, one_goal, one_task): goal = Goal.query.first() goal.tasks.append(task) db.session.commit() + return task diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index dca626d78..e5a68f274 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -13,7 +13,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -32,7 +32,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -51,7 +51,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -60,13 +60,13 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + assert response_body == {"details": "Task 1 was not found."} # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -93,7 +93,7 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -119,7 +119,7 @@ def test_update_task(client, one_task): assert task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -130,14 +130,14 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") + + assert response_body == {"details": "Task 1 was not found."} # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -152,7 +152,7 @@ def test_delete_task(client, one_task): assert Task.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -160,8 +160,8 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") + + assert response_body == {"details": "Task 1 was not found."} # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** @@ -169,7 +169,7 @@ def test_delete_task_not_found(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -186,7 +186,7 @@ def test_create_task_must_contain_title(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..651e3aebd 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index 32d379822..acddc4183 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -5,7 +5,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -42,7 +42,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -62,7 +62,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -99,7 +99,7 @@ def test_mark_complete_on_completed_task(client, completed_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -119,7 +119,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -127,14 +127,14 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") + assert response_body == {"details": "Task 1 was not found."} + # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -142,8 +142,8 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") + assert response_body == {"details": "Task 1 was not found."} + # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index aee7c52a1..21aa0276c 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,9 @@ import pytest +from app.models.goal import Goal -@pytest.mark.skip(reason="No way to test this feature yet") + +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +14,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -29,7 +31,7 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +48,18 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") - # Assert - # ---- Complete Test ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Test ---- + assert response.status_code == 404 + assert response_body == {"details": "Goal 1 was not found."} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,34 +78,38 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + }) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 200 + assert "goal" in response_body + assert response_body == { + "goal": { + "id": 1, + "title": "Updated Goal Title" + } + } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") - # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + }) + response_body = response.get_json() + + assert response.status_code == 404 + assert response_body == {"details": "Goal 1 was not found."} - # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -117,34 +119,23 @@ def test_delete_goal(client, one_goal): assert response.status_code == 200 assert "details" in response_body assert response_body == { - "details": 'Goal 1 "Build a habit of going outside daily" successfully deleted' - } - - # Check that the goal was deleted - response = client.get("/goals/1") - assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") + "details": 'Goal 1 "Build a habit of going outside daily" successfully deleted' +} # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") - - # Act - # ---- Complete Act Here ---- - - # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + response = client.delete("/goals/1") + response_body = response.get_json() + + assert response.status_code == 404 + assert response_body == {"details": "Goal 1 was not found."} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) @@ -155,3 +146,4 @@ def test_create_goal_missing_title(client): assert response_body == { "details": "Invalid data" } + diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 8afa4325e..9608558a5 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -23,7 +23,7 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(Goal.query.get(1).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -42,7 +42,7 @@ def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_on assert len(Goal.query.get(1).tasks) == 2 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -50,14 +50,10 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 + assert response_body == {"message": "Goal not found"} - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -74,7 +70,7 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -99,7 +95,7 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json()