diff --git a/app/__init__.py b/app/__init__.py index 3c581ceeb..7d071a8f0 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -1,6 +1,9 @@ from flask import Flask from .db import db, migrate from .models import task, goal +from .routes.task_routes import tasks_bp +from .routes.goal_routes import bp as goals_bp +from .models import goal import os def create_app(config=None): @@ -18,5 +21,8 @@ def create_app(config=None): migrate.init_app(app, db) # Register Blueprints here + app.register_blueprint(tasks_bp) + app.register_blueprint(goals_bp) + return app diff --git a/app/models/goal.py b/app/models/goal.py index 44282656b..fd52ee2ad 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -1,5 +1,17 @@ -from sqlalchemy.orm import Mapped, mapped_column +from sqlalchemy.orm import Mapped, mapped_column, relationship from ..db import db class Goal(db.Model): id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) + title: Mapped[str] + tasks: Mapped[list["Task"]] = relationship(back_populates="goal") + + def to_dict(self): + return dict ( + id=self.id, + title=self.title, + ) + @classmethod + def from_dict(cls, goal_data): + return cls( + title=goal_data["title"]) diff --git a/app/models/task.py b/app/models/task.py index 5d99666a4..b4b93459d 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -1,5 +1,43 @@ -from sqlalchemy.orm import Mapped, mapped_column +from sqlalchemy.orm import Mapped, mapped_column , relationship +from sqlalchemy import ForeignKey from ..db import db +from datetime import datetime +from typing import Optional class Task(db.Model): id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) + title : Mapped[str] + description : Mapped [str] + completed_at: Mapped[Optional[datetime]] + goal_id: Mapped[Optional[int]] = mapped_column(ForeignKey("goal.id")) + goal : Mapped[Optional["Goal"]] = relationship(back_populates="tasks") + + def to_dict(self): + is_complete_task= False + if self.completed_at: + is_complete_task = True + + task_dict = dict( + id=self.id, + title=self.title, + description=self.description, + is_complete=is_complete_task, + + ) + if self.goal: + task_dict["goal_id"] = self.goal.id + + return task_dict + + @classmethod + def from_dict(cls, task_data): + return cls( + title=task_data["title"], + description=task_data["description"], + completed_at=None, + goal_id=task_data.get("goal_id", None) + + ) + + + \ No newline at end of file diff --git a/app/routes/goal_routes.py b/app/routes/goal_routes.py index 3aae38d49..958090309 100644 --- a/app/routes/goal_routes.py +++ b/app/routes/goal_routes.py @@ -1 +1,106 @@ -from flask import Blueprint \ No newline at end of file +from flask import Blueprint,request,abort,make_response +from app.models.goal import Goal +from ..db import db +from .route_utilities import validate_model +from app.models.task import Task + + +bp = Blueprint("goals_bp", __name__, url_prefix="/goals") + +@bp.post("") +def create_goal(): + request_body = request.get_json() + + try: + new_goal = Goal.from_dict(request_body) + + except KeyError as error: + response = {"details":f"Invalid data"} + abort(make_response(response,400)) + + db.session.add(new_goal) + db.session.commit() + + response = {"goal" : new_goal.to_dict()} + return response,201 + +@bp.get("") +def get_all_goals(): + + query = db.select(Goal) + sorted_title = request.args.get("sort") + if sorted_title == "desc": + query = query.order_by(Goal.title.desc()) + else: + query = query.order_by(Goal.title.asc()) + + goals = db.session.scalars(query) + + goals_response =([goal.to_dict() for goal in goals],200) + + return goals_response + +@bp.get("/") +def get_single_goal(goal_id): + goal = validate_model(Goal, goal_id) + + return {"goal" : goal.to_dict()} + +@bp.put("/") +def update_goal(goal_id): + goal = validate_model(Goal, goal_id) + request_body = request.get_json() + + + goal.title = request_body["title"] + + db.session.commit() + return {"goal" : goal.to_dict()} + +@bp.delete("/") +def delete_goal(goal_id): + goal = validate_model(Goal, goal_id) + + db.session.delete(goal) + db.session.commit() + + return { + "details": 'Goal 1 "Build a habit of going outside daily" successfully deleted' + } + +@bp.post("//tasks") +def create_task_with_goal_id(goal_id): + goal = validate_model(Goal, goal_id) + + request_body = request.get_json() + + task_ids = request_body["task_ids"] + for task_id in task_ids: + new_task_id = validate_model(Task, task_id) + + goal.tasks.append(new_task_id) + + db.session.commit() + + response = { + "id": goal.id, + "task_ids" : task_ids + } + + return response + +@bp.get("//tasks") +def get_tasks_of_goal(goal_id): + goal = validate_model(Goal,goal_id) + + all_tasks= [] + for task in goal.tasks: + all_tasks.append(task.to_dict()) + + response = { + "id": goal.id, + "title": goal.title, + "tasks": all_tasks + } + + return response diff --git a/app/routes/route_utilities.py b/app/routes/route_utilities.py new file mode 100644 index 000000000..485c02357 --- /dev/null +++ b/app/routes/route_utilities.py @@ -0,0 +1,16 @@ +from flask import abort, make_response +from ..db import db + +def validate_model(cls, model_id): + try: + model_id = int(model_id) + except: + abort(make_response({"message":f"{cls.__name__} id {(model_id)} invalid"}, 400)) + + query = db.select(cls).where(cls.id == model_id) + model = db.session.scalar(query) + + if not model: + abort(make_response({"message":f"{cls.__name__} {model_id} not found"},404)) + + return model \ No newline at end of file diff --git a/app/routes/task_routes.py b/app/routes/task_routes.py index 3aae38d49..d1a8f028a 100644 --- a/app/routes/task_routes.py +++ b/app/routes/task_routes.py @@ -1 +1,106 @@ -from flask import Blueprint \ No newline at end of file +from flask import Blueprint,request,abort,make_response,Response +from app.models.task import Task +from ..db import db +from datetime import date +import os +import requests +from .route_utilities import validate_model + +tasks_bp = Blueprint("tasks_bp",__name__, url_prefix="/tasks") + +@tasks_bp.post("") +def create_task(): + request_body = request.get_json() + + try: + new_task = Task.from_dict(request_body) + + except KeyError as error: + response = {"details":f"Invalid data"} + abort(make_response(response,400)) + + + db.session.add(new_task) + db.session.commit() + + response = {"task" : new_task.to_dict()} + + return response,201 + +@tasks_bp.get("") +def get_all_tasks(): + + query = db.select(Task) + sorted_title = request.args.get("sort") + if sorted_title == "desc": + query = query.order_by(Task.title.desc()) + else: + query = query.order_by(Task.title.asc()) + + tasks = db.session.scalars(query) + + tasks_response =([task.to_dict() for task in tasks],200) + + return tasks_response + + +@tasks_bp.get("/") +def get_single_task(task_id): + task = validate_model(Task, task_id) + + return {"task" : task.to_dict()} + +@tasks_bp.put("/") +def update_task(task_id): + task = validate_model(Task, task_id) + request_body = request.get_json() + + task.title = request_body["title"] + task.description = request_body["description"] + task.completed_at = None + + db.session.commit() + return {"task" : task.to_dict()} + +@tasks_bp.delete("/") +def delete_task(task_id): + task = validate_model(Task, task_id) + + db.session.delete(task) + db.session.commit() + + return {"details": f'Task {task_id} "{task.title}" successfully deleted'} + +@tasks_bp.patch("//mark_complete") +def partial_update_complete_one_task(task_id): + task = validate_model(Task, task_id) + + task.completed_at = date.today() + + db.session.add(task) + db.session.commit() + + message = f"Someone just completed the task My Beautiful {task.title}" + + slack_response = requests.post (f"https://slack.com/api/chat.postMessage?channel=C07V6E62DS7&text={message}",headers = {"Authorization":f"Bearer {os.environ.get('SLACK_AUTHENTICATION')}"}) + + + return {"task":task.to_dict()} + +@tasks_bp.patch("//mark_incomplete") +def partial_update_incomplete_task(task_id): + task= validate_model(Task, task_id) + + task.completed_at = None + + db.session.add(task) + db.session.commit() + + return {"task":task.to_dict()} + + + + + + + diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..0e0484415 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Single-database configuration for Flask. diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..ec9d45c26 --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,50 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic,flask_migrate + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[logger_flask_migrate] +level = INFO +handlers = +qualname = flask_migrate + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..4c9709271 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,113 @@ +import logging +from logging.config import fileConfig + +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + + +def get_engine(): + try: + # this works with Flask-SQLAlchemy<3 and Alchemical + return current_app.extensions['migrate'].db.get_engine() + except (TypeError, AttributeError): + # this works with Flask-SQLAlchemy>=3 + return current_app.extensions['migrate'].db.engine + + +def get_engine_url(): + try: + return get_engine().url.render_as_string(hide_password=False).replace( + '%', '%%') + except AttributeError: + return str(get_engine().url).replace('%', '%%') + + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option('sqlalchemy.url', get_engine_url()) +target_db = current_app.extensions['migrate'].db + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def get_metadata(): + if hasattr(target_db, 'metadatas'): + return target_db.metadatas[None] + return target_db.metadata + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=get_metadata(), literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + conf_args = current_app.extensions['migrate'].configure_args + if conf_args.get("process_revision_directives") is None: + conf_args["process_revision_directives"] = process_revision_directives + + connectable = get_engine() + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=get_metadata(), + **conf_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/45bf98bf0457_updated.py b/migrations/versions/45bf98bf0457_updated.py new file mode 100644 index 000000000..f3c6b2f4e --- /dev/null +++ b/migrations/versions/45bf98bf0457_updated.py @@ -0,0 +1,38 @@ +"""updated + +Revision ID: 45bf98bf0457 +Revises: ab00d76c036f +Create Date: 2024-11-04 13:17:42.757418 + +""" +from alembic import op +import sqlalchemy as sa +from sqlalchemy.dialects import postgresql + +# revision identifiers, used by Alembic. +revision = '45bf98bf0457' +down_revision = 'ab00d76c036f' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('task', schema=None) as batch_op: + batch_op.alter_column('completed_at', + existing_type=postgresql.TIMESTAMP(), + type_=sa.Date(), + existing_nullable=True) + + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('task', schema=None) as batch_op: + batch_op.alter_column('completed_at', + existing_type=sa.Date(), + type_=postgresql.TIMESTAMP(), + existing_nullable=True) + + # ### end Alembic commands ### diff --git a/migrations/versions/982ee81a6f3f_created_new_model.py b/migrations/versions/982ee81a6f3f_created_new_model.py new file mode 100644 index 000000000..eeed1c25c --- /dev/null +++ b/migrations/versions/982ee81a6f3f_created_new_model.py @@ -0,0 +1,32 @@ +"""created new model + +Revision ID: 982ee81a6f3f +Revises: f6d8609209ad +Create Date: 2024-11-05 20:40:26.843242 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '982ee81a6f3f' +down_revision = 'f6d8609209ad' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('goal', schema=None) as batch_op: + batch_op.add_column(sa.Column('title', sa.String(), nullable=False)) + + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('goal', schema=None) as batch_op: + batch_op.drop_column('title') + + # ### end Alembic commands ### diff --git a/migrations/versions/ab00d76c036f_adds_task_model.py b/migrations/versions/ab00d76c036f_adds_task_model.py new file mode 100644 index 000000000..2f6718f30 --- /dev/null +++ b/migrations/versions/ab00d76c036f_adds_task_model.py @@ -0,0 +1,39 @@ +"""adds Task model + +Revision ID: ab00d76c036f +Revises: +Create Date: 2024-10-31 14:29:33.586422 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'ab00d76c036f' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.PrimaryKeyConstraint('id') + ) + op.create_table('task', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=False), + sa.Column('description', sa.String(), nullable=False), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.PrimaryKeyConstraint('id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/migrations/versions/bf3c8e436592_updated.py b/migrations/versions/bf3c8e436592_updated.py new file mode 100644 index 000000000..a45096615 --- /dev/null +++ b/migrations/versions/bf3c8e436592_updated.py @@ -0,0 +1,34 @@ +"""updated + +Revision ID: bf3c8e436592 +Revises: 982ee81a6f3f +Create Date: 2024-11-06 18:52:39.204382 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'bf3c8e436592' +down_revision = '982ee81a6f3f' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('task', schema=None) as batch_op: + batch_op.add_column(sa.Column('goal_id', sa.Integer(), nullable=True)) + batch_op.create_foreign_key(None, 'goal', ['goal_id'], ['id']) + + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('task', schema=None) as batch_op: + batch_op.drop_constraint(None, type_='foreignkey') + batch_op.drop_column('goal_id') + + # ### end Alembic commands ### diff --git a/migrations/versions/f6d8609209ad_update.py b/migrations/versions/f6d8609209ad_update.py new file mode 100644 index 000000000..abb38d643 --- /dev/null +++ b/migrations/versions/f6d8609209ad_update.py @@ -0,0 +1,38 @@ +"""update + +Revision ID: f6d8609209ad +Revises: 45bf98bf0457 +Create Date: 2024-11-04 16:45:24.336934 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'f6d8609209ad' +down_revision = '45bf98bf0457' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('task', schema=None) as batch_op: + batch_op.alter_column('completed_at', + existing_type=sa.DATE(), + type_=sa.DateTime(), + existing_nullable=True) + + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('task', schema=None) as batch_op: + batch_op.alter_column('completed_at', + existing_type=sa.DateTime(), + type_=sa.DATE(), + existing_nullable=True) + + # ### end Alembic commands ### diff --git a/seed.py b/seed.py new file mode 100644 index 000000000..4da5c6c1b --- /dev/null +++ b/seed.py @@ -0,0 +1,23 @@ +from app import create_app, db +from app.models.task import Task + +my_app = create_app() +with my_app.app_context(): + db.session.add(Task(title="Cooking", description="Cooking biriyani", completed_at=None)), + db.session.add(Task(title="Baking", description="Baking rainbow cupcakes", completed_at=None)), + db.session.add(Task(title="Hiking", description="Hiking mount-Rainier", completed_at=None)), + db.session.add(Task(title="Painting", description="Painting tropical flowers", completed_at=None)), + db.session.add(Task(title="Grocery", description="Doing weekly grocery", completed_at=None)), + db.session.add(Task(title="Coding", description="Coding python", completed_at=None)), + db.session.add(Task(title="Learning", description="Learning a new language", completed_at=None)), + db.session.add(Task(title="Watching", description="Watching 5 comedy movies", completed_at=None)), + db.session.add(Task(title="Reading", description="Reading a 10 books", completed_at=None)), + db.session.add(Task(title="Traveling", description="Traveling to all the US National parks", completed_at=None)), + db.session.add(Task(title="Volunteering", description="Volunteering at elementary school", completed_at=None)), + db.session.add(Task(title="Planting", description="Planting 20 tropical indoor plants", completed_at=None)), + db.session.add(Task(title="Writing", description="Writing a children's book", completed_at=None)), + db.session.add(Task(title="Walking", description="Walking through a hiking trail with friends", completed_at=None)), + db.session.add(Task(title="Playing", description="Playing Piano", completed_at=None)), + db.session.add(Task(title="Crafting", description="Making decorative crafts", completed_at=None)), + db.session.add(Task(title="Driving", description="Drive through mounatains and caves", completed_at=None)), + db.session.commit() \ No newline at end of file diff --git a/tests/conftest.py b/tests/conftest.py index e370e597b..8ded1628f 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -77,7 +77,7 @@ def three_tasks(app): def completed_task(app): new_task = Task(title="Go on my daily walk 🏞", description="Notice something new every day", - completed_at=datetime.utcnow()) + completed_at=datetime.now()) db.session.add(new_task) db.session.commit() diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index dca626d78..4e9fa6fa6 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -13,7 +13,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -32,7 +32,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -51,7 +51,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -59,14 +59,17 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 + assert response_body == {"message" : "Task 1 not found"} + - raise Exception("Complete test with assertion about response body") + + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -93,7 +96,7 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -119,7 +122,7 @@ def test_update_task(client, one_task): assert task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -130,14 +133,16 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 + assert response_body == { "message": "Task 1 not found"} + - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -152,7 +157,7 @@ def test_delete_task(client, one_task): assert Task.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -160,8 +165,9 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 + assert response_body == {"message" : "Task 1 not found"} - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** @@ -169,7 +175,7 @@ def test_delete_task_not_found(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -186,7 +192,7 @@ def test_create_task_must_contain_title(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..c9a76e6b1 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index 32d379822..00529615b 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -5,7 +5,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -42,7 +42,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -61,8 +61,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): } assert Task.query.get(1).completed_at == None - -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -99,7 +98,7 @@ def test_mark_complete_on_completed_task(client, completed_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -119,7 +118,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -127,14 +126,15 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 + assert response_body == {"message" : "Task 1 not found"} - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -142,8 +142,9 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 + assert response_body == {"message" : "Task 1 not found"} - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index aee7c52a1..332550211 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +12,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -28,8 +28,7 @@ def test_get_goals_one_saved_goal(client, one_goal): } ] - -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +45,24 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +#@pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") + #raise Exception("Complete test") # Assert # ---- Complete Test ---- # assertion 1 goes here # assertion 2 goes here # ---- Complete Test ---- + assert response.status_code == 404 + assert response_body == {"message" : "Goal 1 not found"} + - -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,11 +81,16 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +#@pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") + #raise Exception("Complete test") # Act # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + + }) + response_body = response.get_json() # Assert # ---- Complete Assertions Here ---- @@ -92,13 +98,27 @@ def test_update_goal(client, one_goal): # assertion 2 goes here # assertion 3 goes here # ---- Complete Assertions Here ---- + assert response.status_code == 200 + assert "goal" in response_body + assert response_body == { + "goal": { + "id": 1, + "title": "Updated Goal Title" + } + } - -@pytest.mark.skip(reason="test to be completed by student") + +#@pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") + #raise Exception("Complete test") # Act # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + + }) + response_body = response.get_json() + # Assert # ---- Complete Assertions Here ---- @@ -106,8 +126,10 @@ def test_update_goal_not_found(client): # assertion 2 goes here # ---- Complete Assertions Here ---- - -@pytest.mark.skip(reason="No way to test this feature yet") + assert response.status_code == 404 + assert response_body == {"message" : "Goal 1 not found"} + +#@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -123,19 +145,22 @@ def test_delete_goal(client, one_goal): # Check that the goal was deleted response = client.get("/goals/1") assert response.status_code == 404 + response_body == {"details": 'Goal 1 "Build a habit of going outside daily" successfully deleted'} - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="test to be completed by student") +#@pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") + #raise Exception("Complete test") # Act # ---- Complete Act Here ---- + response = client.delete("/goals/1") + response_body = response.get_json() # Assert # ---- Complete Assertions Here ---- @@ -143,8 +168,10 @@ def test_delete_goal_not_found(client): # assertion 2 goes here # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert response_body == {"message" : "Goal 1 not found"} -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 8afa4325e..d3ba7de11 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -23,7 +23,7 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(Goal.query.get(1).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -42,7 +42,7 @@ def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_on assert len(Goal.query.get(1).tasks) == 2 -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -50,14 +50,15 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 + assert response_body == {"message" : "Goal 1 not found"} - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -74,7 +75,7 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -99,7 +100,7 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json()