diff --git a/app/__init__.py b/app/__init__.py index 3c581ceeb..bd2c8c6ef 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -1,5 +1,7 @@ from flask import Flask from .db import db, migrate +from .routes.task_routes import tasks_bp +from .routes.goal_routes import goals_bp from .models import task, goal import os @@ -10,13 +12,11 @@ def create_app(config=None): app.config['SQLALCHEMY_DATABASE_URI'] = os.environ.get('SQLALCHEMY_DATABASE_URI') if config: - # Merge `config` into the app's configuration - # to override the app's default settings for testing app.config.update(config) db.init_app(app) migrate.init_app(app, db) - # Register Blueprints here - + app.register_blueprint(tasks_bp, url_prefix="/tasks") + app.register_blueprint(goals_bp, url_prefix="/goals") return app diff --git a/app/models/goal.py b/app/models/goal.py index 44282656b..6efaabd9c 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -1,5 +1,27 @@ -from sqlalchemy.orm import Mapped, mapped_column +from sqlalchemy.orm import Mapped, mapped_column, relationship +from sqlalchemy import Integer, String from ..db import db class Goal(db.Model): - id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) + __tablename__ = "goals" + + id: Mapped[int] = mapped_column(Integer, primary_key=True, autoincrement=True) + title: Mapped[str] = mapped_column(String, nullable=False) + + tasks: Mapped[list["Task"]] = relationship( + "Task", + back_populates="goal", + cascade="all, delete-orphan" + ) + + def to_dict(self) -> dict: + return { + "id": self.id, + "title": self.title + } + + @classmethod + def from_dict(cls, data: dict): + return cls( + title=data["title"] + ) \ No newline at end of file diff --git a/app/models/task.py b/app/models/task.py index 5d99666a4..3237d3095 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -1,5 +1,37 @@ -from sqlalchemy.orm import Mapped, mapped_column +from sqlalchemy.orm import Mapped, mapped_column, relationship +from sqlalchemy import Integer, String, Text, DateTime, ForeignKey from ..db import db class Task(db.Model): - id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) + __tablename__ = "tasks" + + id: Mapped[int] = mapped_column(Integer, primary_key=True, autoincrement=True) + title: Mapped[str] = mapped_column(String, nullable=False) + description: Mapped[str] = mapped_column(Text, nullable=False) + completed_at: Mapped[DateTime] = mapped_column(DateTime, nullable=True) + + # ← NEW: FK to goals.id + goal_id: Mapped[int|None] = mapped_column( + ForeignKey("goals.id"), + nullable=True + ) + goal: Mapped["Goal"] = relationship( + "Goal", + back_populates="tasks" + ) + + @classmethod + def from_dict(cls, data): + return cls( + title = data["title"], + description = data["description"], + completed_at = data.get("completed_at") + ) + + def to_dict(self): + return { + "id": self.id, + "title": self.title, + "description": self.description, + "is_complete": bool(self.completed_at) + } \ No newline at end of file diff --git a/app/routes/__init__.py b/app/routes/__init__.py new file mode 100644 index 000000000..e69de29bb diff --git a/app/routes/goal_routes.py b/app/routes/goal_routes.py index 3aae38d49..be56467d5 100644 --- a/app/routes/goal_routes.py +++ b/app/routes/goal_routes.py @@ -1 +1,108 @@ -from flask import Blueprint \ No newline at end of file +from flask import Blueprint, abort, make_response, request, Response +from ..models.goal import Goal +from ..models.task import Task +from ..db import db + +goals_bp = Blueprint("goals_bp", __name__, url_prefix="/goals") + +def validate_goal(goal_id): + try: + gid = int(goal_id) + except ValueError: + invalid = {"message": f"Goal id '{goal_id}' is invalid. Must be an integer."} + abort(make_response(invalid, 400)) + + goal = db.session.get(Goal, gid) + if not goal: + not_found = {"message": f"Goal with id '{goal_id}' not found."} + abort(make_response(not_found, 404)) + + return goal + +@goals_bp.post("") +def create_goal(): + request_body = request.get_json() or {} + if "title" not in request_body: + return make_response({"details": "Invalid data"}, 400) + + new_goal = Goal.from_dict(request_body) + db.session.add(new_goal) + db.session.commit() + + return {"goal": new_goal.to_dict()}, 201 + +@goals_bp.get("") +def get_all_goals(): + query = db.select(Goal).order_by(Goal.id) + goals = db.session.scalars(query) + + goals_response = [g.to_dict() for g in goals] + return goals_response, 200 + +@goals_bp.get("/") +def get_one_goal(id): + goal = validate_goal(id) + return {"goal": goal.to_dict()}, 200 + +@goals_bp.put("/") +def update_goal(id): + goal = validate_goal(id) + request_body = request.get_json() or {} + if "title" not in request_body: + return make_response({"details": "Invalid data"}, 400) + + goal.title = request_body["title"] + db.session.commit() + + return Response(status=204, mimetype="application/json") + +@goals_bp.delete("/") +def delete_goal(id): + goal = validate_goal(id) + db.session.delete(goal) + db.session.commit() + + return Response(status=204, mimetype="application/json") +#------------------Wave 6------------------------ +@goals_bp.post("//tasks") +def assign_tasks_to_goal(goal_id): + goal = validate_goal(goal_id) + + data = request.get_json() or {} + if "task_ids" not in data or not isinstance(data["task_ids"], list): + return make_response({"details": "Invalid data"}, 400) + + tasks_to_assign = [] + for tid in data["task_ids"]: + task = db.session.get(Task, tid) + if not task: + abort(make_response( + {"message": f"Task with id '{tid}' not found."}, + 404 + )) + tasks_to_assign.append(task) + + goal.tasks = tasks_to_assign + db.session.commit() + + return {"id": goal.id, "task_ids": data["task_ids"]}, 200 + +@goals_bp.get("//tasks") +def get_tasks_for_goal(goal_id): + goal = validate_goal(goal_id) + + tasks_list = [] + for t in goal.tasks: + tasks_list.append({ + "id": t.id, + "goal_id": t.goal_id, + "title": t.title, + "description": t.description, + "is_complete": bool(t.completed_at) + }) + + return { + "id": goal.id, + "title": goal.title, + "tasks": tasks_list + }, 200 \ No newline at end of file diff --git a/app/routes/task_routes.py b/app/routes/task_routes.py index 3aae38d49..614a1eabd 100644 --- a/app/routes/task_routes.py +++ b/app/routes/task_routes.py @@ -1 +1,132 @@ -from flask import Blueprint \ No newline at end of file +import os +from flask import Blueprint, abort, make_response, request, Response +from app.models.task import Task +from datetime import datetime, timezone +from ..db import db +import requests + +tasks_bp = Blueprint("tasks_bp", __name__, url_prefix="/tasks") + +def validate_task(task_id): + + try: + tid = int(task_id) + except ValueError: + abort(make_response( + {"message": f"Task id '{task_id}' is invalid. Must be an integer."}, + 400 + )) + + task = db.session.get(Task, tid) + if not task: + not_found = {"message": f"Task with id '{task_id}' not found."} + abort(make_response(not_found, 404)) + + return task + +@tasks_bp.post("") +def create_task(): + request_body = request.get_json() or {} + if "title" not in request_body or "description" not in request_body: + return make_response({"details": "Invalid data"}, 400) + + new_task = Task.from_dict(request_body) + db.session.add(new_task) + db.session.commit() + + return {"task": new_task.to_dict()}, 201 + +@tasks_bp.get("") +def get_all_tasks(): + + query = db.select(Task) + + sort_param = request.args.get("sort") #Checks the URL for ?sort=asc or ?sort=desc + if sort_param == "asc": + query = query.order_by(Task.title) + elif sort_param == "desc": + query = query.order_by(Task.title.desc()) + else: + query = query.order_by(Task.id) + + tasks = db.session.scalars(query) #Executes the query + + tasks_response = [] + for task in tasks: + tasks_response.append({ + "id": task.id, + "title": task.title, + "description": task.description, + "is_complete": bool(task.completed_at) + }) + + return tasks_response, 200 + +@tasks_bp.patch("//mark_complete") +def mark_complete(id): + task = validate_task(id) + + task.completed_at = datetime.now(timezone.utc) + db.session.commit() + token = os.environ.get('SLACK_BOT_TOKEN', "") + + url = "https://slack.com/api/chat.postMessage" + headers = { + "Authorization": "Bearer " + token, + "Content-Type": "application/json; charset=utf-8" + } + payload = { + "channel": "test-slack-api", + "text": "Someone just completed the task: " + task.title + } + + requests.post(url, headers=headers, json=payload) + + return Response(status=204, mimetype="application/json") + +@tasks_bp.patch("//mark_incomplete") +def mark_incomplete(id): + task = validate_task(id) + + # clear completed_at + task.completed_at = None + db.session.commit() + + return Response(status=204, mimetype="application/json") + +@tasks_bp.get("/") +def get_one_task(id): + task = validate_task(id) + + task_data = { + "id": task.id, + "title": task.title, + "description": task.description, + "is_complete": bool(task.completed_at) + } + + if task.goal_id is not None: + task_data["goal_id"] = task.goal_id + + return {"task": task_data}, 200 + +@tasks_bp.put("/") +def update_task(id): + task = validate_task(id) + request_body = request.get_json() or {} + if "title" not in request_body or "description" not in request_body: + return make_response({"details": "Invalid data"}, 400) + + task.title = request_body["title"] + task.description = request_body["description"] + + db.session.commit() + + return Response(status=204, mimetype="application/json") + +@tasks_bp.delete("/") +def delete_task(id): + task = validate_task(id) + db.session.delete(task) + db.session.commit() + return Response(status=204, mimetype="application/json") \ No newline at end of file diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..0e0484415 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Single-database configuration for Flask. diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..ec9d45c26 --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,50 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic,flask_migrate + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[logger_flask_migrate] +level = INFO +handlers = +qualname = flask_migrate + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..4c9709271 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,113 @@ +import logging +from logging.config import fileConfig + +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + + +def get_engine(): + try: + # this works with Flask-SQLAlchemy<3 and Alchemical + return current_app.extensions['migrate'].db.get_engine() + except (TypeError, AttributeError): + # this works with Flask-SQLAlchemy>=3 + return current_app.extensions['migrate'].db.engine + + +def get_engine_url(): + try: + return get_engine().url.render_as_string(hide_password=False).replace( + '%', '%%') + except AttributeError: + return str(get_engine().url).replace('%', '%%') + + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option('sqlalchemy.url', get_engine_url()) +target_db = current_app.extensions['migrate'].db + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def get_metadata(): + if hasattr(target_db, 'metadatas'): + return target_db.metadatas[None] + return target_db.metadata + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=get_metadata(), literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + conf_args = current_app.extensions['migrate'].configure_args + if conf_args.get("process_revision_directives") is None: + conf_args["process_revision_directives"] = process_revision_directives + + connectable = get_engine() + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=get_metadata(), + **conf_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/0705f890e970_.py b/migrations/versions/0705f890e970_.py new file mode 100644 index 000000000..df37ceb47 --- /dev/null +++ b/migrations/versions/0705f890e970_.py @@ -0,0 +1,39 @@ +"""empty message + +Revision ID: 0705f890e970 +Revises: +Create Date: 2025-05-01 14:20:30.371857 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '0705f890e970' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.PrimaryKeyConstraint('id') + ) + op.create_table('tasks', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=False), + sa.Column('description', sa.String(), nullable=False), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.PrimaryKeyConstraint('id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('tasks') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/migrations/versions/506462e10b18_create_goals_table.py b/migrations/versions/506462e10b18_create_goals_table.py new file mode 100644 index 000000000..163565756 --- /dev/null +++ b/migrations/versions/506462e10b18_create_goals_table.py @@ -0,0 +1,37 @@ +"""create goals table + +Revision ID: 506462e10b18 +Revises: 0705f890e970 +Create Date: 2025-05-08 10:21:14.325196 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '506462e10b18' +down_revision = '0705f890e970' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goals', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=False), + sa.PrimaryKeyConstraint('id') + ) + op.drop_table('goal') + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('id', sa.INTEGER(), autoincrement=True, nullable=False), + sa.PrimaryKeyConstraint('id', name='goal_pkey') + ) + op.drop_table('goals') + # ### end Alembic commands ### diff --git a/migrations/versions/e7903a5a2e2f_add_goal_task_one_to_many.py b/migrations/versions/e7903a5a2e2f_add_goal_task_one_to_many.py new file mode 100644 index 000000000..7b44a61f8 --- /dev/null +++ b/migrations/versions/e7903a5a2e2f_add_goal_task_one_to_many.py @@ -0,0 +1,42 @@ +"""Add Goal⇆Task one-to-many + +Revision ID: e7903a5a2e2f +Revises: 506462e10b18 +Create Date: 2025-05-08 22:08:13.600385 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'e7903a5a2e2f' +down_revision = '506462e10b18' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('tasks', schema=None) as batch_op: + batch_op.add_column(sa.Column('goal_id', sa.Integer(), nullable=True)) + batch_op.alter_column('description', + existing_type=sa.VARCHAR(), + type_=sa.Text(), + existing_nullable=False) + batch_op.create_foreign_key(None, 'goals', ['goal_id'], ['id']) + + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('tasks', schema=None) as batch_op: + batch_op.drop_constraint(None, type_='foreignkey') + batch_op.alter_column('description', + existing_type=sa.Text(), + type_=sa.VARCHAR(), + existing_nullable=False) + batch_op.drop_column('goal_id') + + # ### end Alembic commands ### diff --git a/requirements.txt b/requirements.txt index b989cae17..c8b7ee20f 100644 --- a/requirements.txt +++ b/requirements.txt @@ -25,4 +25,4 @@ SQLAlchemy==2.0.38 toml==0.10.2 typing_extensions==4.12.2 urllib3==2.3.0 -Werkzeug==3.1.3 +Werkzeug==3.1.3 \ No newline at end of file diff --git a/tests/conftest.py b/tests/conftest.py index a01499583..cc0d3e9f8 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -12,7 +12,7 @@ @pytest.fixture def app(): - # create the app with a test configuration + test_config = { "TESTING": True, "SQLALCHEMY_DATABASE_URI": os.environ.get('SQLALCHEMY_TEST_DATABASE_URI') @@ -27,7 +27,7 @@ def expire_session(sender, response, **extra): db.create_all() yield app - # close and remove the temporary database + with app.app_context(): db.drop_all() @@ -36,10 +36,6 @@ def expire_session(sender, response, **extra): def client(app): return app.test_client() - -# This fixture gets called in every test that -# references "one_task" -# This fixture creates a task and saves it in the database @pytest.fixture def one_task(app): new_task = Task(title="Go on my daily walk 🏞", @@ -48,11 +44,6 @@ def one_task(app): db.session.add(new_task) db.session.commit() - -# This fixture gets called in every test that -# references "three_tasks" -# This fixture creates three tasks and saves -# them in the database @pytest.fixture def three_tasks(app): db.session.add_all([ @@ -68,11 +59,6 @@ def three_tasks(app): ]) db.session.commit() - -# This fixture gets called in every test that -# references "completed_task" -# This fixture creates a task with a -# valid completed_at date @pytest.fixture def completed_task(app): new_task = Task(title="Go on my daily walk 🏞", @@ -82,21 +68,12 @@ def completed_task(app): db.session.commit() -# This fixture gets called in every test that -# references "one_goal" -# This fixture creates a goal and saves it in the database @pytest.fixture def one_goal(app): new_goal = Goal(title="Build a habit of going outside daily") db.session.add(new_goal) db.session.commit() - -# This fixture gets called in every test that -# references "one_task_belongs_to_one_goal" -# This fixture creates a task and a goal -# It associates the goal and task, so that the -# goal has this task, and the task belongs to one goal @pytest.fixture def one_task_belongs_to_one_goal(app, one_goal, one_task): task_query = db.select(Task).where(Task.id == 1) diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index 55475db79..042f3fe91 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -3,7 +3,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -14,7 +14,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -33,7 +33,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -52,7 +52,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -60,14 +60,16 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 + assert "message" in response_body + assert response_body == {"message": "Task with id '1' not found."} - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** - # ***************************************************************** + # ************************************Done************************* -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -97,7 +99,7 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -117,7 +119,7 @@ def test_update_task(client, one_task): -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -128,14 +130,16 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 + assert "message" in response_body + assert response_body == {"message": "Task with id '1' not found."} - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** - # ***************************************************************** + # ***Done********************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -146,7 +150,7 @@ def test_delete_task(client, one_task): query = db.select(Task).where(Task.id == 1) assert db.session.scalar(query) == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -154,16 +158,18 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 + assert "message" in response_body + assert response_body == {"message": "Task with id '1' not found."} - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** - # ***************************************************************** + # **Done*********************************************************** assert db.session.scalars(db.select(Task)).all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -180,7 +186,7 @@ def test_create_task_must_contain_title(client): assert db.session.scalars(db.select(Task)).all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..c9a76e6b1 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index d7d441695..9948fdea9 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -6,7 +6,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -34,7 +34,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert db.session.scalar(query).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -46,7 +46,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert db.session.scalar(query).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -74,7 +74,7 @@ def test_mark_complete_on_completed_task(client, completed_task): query = db.select(Task).where(Task.id == 1) assert db.session.scalar(query).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -86,7 +86,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert db.session.scalar(query).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -94,14 +94,17 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 + assert response_body == { + "message": "Task with id '1' not found." + } - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** - # ***************************************************************** + # ******Done******************************************************* -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -109,8 +112,11 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 + assert response_body == { + "message": "Task with id '1' not found." + } - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** - # ***************************************************************** + # ******Done******************************************************* diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index 222d10cf0..65bc684a0 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +12,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -29,7 +29,7 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +46,24 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +#@pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): - pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") + #raise Exception("Complete test") # Assert # ---- Complete Test ---- # assertion 1 goes here # assertion 2 goes here # ---- Complete Test ---- + assert response.status_code == 404 + assert "message" in response_body + assert response_body["message"] == "Goal with id '1' not found." -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,34 +82,39 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +#@pytest.mark.skip(reason="test to be completed by student") +#finish def test_update_goal(client, one_goal): - raise Exception("Complete test") - # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={"title": "New Title"}) # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 204 + + # Confirm the update persisted + response = client.get("/goals/1") + response_body = response.get_json() + assert response_body == { + "goal": { + "id": 1, + "title": "New Title" + } + } -@pytest.mark.skip(reason="test to be completed by student") +#@pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") + #Finish # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={"title": "Doesn't Matter"}) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert "message" in response_body + assert response_body["message"] == "Goal with id '1' not found." -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -120,29 +127,26 @@ def test_delete_goal(client, one_goal): assert response.status_code == 404 response_body = response.get_json() - assert "message" in response_body + assert response_body == {"message": "Goal with id '1' not found."} - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** - # ***************************************************************** + # ********Done***************************************************** -@pytest.mark.skip(reason="test to be completed by student") +#@pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") - # Act - # ---- Complete Act Here ---- + response = client.delete("/goals/1") + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- - + assert response.status_code == 404 + assert "message" in response_body + assert response_body["message"] == "Goal with id '1' not found." -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 0317f835a..7d6a835fc 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -3,7 +3,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -25,7 +25,7 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(db.session.scalar(query).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -45,7 +45,7 @@ def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_on assert len(db.session.scalar(query).tasks) == 2 -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -53,14 +53,15 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 + assert response_body == {"message": "Goal with id '1' not found."} - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -77,7 +78,7 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -102,7 +103,7 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json()