forked from celo-org/snark-setup
-
Notifications
You must be signed in to change notification settings - Fork 96
Open
Labels
refactorChanges which affect the maintainability of the codeChanges which affect the maintainability of the code
Description
The new Round::reset() introduced in #288 returns storage actions rather than directly mutating the storage. This easier to test and reason about. There are other methods in Round which could be refactored to work the same way, and have more unit tests written for them:
new()remove_contributor_unsafe(introduced during Round restart #288 to combineremoved_locks_unsafeandremove_chunk_contributions_unsafe)remove_locks_unsaferemove_chunk_contributions_unsafetry_lock_chunk
The following methods depend on an immutable reference to Storage, perhaps they could be decoupled:
current_contribution_locatornext_contribution_locatornext_contribution_file_signature_locator
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
refactorChanges which affect the maintainability of the codeChanges which affect the maintainability of the code