DPL Analysis: fix for slice index builder resetting its caches in a wrong order

aalkin · ktf · commit 34d96168b97b · 2026-01-15T14:45:44.000+01:00
diff --git a/Framework/Core/src/IndexBuilderHelpers.cxx b/Framework/Core/src/IndexBuilderHelpers.cxx
@@ -161,14 +161,14 @@ SliceBuilder::SliceBuilder(std::shared_ptr<arrow::ChunkedArray> source, arrow::M
 
 void SliceBuilder::reset(std::shared_ptr<arrow::ChunkedArray> source)
 {
+  mValues = nullptr;
+  mCounts = nullptr;
+  mListBuilder->Reset();
+  mValuePos = 0;
   static_cast<ChunkedArrayIterator*>(this)->reset(source);
   if (!preSlice().ok()) {
     throw framework::runtime_error("Cannot pre-slice the source for slice-index building");
   }
-  mListBuilder->Reset();
-  mValues = nullptr;
-  mCounts = nullptr;
-  mValuePos = 0;
 }
 
 bool SliceBuilder::find(int idx)

Original file line number	Diff line number	Diff line change
`@@ -161,14 +161,14 @@ SliceBuilder::SliceBuilder(std::shared_ptr<arrow::ChunkedArray> source, arrow::M`
`161`	`161`
`162`	`162`	`void SliceBuilder::reset(std::shared_ptr<arrow::ChunkedArray> source)`
`163`	`163`	`{`
	`164`	`+ mValues = nullptr;`
	`165`	`+ mCounts = nullptr;`
	`166`	`+ mListBuilder->Reset();`
	`167`	`+ mValuePos = 0;`
`164`	`168`	`static_cast<ChunkedArrayIterator*>(this)->reset(source);`
`165`	`169`	`if (!preSlice().ok()) {`
`166`	`170`	`throw framework::runtime_error("Cannot pre-slice the source for slice-index building");`
`167`	`171`	`}`
`168`		`- mListBuilder->Reset();`
`169`		`- mValues = nullptr;`
`170`		`- mCounts = nullptr;`
`171`		`- mValuePos = 0;`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`bool SliceBuilder::find(int idx)`