Skip to content

Commit ea7052c

Browse files
committed
DPL: keep code checker happy
The code checker complains about the unique_ptr going out of scope. However this is a false positive because such unique_ptr has a custom deletion policy to mimick the behavior of an observer_ptr. In order to keep the code checker happy, we use release, so that the bare pointer is returned without any complain. Given the custom deleter, the semantic is actually the same.
1 parent b5dfe50 commit ea7052c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Framework/Core/include/Framework/AnalysisManagers.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ bool newDataframeCondition(InputRecord&, C&)
170170
template <is_condition C>
171171
bool newDataframeCondition(InputRecord& record, C& condition)
172172
{
173-
condition.instance = (typename C::type*)record.get<typename C::type*>(condition.path).get();
173+
condition.instance = (typename C::type*)record.get<typename C::type*>(condition.path).release();
174174
return true;
175175
}
176176

0 commit comments

Comments
 (0)