ITS: Vertexer remove unused code#14508
Conversation
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
I would mot remove the files for the smoother. You can remove includes if you want, but please leave it there. |
|
Please correct if I am wrong but I think you referring to #14504? |
definitely |
mconcas
left a comment
There was a problem hiding this comment.
Just for your reference: the computeVerticesInRofs (and similia) are the corresponding CPU version of what was done on the GPU version of the vertexer at the time we had the possibility to fragment the single TF for processing it on the device.
This was due to the fact that on GPU we were re-using pre-scaled memory allocations, that more often than not were over-sized, then making it impossible to process the whole TF in some cases.
This CPU code is now not useful, as the vertexer did not get updated with the refactorisation of the gpu part, so it is unused.
The current approach we have with the memory is much simpler and gauged (we would pseudo-allocate just the memory we need, as you know) not to require this strategy anymore for Run 3, even when the GPU vertexer will be restored.
I am fine to remove these.
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
No description provided.