Skip to content

TOF: param utilities are separated in a dedicated library for O2Physics usage#14730

Merged
njacazio merged 6 commits intodevfrom
revert-14516-nj-paramtof
Oct 17, 2025
Merged

TOF: param utilities are separated in a dedicated library for O2Physics usage#14730
njacazio merged 6 commits intodevfrom
revert-14516-nj-paramtof

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented Oct 10, 2025

Reverts #14516

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@njacazio njacazio marked this pull request as ready for review October 11, 2025 13:05
@njacazio njacazio requested a review from noferini as a code owner October 11, 2025 13:05
@njacazio njacazio changed the title Revert "TOF: Header only param utilities libraryless call in O2Physics" TOF: param utilities are separated in a dedicated library for O2Physics usage Oct 11, 2025
@njacazio njacazio enabled auto-merge (squash) October 11, 2025 13:06
@alibuild
Copy link
Collaborator

alibuild commented Oct 11, 2025

Error while checking build/O2/fullCI_slc9 for 1df1b85 at 2025-10-11 16:09:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14730-slc9_x86-64/0/Detectors/TOF/workflow/src/make-parameter-collection.cxx:66:3: error: 'ParamExample::~ParamExample()' marked 'override', but does not override
ninja: build stopped: subcommand failed.

Full log here.

noferini
noferini approved these changes Oct 17, 2025
View reviewed changes
Copy link
Collaborator

@noferini noferini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if I didn't understand the need of this PR, since it has no evident conflicts with TOF I approve it.

@njacazio njacazio merged commit 3fbf253 into dev Oct 17, 2025
11 of 12 checks passed
@njacazio njacazio deleted the revert-14516-nj-paramtof branch October 17, 2025 07:05
@njacazio njacazio mentioned this pull request Oct 17, 2025
Merged
@njacazio
Copy link
Collaborator Author

njacazio commented Oct 17, 2025

Thanks a lot Francesco! Now AliceO2Group/O2Physics#11872 can move on!

plariono pushed a commit to plariono/AliceO2 that referenced this pull request Oct 23, 2025
@njacazio @plariono
TOF: param utilities are separated in a dedicated library for O2Physi…
21accf3 
…cs usage (AliceO2Group#14730)

* Revert "TOF Param container: move to header only"

This reverts commit 1aa2c14.

* Add DataFormatsParamTOF library to CMakeLists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noferini noferini noferini approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@njacazio @alibuild @noferini