Skip to content

DataModel: make V0s IsStandard explicit#13937

Merged
jgrosseo merged 1 commit intodevfrom
f3sch-patch-2
Mar 12, 2025
Merged

DataModel: make V0s IsStandard explicit#13937
jgrosseo merged 1 commit intodevfrom
f3sch-patch-2

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Feb 5, 2025

This makes the check more explicit to really have a standard v0. If analysers just ask for this bit, for example they still would get tpc-only v0s. @ddobrigk

@f3sch
DataModel: make V0s IsStandard explicit
12d6425 
This makes the check more explicit to really have a standard v0.
If analysers just ask for this bit, for example they still would get tpc-only v0s. @ddobrigk
@f3sch f3sch requested a review from a team as a code owner February 5, 2025 08:57
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@ddobrigk
Copy link
Contributor

ddobrigk commented Feb 5, 2025 •
edited
Loading

This makes the check more explicit to really have a standard v0. If analysers just ask for this bit, for example they still would get tpc-only v0s. @ddobrigk

Thanks a lot @f3sch , this makes custom use of V0s much less error-prone, as isStandardV0 will then always mean v0Type==1 (up until this PR, v0Type==7 got tagged as standard and thus included TPC-only V0s. Tagging also @ercolessi @njacazio @ChiaraDeMartin95 @skundu692 @rschotte for completeness. Relevant for @fmazzasc's hypertritons and other cases where V0s are taken directly from the AO2Ds - strangeness builders are safe, as the standard strangeness tables already do this).

@alibuild
Copy link
Collaborator

alibuild commented Feb 5, 2025 •
edited
Loading

Error while checking build/O2/fullCI for 12d6425 at 2025-02-21 23:09:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile digi.log
digi.log:[20016:internal-dpl-ccdb-backend]: [22:09:26][ERROR] Exception while running: Fatal error. Rethrowing.
digi.log-[20016:internal-dpl-ccdb-backend]: [22:09:26][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
[20016:internal-dpl-ccdb-backend]: [22:09:23][ERROR] Failed to open file alien:///alice/data/CCDB/TPC/Calib/LaserTracks/14/60057/dd26d771-0929-11ed-8000-2a010e0a0b16?filetype=raw
[20016:internal-dpl-ccdb-backend]: [22:09:23][FATAL] Unable to find object TPC/Calib/LaserTracks/1550600800000
[20016:internal-dpl-ccdb-backend]: [22:09:26][ERROR] Exception while running: Fatal error. Rethrowing.
[20016:internal-dpl-ccdb-backend]: [22:09:26][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 20016 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device internal-dpl-ccdb-backend: pid 20016 (exit 128)
[INFO]    - First error: [22:09:23][FATAL] Unable to find object TPC/Calib/LaserTracks/1550600800000
[ERROR] SEVERE: Device internal-dpl-ccdb-backend (20016) had at least one message above severity 5: Unable to find object TPC/Calib/LaserTracks/1550600800000


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/b5c180b096b242d3733dd8b82ae570112fe4cf95/slc8_x86-64/o2checkcode/1.0-local194/etc/modulefiles
[0 more errors; see full log]

Full log here.

@f3sch
Copy link
Collaborator Author

f3sch commented Feb 12, 2025

@jgrosseo if you agree, please merge.

@alibuild
Copy link
Collaborator

alibuild commented Feb 21, 2025

Error while checking build/O2/fullCI_slc9 for 12d6425 at 2025-02-21 11:46:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile digi.log
digi.log:[21578:internal-dpl-ccdb-backend]: [11:46:27][ERROR] Exception while running: Fatal error. Rethrowing.
digi.log-[21578:internal-dpl-ccdb-backend]: [11:46:27][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
[21578:internal-dpl-ccdb-backend]: [11:46:24][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
[21578:internal-dpl-ccdb-backend]: [11:46:24][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/CTP/Calib/OrbitReset for 1550600800000 (agent_id: alimetal00.cern.ch-1740134776-bxCH1J) with http code: 0
[21578:internal-dpl-ccdb-backend]: [11:46:24][ERROR] File CTP/Calib/OrbitReset could not be retrieved. No more hosts to try.
[21578:internal-dpl-ccdb-backend]: [11:46:24][FATAL] Unable to find object CTP/Calib/OrbitReset/1550600800000
[21578:internal-dpl-ccdb-backend]: [11:46:27][ERROR] Exception while running: Fatal error. Rethrowing.
[21578:internal-dpl-ccdb-backend]: [11:46:27][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 21578 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/d28768a1861b83664b51b25f2e7391e1a39c7278/slc9_x86-64/o2checkcode/1.0-local112/etc/modulefiles
++ cat
--

Full log here.

@f3sch
Copy link
Collaborator Author

f3sch commented Mar 12, 2025

pinging @jgrosseo.

@jgrosseo jgrosseo merged commit fe6cd7c into dev Mar 12, 2025
16 checks passed
@jgrosseo jgrosseo deleted the f3sch-patch-2 branch March 12, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgrosseo jgrosseo jgrosseo approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@f3sch @ddobrigk @alibuild @jgrosseo