[core] Report error of failed environment through stream

Author: miltalex

core/environment/manager.go

@@ -464,14 +464,18 @@ func (envs *Manager) CreateAutoEnvironment(workflowPath string, userVars map[str
 		true	))
 	if err != nil {
 		envState := env.CurrentState()
+		env.sendEnvironmentEvent(&event.EnvironmentEvent{EnvironmentID: env.Id().String(), Error: err})
 		log.WithField("state", envState).
 			WithField("environment", env.Id().String()).
 			WithError(err).
 			Warn("environment deployment and configuration failed, cleanup in progress")
 
 		envTasks := env.Workflow().GetTasks()
 		// TeardownEnvironment manages the envs.mu internally
-		_ = envs.TeardownEnvironment(env.Id(), true/*force*/)
+		err = envs.TeardownEnvironment(env.Id(), true/*force*/)
+		if err != nil {
+			env.sendEnvironmentEvent(&event.EnvironmentEvent{EnvironmentID: env.Id().String(), Error: err})
+		}
 
 		killedTasks, _, rlsErr := envs.taskman.KillTasks(envTasks.GetTaskIds())
 		if rlsErr != nil {
@@ -482,7 +486,6 @@ func (envs *Manager) CreateAutoEnvironment(workflowPath string, userVars map[str
 			"lastEnvState": envState,
 		}).
 		Warn("environment deployment failed, tasks were cleaned up")
-		env.sendEnvironmentEvent(&event.EnvironmentEvent{EnvironmentID: env.Id().String(), Error: err})
 		return
 	}