Skip to content

Commit 581fb86

Browse files
committed
[core][executor] Support pushing the control port via env var
OCTRL-81 #close
1 parent b5be0eb commit 581fb86

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

core/scheduler.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -481,8 +481,10 @@ func resourceOffers(state *internalState, fidStore store.Singleton) events.Handl
481481
remainingResources.Subtract(builder.Resource)
482482

483483
// Append control port to arguments
484+
// For the control port parameter and/or environment variable, see occ/OccGlobals.h
484485
cmd.Arguments = append(cmd.Arguments, "--control-port", strconv.FormatUint(controlPort, 10))
485486
cmd.ControlPort = controlPort
487+
cmd.Env = append(cmd.Env, fmt.Sprintf("%s=%d", "OCC_CONTROL_PORT", controlPort))
486488

487489
runCommand := *cmd
488490

executor/executor.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ func launch(state *internalState, task mesos.TaskInfo) {
432432
} else {
433433
taskCmd = exec.Command(*commandInfo.Value, commandInfo.Arguments...)
434434
}
435-
taskCmd.Env = append(os.Environ())
435+
taskCmd.Env = append(os.Environ(), commandInfo.Env...)
436436

437437
var errStdout, errStderr error
438438
stdoutIn, _ := taskCmd.StdoutPipe()

0 commit comments

Comments
 (0)