[OCTRL-683][executor] ERROR should not be the last state

knopers8 · teo · commit a76cc33b9ebc · 2023-02-22T16:50:59.000+01:00
Since we aim to transition from ERROR to DONE, we cannot stop the loop when we reach ERROR. KILL_TRANSITION_TIMEOUT should protect us from being stuck in ERROR forever (in case we fail to get to DONE).
diff --git a/executor/executable/controllabletask.go b/executor/executable/controllabletask.go
@@ -683,8 +683,7 @@ func (t *ControllableTask) Kill() error {
 			return
 		}
 
-		for reachedState != "DONE" &&
-			reachedState != "ERROR" {
+		for reachedState != "DONE" {
 			cmd := nextTransition(reachedState)
 			log.WithField("partition", t.knownEnvironmentId.String()).
 				WithField("detector", t.knownDetector).

Original file line number	Diff line number	Diff line change
`@@ -683,8 +683,7 @@ func (t *ControllableTask) Kill() error {`
`683`	`683`	`return`
`684`	`684`	`}`
`685`	`685`
`686`		`- for reachedState != "DONE" &&`
`687`		`- reachedState != "ERROR" {`
	`686`	`+ for reachedState != "DONE" {`
`688`	`687`	`cmd := nextTransition(reachedState)`
`689`	`688`	`log.WithField("partition", t.knownEnvironmentId.String()).`
`690`	`689`	`WithField("detector", t.knownDetector).`