Skip to content

Commit b6478c8

Browse files
committed
[core] Improve error condition reporting
1 parent 80488a5 commit b6478c8

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

core/environment/environment.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,16 +331,19 @@ func (env *Environment) handleHooks(workflow workflow.Role, trigger string) (err
331331

332332
// If the hook call or task is critical: true
333333
if hook.GetTraits().Critical {
334-
log.Errorf("critical hook failed: %s", err)
334+
log.WithField("partition", env.Id().String()).
335+
Logf(logrus.FatalLevel, "critical hook failed: %s", err) // Must use Logf(FatalLevel) instead of
336+
// Fatalf because the latter calls Exit
335337
criticalFailures = append(criticalFailures, err)
336338
} else {
337339
log.WithField("level", infologger.IL_Devel).
340+
WithField("partition", env.Id().String()).
338341
Debugf("non-critical hook failed: %s", err)
339342
}
340343
}
341344

342345
if len(criticalFailures) != 0 {
343-
return fmt.Errorf("one or more critical hooks failed")
346+
return fmt.Errorf("%d critical hooks failed at trigger %s", len(criticalFailures), trigger)
344347
}
345348
return nil
346349
}

0 commit comments

Comments
 (0)