Skip to content

Commit fdad4c2

Browse files
author
Michal Tichák
committed
[core] refactored WriteEventWithTimestamp
1 parent 5f84cef commit fdad4c2

File tree

1 file changed

+15
-42
lines changed

1 file changed

+15
-42
lines changed

common/event/writer.go

Lines changed: 15 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -99,53 +99,32 @@ func (w *KafkaWriter) WriteEventWithTimestamp(e interface{}, timestamp time.Time
9999

100100
var (
101101
err error
102-
wrappedEvent *pb.Event
103-
key []byte = nil
102+
wrappedEvent *pb.Event = &pb.Event{
103+
Timestamp: timestamp.UnixMilli(),
104+
TimestampNano: timestamp.UnixNano(),
105+
}
106+
key []byte = nil
104107
)
105108

106109
switch e := e.(type) {
107110
case *pb.Ev_MetaEvent_CoreStart:
108-
wrappedEvent = &pb.Event{
109-
Timestamp: timestamp.UnixMilli(),
110-
TimestampNano: timestamp.UnixNano(),
111-
Payload: &pb.Event_CoreStartEvent{CoreStartEvent: e},
112-
}
111+
wrappedEvent.Payload = &pb.Event_CoreStartEvent{CoreStartEvent: e}
113112
case *pb.Ev_MetaEvent_MesosHeartbeat:
114-
wrappedEvent = &pb.Event{
115-
Timestamp: timestamp.UnixMilli(),
116-
TimestampNano: timestamp.UnixNano(),
117-
Payload: &pb.Event_MesosHeartbeatEvent{MesosHeartbeatEvent: e},
118-
}
113+
wrappedEvent.Payload = &pb.Event_MesosHeartbeatEvent{MesosHeartbeatEvent: e}
119114
case *pb.Ev_MetaEvent_FrameworkEvent:
120-
wrappedEvent = &pb.Event{
121-
Timestamp: timestamp.UnixMilli(),
122-
TimestampNano: timestamp.UnixNano(),
123-
Payload: &pb.Event_FrameworkEvent{FrameworkEvent: e},
124-
}
115+
wrappedEvent.Payload = &pb.Event_FrameworkEvent{FrameworkEvent: e}
125116
case *pb.Ev_TaskEvent:
126117
key = []byte(e.Taskid)
127118
if len(key) == 0 {
128119
key = nil
129120
}
130-
wrappedEvent = &pb.Event{
131-
Timestamp: timestamp.UnixMilli(),
132-
TimestampNano: timestamp.UnixNano(),
133-
Payload: &pb.Event_TaskEvent{TaskEvent: e},
134-
}
121+
wrappedEvent.Payload = &pb.Event_TaskEvent{TaskEvent: e}
135122
case *pb.Ev_RoleEvent:
136123
key = extractAndConvertEnvID(e)
137-
wrappedEvent = &pb.Event{
138-
Timestamp: timestamp.UnixMilli(),
139-
TimestampNano: timestamp.UnixNano(),
140-
Payload: &pb.Event_RoleEvent{RoleEvent: e},
141-
}
124+
wrappedEvent.Payload = &pb.Event_RoleEvent{RoleEvent: e}
142125
case *pb.Ev_EnvironmentEvent:
143126
key = extractAndConvertEnvID(e)
144-
wrappedEvent = &pb.Event{
145-
Timestamp: timestamp.UnixMilli(),
146-
TimestampNano: timestamp.UnixNano(),
147-
Payload: &pb.Event_EnvironmentEvent{EnvironmentEvent: e},
148-
}
127+
wrappedEvent.Payload = &pb.Event_EnvironmentEvent{EnvironmentEvent: e}
149128
case *pb.Ev_CallEvent:
150129
key = extractAndConvertEnvID(e)
151130
wrappedEvent = &pb.Event{
@@ -155,18 +134,12 @@ func (w *KafkaWriter) WriteEventWithTimestamp(e interface{}, timestamp time.Time
155134
}
156135
case *pb.Ev_IntegratedServiceEvent:
157136
key = extractAndConvertEnvID(e)
158-
wrappedEvent = &pb.Event{
159-
Timestamp: timestamp.UnixMilli(),
160-
TimestampNano: timestamp.UnixNano(),
161-
Payload: &pb.Event_IntegratedServiceEvent{IntegratedServiceEvent: e},
162-
}
137+
wrappedEvent.Payload = &pb.Event_IntegratedServiceEvent{IntegratedServiceEvent: e}
163138
case *pb.Ev_RunEvent:
164139
key = extractAndConvertEnvID(e)
165-
wrappedEvent = &pb.Event{
166-
Timestamp: timestamp.UnixMilli(),
167-
TimestampNano: timestamp.UnixNano(),
168-
Payload: &pb.Event_RunEvent{RunEvent: e},
169-
}
140+
wrappedEvent.Payload = &pb.Event_RunEvent{RunEvent: e}
141+
default:
142+
wrappedEvent = nil
170143
}
171144

172145
if wrappedEvent == nil {

0 commit comments

Comments
 (0)