Fix initialisations

vkucera · vkucera · commit 5bae3af4c292 · 2026-01-15T12:14:05.000+01:00
diff --git a/PWGHF/D2H/TableProducer/candidateCreatorB0Reduced.cxx b/PWGHF/D2H/TableProducer/candidateCreatorB0Reduced.cxx
@@ -210,7 +210,7 @@ struct HfCandidateCreatorB0Reduced {
         trackParCovPi.propagateToDCA(primaryVertex, bz, &dcaBachPion);
 
         // get uncertainty of the decay length
-        float phi, theta;
+        float phi{}, theta{};
         // getPointDirection modifies phi and theta
         getPointDirection(std::array{collision.posX(), collision.posY(), collision.posZ()}, secondaryVertexB0, phi, theta);
         auto errorDecayLength = std::sqrt(getRotatedCovMatrixXX(covMatrixPV, phi, theta) + getRotatedCovMatrixXX(covMatrixPCA, phi, theta));
@@ -314,7 +314,7 @@ struct HfCandidateCreatorB0Reduced {
         trackParCovPi.propagateToDCA(primaryVertex, bz, &dcaPion);
 
         // get uncertainty of the decay length
-        float phi, theta;
+        float phi{}, theta{};
         // getPointDirection modifies phi and theta
         getPointDirection(std::array{collision.posX(), collision.posY(), collision.posZ()}, secondaryVertexB0, phi, theta);
         auto errorDecayLength = std::sqrt(getRotatedCovMatrixXX(covMatrixPV, phi, theta) + getRotatedCovMatrixXX(covMatrixPCA, phi, theta));
diff --git a/PWGHF/D2H/TableProducer/candidateCreatorBsReduced.cxx b/PWGHF/D2H/TableProducer/candidateCreatorBsReduced.cxx
@@ -184,7 +184,7 @@ struct HfCandidateCreatorBsReduced {
         trackParCovPi.propagateToDCA(primaryVertex, bz, &dcaPion);
 
         // get uncertainty of the decay length
-        float phi, theta;
+        float phi{}, theta{};
         // getPointDirection modifies phi and theta
         getPointDirection(std::array{collision.posX(), collision.posY(), collision.posZ()}, secondaryVertexB, phi, theta);
         auto errorDecayLength = std::sqrt(getRotatedCovMatrixXX(covMatrixPV, phi, theta) + getRotatedCovMatrixXX(covMatrixPCA, phi, theta));
diff --git a/PWGHF/D2H/TableProducer/candidateCreatorCharmResoReduced.cxx b/PWGHF/D2H/TableProducer/candidateCreatorCharmResoReduced.cxx
@@ -450,7 +450,7 @@ struct HfCandidateCreatorCharmResoReduced {
           registry.fill(HIST("hMassV0DauVsPt"), invMassV0Tr, candV0Tr.pt());
         }
       } else if constexpr (DType == DMesonType::Dstar) {
-        float invMassD0;
+        float invMassD0{};
         if (candD.sign() > 0) {
           invMassD = candD.invMassDstar();
           invMassD0 = candD.invMassD0();
diff --git a/PWGHF/D2H/TableProducer/candidateCreatorLbReduced.cxx b/PWGHF/D2H/TableProducer/candidateCreatorLbReduced.cxx
@@ -204,7 +204,7 @@ struct HfCandidateCreatorLbReduced {
         trackParCovPi.propagateToDCA(primaryVertex, bz, &dcaPion);
 
         // get uncertainty of the decay length
-        float phi, theta;
+        float phi{}, theta{};
         // getPointDirection modifies phi and theta
         getPointDirection(std::array{collision.posX(), collision.posY(), collision.posZ()}, secondaryVertexLb, phi, theta);
         auto errorDecayLength = std::sqrt(getRotatedCovMatrixXX(covMatrixPV, phi, theta) + getRotatedCovMatrixXX(covMatrixPCA, phi, theta));
diff --git a/PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx b/PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx
@@ -148,7 +148,7 @@ struct HfTaskCorrelationDplusHadrons {
   Configurable<int64_t> timestampCcdb{"timestampCcdb", -1, "timestamp of the efficiency files used to query in CCDB"};
   Configurable<int64_t> ccdbNoLaterThan{"ccdbNoLaterThan", std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::system_clock::now().time_since_epoch()).count(), "latest acceptable timestamp of creation for the object"};
 
-  Service<ccdb::BasicCCDBManager> ccdb;
+  Service<ccdb::BasicCCDBManager> ccdb{};
   std::shared_ptr<TH1> mEfficiencyPrompt = nullptr;
   std::shared_ptr<TH1> mEfficiencyFD = nullptr;
   std::shared_ptr<TH1> mEfficiencyAssociated = nullptr;
diff --git a/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx b/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx
@@ -158,7 +158,7 @@ struct HfTaskCorrelationDsHadrons {
 
   SliceCache cache;
 
-  Service<ccdb::BasicCCDBManager> ccdb;
+  Service<ccdb::BasicCCDBManager> ccdb{};
 
   using DsHadronPair = soa::Filtered<soa::Join<aod::DsHadronPair, aod::DsHadronRecoInfo>>;
   using DsHadronPairFull = soa::Filtered<soa::Join<aod::DsHadronPair, aod::DsHadronRecoInfo, aod::DsHadronGenInfo>>;
diff --git a/PWGHF/HFC/Tasks/taskCorrelationLcHadrons.cxx b/PWGHF/HFC/Tasks/taskCorrelationLcHadrons.cxx
@@ -163,7 +163,7 @@ struct HfTaskCorrelationLcHadrons {
   std::shared_ptr<TH1> mEfficiencyFD = nullptr;
   std::shared_ptr<TH1> mEfficiencyAssociated = nullptr;
 
-  Service<ccdb::BasicCCDBManager> ccdb;
+  Service<ccdb::BasicCCDBManager> ccdb{};
 
   enum CandidateStep { kCandidateStepMcGenAll = 0,
                        kCandidateStepMcGenLcToPKPi,
diff --git a/PWGHF/HFC/Tasks/taskFlow.cxx b/PWGHF/HFC/Tasks/taskFlow.cxx
@@ -758,7 +758,7 @@ struct HfTaskFlow {
   {
     int const cellsInLeft[] = {0, 1, 2, 3, 8, 9, 10, 11, 16, 17, 18, 19, 24, 25, 26, 27, 32, 40, 33, 41, 34, 42, 35, 43};
     bool const isChnoInLeft = std::find(std::begin(cellsInLeft), std::end(cellsInLeft), chno) != std::end(cellsInLeft);
-    float offsetX, offsetY;
+    float offsetX{}, offsetY{};
     if (isChnoInLeft) {
       offsetX = (*offsetFV0)[0].getX();
       offsetY = (*offsetFV0)[0].getY();
@@ -797,7 +797,7 @@ struct HfTaskFlow {
   {
     int const cellsInLeft[] = {0, 1, 2, 3, 8, 9, 10, 11, 16, 17, 18, 19, 24, 25, 26, 27, 32, 40, 33, 41, 34, 42, 35, 43};
     bool const isChnoInLeft = std::find(std::begin(cellsInLeft), std::end(cellsInLeft), chno) != std::end(cellsInLeft);
-    float offsetX, offsetY, offsetZ;
+    float offsetX{}, offsetY{}, offsetZ{};
     if (isChnoInLeft) {
       offsetX = (*offsetFV0)[0].getX();
       offsetY = (*offsetFV0)[0].getY();
@@ -1109,7 +1109,7 @@ struct HfTaskFlow {
             bool bIsBelow = false;
 
             if (std::abs(dPhiStarLow) < kLimit || std::abs(dPhiStarHigh) < kLimit || dPhiStarLow * dPhiStarHigh < 0) {
-              for (double rad(configCentral.minMergingRadius); rad < configCentral.maxMergingRadius; rad += 0.01) {
+              for (double rad(configCentral.minMergingRadius); rad < configCentral.maxMergingRadius; rad += 0.01) { // FIXME: Variable 'rad' with floating point type 'double' should not be used as a loop counter.
                 double dPhiStar = getDPhiStar(track1, track2, rad, magneticField);
                 if (std::abs(dPhiStar) < kLimit) {
                   bIsBelow = true;
diff --git a/PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx b/PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx
@@ -166,7 +166,7 @@ struct HfTaskElectronWeakBoson {
   // pp
   // using TrackEle = o2::soa::Filtered<o2::soa::Join<o2::aod::Tracks, o2::aod::FullTracks, o2::aod::TracksDCA, o2::aod::TrackSelection, o2::aod::pidTPCEl, o2::aod::pidTOFEl>>;
 
-  Filter eventFilter = (applySel8 ? (o2::aod::evsel::sel8 == true) : (o2::aod::evsel::sel8 == o2::aod::evsel::sel8));
+  Filter eventFilter = (applySel8 ? (o2::aod::evsel::sel8 == true) : (o2::aod::evsel::sel8 == o2::aod::evsel::sel8)); // FIXME: both sides of overloaded operator are equivalent
   Filter posZFilter = (nabs(o2::aod::collision::posZ) < vtxZ);
 
   Filter etafilter = (aod::track::eta < etaTrMax) && (aod::track::eta > etaTrMin);
@@ -442,7 +442,7 @@ struct HfTaskElectronWeakBoson {
       if (chiSqNdf > chiSqNdfMax) {
         continue;
       }
-      float massZee, massZeeErr;
+      float massZee{}, massZeeErr{};
       zeeKF.GetMass(massZee, massZeeErr);
       registry.fill(HIST("hKfInvMassZee"), centrality, track.sign() * charge, kfpIsoEle.GetPt(), massZee);
       // LOG(info) << "Invarimass cal by KF particle mass = " << massZee;
diff --git a/PWGHF/HFL/Tasks/taskSingleElectron.cxx b/PWGHF/HFL/Tasks/taskSingleElectron.cxx
@@ -515,8 +515,8 @@ struct HfTaskSingleElectron {
       histos.fill(HIST("tofNSigPt"), track.pt(), track.tofNSigmaEl());
       histos.fill(HIST("tpcNSigPt"), track.pt(), track.tpcNSigmaEl());
 
-      int mpdg;   // electron source pdg code
-      double mpt; // electron source pt
+      int mpdg{};   // electron source pdg code
+      double mpt{}; // electron source pt
       int const source = getElecSource(track, mpt, mpdg);
 
       if (source == DirectBeauty || source == BeautyCharm) {
diff --git a/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx b/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx
@@ -619,7 +619,7 @@ struct HfCandidateCreatorXic0Omegac0 {
       float const decLenCascade = RecoDecay::distance(coordVtxCharmBaryon, vertexCasc);
       float const decLenV0 = RecoDecay::distance(vertexCasc, vertexV0);
 
-      double phiCharmBaryon, thetaCharmBaryon;
+      double phiCharmBaryon{}, thetaCharmBaryon{};
       getPointDirection(std::array{primaryVertex.getX(), primaryVertex.getY(), primaryVertex.getZ()}, coordVtxCharmBaryon, phiCharmBaryon, thetaCharmBaryon);
       auto errorDecayLengthCharmBaryon = std::sqrt(getRotatedCovMatrixXX(primaryVertex.getCov(), phiCharmBaryon, thetaCharmBaryon) + getRotatedCovMatrixXX(covVtxCharmBaryon, phiCharmBaryon, thetaCharmBaryon));
       auto errorDecayLengthXYCharmBaryon = std::sqrt(getRotatedCovMatrixXX(primaryVertex.getCov(), phiCharmBaryon, 0.) + getRotatedCovMatrixXX(covVtxCharmBaryon, phiCharmBaryon, 0.));
@@ -846,7 +846,7 @@ struct HfCandidateCreatorXic0Omegac0 {
       }
 
       // mass window cut on lambda before mass constraint
-      float massLam, sigLam;
+      float massLam{}, sigLam{};
       kfV0.GetMass(massLam, sigLam);
       if (std::abs(massLam - MassLambda0) > lambdaMassWindow) {
         continue;
@@ -879,8 +879,8 @@ struct HfCandidateCreatorXic0Omegac0 {
         LOG(debug) << "Failed to construct Omega or Omega_rej from V0 and bachelor track: " << e.what();
         continue;
       }
-      float massCasc, sigCasc;
-      float massCascrej, sigCascrej;
+      float massCasc{}, sigCasc{};
+      float massCascrej{}, sigCascrej{};
       kfOmega.GetMass(massCasc, sigCasc);
       kfOmegarej.GetMass(massCascrej, sigCascrej); // rej
       // err_massOmega > 0
@@ -920,7 +920,7 @@ struct HfCandidateCreatorXic0Omegac0 {
         LOG(debug) << "Failed to construct OmegaC0 from Cascade and bachelor pion track: " << e.what();
         continue;
       }
-      float massOmegaC0, sigOmegaC0;
+      float massOmegaC0{}, sigOmegaC0{};
       kfOmegaC0.GetMass(massOmegaC0, sigOmegaC0);
       if (sigOmegaC0 <= 0) {
         continue;
@@ -1034,7 +1034,7 @@ struct HfCandidateCreatorXic0Omegac0 {
       float const decLenCascade = RecoDecay::distance(coordVtxCharmBaryon, vertexCasc);
       float const decLenV0 = RecoDecay::distance(vertexCasc, vertexV0);
 
-      double phiCharmBaryon, thetaCharmBaryon;
+      double phiCharmBaryon{}, thetaCharmBaryon{};
       getPointDirection(std::array{kfV0.GetX(), kfV0.GetY(), kfV0.GetZ()}, coordVtxCharmBaryon, phiCharmBaryon, thetaCharmBaryon);
       auto errorDecayLengthCharmBaryon = std::sqrt(getRotatedCovMatrixXX(covMatrixPV, phiCharmBaryon, thetaCharmBaryon) + getRotatedCovMatrixXX(covVtxCharmBaryon, phiCharmBaryon, thetaCharmBaryon));
       auto errorDecayLengthXYCharmBaryon = std::sqrt(getRotatedCovMatrixXX(covMatrixPV, phiCharmBaryon, 0.) + getRotatedCovMatrixXX(covVtxCharmBaryon, phiCharmBaryon, 0.));
diff --git a/PWGHF/TableProducer/candidateCreatorXicToXiPiPi.cxx b/PWGHF/TableProducer/candidateCreatorXicToXiPiPi.cxx
@@ -345,7 +345,7 @@ struct HfCandidateCreatorXicToXiPiPi {
       massXiPi1 = RecoDecay::m(arrayMomentaXiPi1, std::array{MassXiMinus, MassPiPlus});
 
       // get uncertainty of the decay length
-      float phi, theta;
+      float phi{}, theta{};
       getPointDirection(std::array{primaryVertex.getX(), primaryVertex.getY(), primaryVertex.getZ()}, secondaryVertex, phi, theta);
       auto errorDecayLength = std::sqrt(getRotatedCovMatrixXX(covMatrixPV, phi, theta) + getRotatedCovMatrixXX(covMatrixSV, phi, theta));
       auto errorDecayLengthXY = std::sqrt(getRotatedCovMatrixXX(covMatrixPV, phi, 0.) + getRotatedCovMatrixXX(covMatrixSV, phi, 0.));
diff --git a/PWGHF/TableProducer/candidateSelectorCd.cxx b/PWGHF/TableProducer/candidateSelectorCd.cxx
@@ -82,7 +82,7 @@ struct HfCandidateSelectorCd {
   TrackSelectorKa selectorKaon;
   TrackSelectorDe selectorDeuteron;
 
-  const float massCharmDeuteron = 3.23; // possible mass
+  static constexpr float MassCharmDeuteron{3.23f}; // possible mass
 
   using TracksSel = soa::Join<aod::TracksWExtra,
                               aod::TracksPidPi, aod::PidTpcTofFullPi, aod::TracksPidKa, aod::PidTpcTofFullKa, aod::TracksPidDe, aod::PidTpcTofFullDe>;
@@ -218,7 +218,7 @@ struct HfCandidateSelectorCd {
     }
 
     // cut on Cd->deKpi, piKde mass values
-    if (std::abs(massCd - massCharmDeuteron) > cuts->get(binPt, "m")) {
+    if (std::abs(massCd - MassCharmDeuteron) > cuts->get(binPt, "m")) {
       return false;
     }
 
diff --git a/PWGHF/Tasks/taskMcValidation.cxx b/PWGHF/Tasks/taskMcValidation.cxx
@@ -663,7 +663,7 @@ struct HfTaskMcValidationRec {
   Preslice<HfCand2ProngWithMCRec> cand2ProngPerCollision = aod::hf_cand::collisionId;
   Preslice<HfCand3ProngWithMCRec> cand3ProngPerCollision = aod::hf_cand::collisionId;
 
-  Service<o2::ccdb::BasicCCDBManager> ccdb;
+  Service<o2::ccdb::BasicCCDBManager> ccdb{};
   HfEventSelection hfEvSel; // event selection and monitoring
 
   AxisSpec axisDeltaMom{2000, -1., 1.};

Original file line number	Diff line number	Diff line change
`@@ -450,7 +450,7 @@ struct HfCandidateCreatorCharmResoReduced {`
`450`	`450`	`registry.fill(HIST("hMassV0DauVsPt"), invMassV0Tr, candV0Tr.pt());`
`451`	`451`	`}`
`452`	`452`	`} else if constexpr (DType == DMesonType::Dstar) {`
`453`		`- float invMassD0;`
	`453`	`+ float invMassD0{};`
`454`	`454`	`if (candD.sign() > 0) {`
`455`	`455`	`invMassD = candD.invMassDstar();`
`456`	`456`	`invMassD0 = candD.invMassD0();`