Skip to content

Commit 11c4ced

Browse files
authored
Repocleaner : improve some output (#2491)
* - improve the output of the rule skip and the printing of Versions * Do not store last execution if we ignored it.
1 parent 7b6a2f2 commit 11c4ced

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

Framework/script/RepoCleaner/qcrepocleaner/Ccdb.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ def __init__(self, path: str, validFrom, validTo, createdAt, uuid=None, metadata
4242
def __repr__(self):
4343
if "Run" in self.metadata or "RunNumber" in self.metadata:
4444
run_number = self.metadata["Run"] if "Run" in self.metadata else self.metadata["RunNumber"]
45-
return f"Version of object {self.path} valid from {self.validFromAsDt}, run {run_number} (uuid {self.uuid})"
45+
return f"Version of object {self.path} created at {self.createdAtDt.strftime('%Y-%m-%d %H:%M:%S')}, valid from {self.validFromAsDt.strftime('%Y-%m-%d %H:%M:%S')}, run {run_number} (uuid {self.uuid})"
4646
else:
47-
return f"Version of object {self.path} valid from {self.validFromAsDt} (uuid {self.uuid}, " \
47+
return f"Version of object {self.path} created at {self.createdAtDt.strftime('%Y-%m-%d %H:%M:%S')}, valid from {self.validFromAsDt.strftime('%Y-%m-%d %H:%M:%S')} (uuid {self.uuid}, " \
4848
f"ts {self.validFrom})"
4949

5050

Framework/script/RepoCleaner/qcrepocleaner/o2-qc-repo-cleaner

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ def downloadConfigFromConsul(consul_url: str, consul_port: str, file_name: str):
178178
:return: the path to the config file
179179
"""
180180

181-
logging.debug("Get it from consul")
181+
logging.debug(f"Download config file from consul : {consul_url} {consul_port} {file_name}")
182182
consul_server = consul.Consul(host=consul_url, port=consul_port)
183183
file_path = 'o2/components/qc/ANY/any/' + file_name
184184
index, data = consul_server.kv.get(key=file_path)
@@ -393,7 +393,7 @@ def run(args, ccdb_url, rules):
393393
logging.info(f" *** DONE *** (total deleted: {ccdb.counter_deleted}, total updated: {ccdb.counter_validity_updated})")
394394
message = datetime.today().strftime('%Y-%m-%d-%H:%M:%S')
395395
storeCrucialLog(message + f" - End of the cleaner (total deleted: {ccdb.counter_deleted}, total updated: {ccdb.counter_validity_updated})")
396-
if not args.dry_run:
396+
if not args.dry_run and not args.ignore_last_execution:
397397
storeSavedTimestamp()
398398

399399
# ****************

Framework/script/RepoCleaner/qcrepocleaner/rules/skip.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,10 @@ def process(ccdb: Ccdb, object_path: str, delay: int, from_timestamp: int, to_t
2525
'''
2626

2727
logger.debug(f"Plugin 'skip' processing {object_path}")
28-
29-
return {"deleted" : 0, "preserved": 0}
28+
29+
versions = ccdb.getVersionsList(object_path)
30+
31+
return {"deleted": 0, "preserved": len(versions), "updated": 0}
3032

3133

3234
def main():

0 commit comments

Comments
 (0)