Add fully qualified names for std::string and std::map (#2590)

* Add fully qualified names for std::string and std::map

The header TJAlienCredentials.h polluted the global namespace, included usually with CCDB
or something related.

See AliceO2Group/AliceO2#14524 for more background.
This commit prepares for the removal of the polluted namespace.
The libraries/repo with TJAlienCredentials is JAliEn-ROOT and libjalieno2.
The problem was first noticed by @vkucera.

* fix clang-format

---------

Co-authored-by: Piotr Konopka <piotr.jan.konopka@cern.ch>

Author: mrtineide

Modules/CTP/src/CTPTrendingTask.cxx

@@ -60,7 +60,7 @@ void CTPTrendingTask::initCTP(Trigger& t)
   // o2::ctp::CTPConfiguration CTPconfig = o2::ctp::CTPRunManager::getConfigFromCCDB(t.timestamp, run, ok);
   auto& mgr = o2::ccdb::BasicCCDBManager::instance();
   mgr.setURL(CCDBHost);
-  map<string, string> metadata; // can be empty
+  std::map<std::string, std::string> metadata; // can be empty
   metadata["runNumber"] = run;
   mgr.setFatalWhenNull(false);
   auto ctpconfigdb = mgr.getSpecific<o2::ctp::CTPConfiguration>(o2::ctp::CCDBPathCTPConfig, t.timestamp, metadata);
@@ -80,11 +80,11 @@ void CTPTrendingTask::initCTP(Trigger& t)
   }
 
   for (int i = 0; i < 5; i++) {
-    mClassNames[i] = getFromExtendedConfig<string>(t.activity, mCustomParameters, mClassParameters[i], mClassNamesDefault[i]);
+    mClassNames[i] = getFromExtendedConfig<std::string>(t.activity, mCustomParameters, mClassParameters[i], mClassNamesDefault[i]);
     if (mClassNames[i] == "") {
       mClassNames[i] = mClassNamesDefault[i];
     }
-    mInputNames[i] = getFromExtendedConfig<string>(t.activity, mCustomParameters, mInputParameters[i], mInputNamesDefault[i]);
+    mInputNames[i] = getFromExtendedConfig<std::string>(t.activity, mCustomParameters, mInputParameters[i], mInputNamesDefault[i]);
     if (mInputNames[i] == "") {
       mInputNames[i] = mInputNamesDefault[i];
     }

Modules/CTP/src/RawDataQcTask.cxx

@@ -80,12 +80,12 @@ void CTPRawDataReaderTask::startOfActivity(const Activity& activity)
   mRunNumber = activity.mId;
   mTimestamp = activity.mValidity.getMin();
 
-  std::string readCTPConfig = getFromExtendedConfig<string>(activity, mCustomParameters, "readCTPconfigInMonitorData", "false");
+  std::string readCTPConfig = getFromExtendedConfig<std::string>(activity, mCustomParameters, "readCTPconfigInMonitorData", "false");
   if (readCTPConfig == "true") {
     mReadCTPconfigInMonitorData = true;
   }
 
-  mMBclassName = getFromExtendedConfig<string>(activity, mCustomParameters, "MBclassName", "CMTVX-B-NOPF");
+  mMBclassName = getFromExtendedConfig<std::string>(activity, mCustomParameters, "MBclassName", "CMTVX-B-NOPF");
 
   std::string run = std::to_string(mRunNumber);
   std::string ccdbName = mCustomParameters["ccdbName"];
@@ -98,7 +98,7 @@ void CTPRawDataReaderTask::startOfActivity(const Activity& activity)
     bool ok;
     auto& mgr = o2::ccdb::BasicCCDBManager::instance();
     mgr.setURL(ccdbName);
-    map<string, string> metadata; // can be empty
+    std::map<std::string, std::string> metadata; // can be empty
     metadata["runNumber"] = run;
     auto ctpconfigdb = mgr.getSpecific<o2::ctp::CTPConfiguration>(o2::ctp::CCDBPathCTPConfig, mTimestamp, metadata);
     if (ctpconfigdb == nullptr) {
@@ -130,8 +130,8 @@ void CTPRawDataReaderTask::startOfActivity(const Activity& activity)
     mHistoClassRatios->SetTitle(Form("Class Ratio to %s", mMBclassName.c_str()));
   }
 
-  std::string nameInput1 = getFromExtendedConfig<string>(activity, mCustomParameters, "MB1inputName", "MTVX");
-  std::string nameInput2 = getFromExtendedConfig<string>(activity, mCustomParameters, "MB2inputName", "MT0A");
+  std::string nameInput1 = getFromExtendedConfig<std::string>(activity, mCustomParameters, "MB1inputName", "MTVX");
+  std::string nameInput2 = getFromExtendedConfig<std::string>(activity, mCustomParameters, "MB2inputName", "MT0A");
 
   auto input1Tokens = o2::utils::Str::tokenize(nameInput1, ':', false, true);
   if (input1Tokens.size() > 0) {
@@ -206,7 +206,7 @@ void CTPRawDataReaderTask::startOfActivity(const Activity& activity)
   mHistoBCMinBias2->SetTitle(Form("%s; %s; %s", title2.Data(), titleX2.Data(), titley2.Data()));
   mHistoInputRatios->SetTitle(Form("Input Ratio to %s", nameInput1.c_str()));
 
-  std::string performConsistencyCheck = getFromExtendedConfig<string>(activity, mCustomParameters, "consistencyCheck", "true");
+  std::string performConsistencyCheck = getFromExtendedConfig<std::string>(activity, mCustomParameters, "consistencyCheck", "true");
   if (performConsistencyCheck == "true") {
     mDecoder.setCheckConsistency(1);
     mDecoder.setDecodeInps(1);

Modules/Common/src/CcdbInspectorTask.cxx

@@ -154,7 +154,7 @@ std::tuple<uint64_t, uint64_t, uint64_t, int> CcdbInspectorTask::getObjectInfo(c
 
 void* CcdbInspectorTask::getObject(const std::string& path, std::type_info const& tinfo, uint64_t timestamp, const std::map<std::string, std::string>& metadata)
 {
-  map<string, string> headers;
+  std::map<std::string, std::string> headers;
   void* obj = mDatabase->retrieveAny(tinfo, path, metadata, timestamp, &headers);
   ILOG(Debug, Devel) << "Retrieved '" << path << "' from db '" << mDatabaseUrl << "' for timestamp " << timestamp << ENDM;
 

Modules/FIT/FDD/src/DigitQcTask.cxx

@@ -411,7 +411,7 @@ void DigitQcTask::initialize(o2::framework::InitContext& /*ctx*/)
 
   for (int i = 0; i < getObjectsManager()->getNumberPublishedObjects(); i++) {
     TH1* obj = dynamic_cast<TH1*>(getObjectsManager()->getMonitorObject(i)->getObject());
-    obj->SetTitle((string("FDD ") + obj->GetTitle()).c_str());
+    obj->SetTitle((std::string("FDD ") + obj->GetTitle()).c_str());
   }
   // Timestamp
   mMetaAnchorOutput = o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "metaAnchorOutput", "CycleDurationNTF");

Modules/FIT/FDD/src/DigitQcTaskLaser.cxx

@@ -208,7 +208,7 @@ void DigitQcTaskLaser::initialize(o2::framework::InitContext& /*ctx*/)
 
   for (int i = 0; i < getObjectsManager()->getNumberPublishedObjects(); i++) {
     TH1* obj = dynamic_cast<TH1*>(getObjectsManager()->getMonitorObject(i)->getObject());
-    obj->SetTitle((string("FDD Laser ") + obj->GetTitle()).c_str());
+    obj->SetTitle((std::string("FDD Laser ") + obj->GetTitle()).c_str());
   }
 }
 

Modules/FIT/FDD/src/PostProcTask.cxx

@@ -276,7 +276,7 @@ void PostProcTask::initialize(Trigger, framework::ServiceRegistryRef services)
   for (int i = 0; i < getObjectsManager()->getNumberPublishedObjects(); i++) {
     TH1* obj = dynamic_cast<TH1*>(getObjectsManager()->getMonitorObject(i)->getObject());
     if (obj != nullptr) {
-      obj->SetTitle((string("FDD ") + obj->GetTitle()).c_str());
+      obj->SetTitle((std::string("FDD ") + obj->GetTitle()).c_str());
     }
   }
 

Modules/FIT/FT0/src/DigitQcTask.cxx

@@ -228,7 +228,7 @@ void DigitQcTask::initialize(o2::framework::InitContext& /*ctx*/)
 
   for (int i = 0; i < getObjectsManager()->getNumberPublishedObjects(); i++) {
     TH1* obj = dynamic_cast<TH1*>(getObjectsManager()->getMonitorObject(i)->getObject());
-    obj->SetTitle((string("FT0 ") + obj->GetTitle()).c_str());
+    obj->SetTitle((std::string("FT0 ") + obj->GetTitle()).c_str());
   }
   //
   mGoodPMbits_ChID = o2::quality_control_modules::common::getFromConfig<int>(mCustomParameters, "goodPMbits_ChID", 1 << o2::ft0::ChannelData::kIsCFDinADCgate);

Modules/FIT/FV0/src/DigitQcTask.cxx

@@ -372,7 +372,7 @@ void DigitQcTask::initialize(o2::framework::InitContext& /*ctx*/)
 
   for (int i = 0; i < getObjectsManager()->getNumberPublishedObjects(); i++) {
     TH1* obj = dynamic_cast<TH1*>(getObjectsManager()->getMonitorObject(i)->getObject());
-    obj->SetTitle((string("FV0 ") + obj->GetTitle()).c_str());
+    obj->SetTitle((std::string("FV0 ") + obj->GetTitle()).c_str());
   }
   // Timestamp
   mMetaAnchorOutput = o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "metaAnchorOutput", "CycleDurationNTF");

Modules/FIT/FV0/src/DigitQcTaskLaser.cxx

@@ -304,7 +304,7 @@ void DigitQcTaskLaser::initialize(o2::framework::InitContext& /*ctx*/)
 
   for (int i = 0; i < getObjectsManager()->getNumberPublishedObjects(); i++) {
     TH1* obj = dynamic_cast<TH1*>(getObjectsManager()->getMonitorObject(i)->getObject());
-    obj->SetTitle((string("FV0 Laser ") + obj->GetTitle()).c_str());
+    obj->SetTitle((std::string("FV0 Laser ") + obj->GetTitle()).c_str());
   }
 }
 

Modules/FIT/FV0/src/PostProcTask.cxx

@@ -303,7 +303,7 @@ void PostProcTask::initialize(Trigger, framework::ServiceRegistryRef services)
   for (int i = 0; i < getObjectsManager()->getNumberPublishedObjects(); i++) {
     TH1* obj = dynamic_cast<TH1*>(getObjectsManager()->getMonitorObject(i)->getObject());
     if (obj != nullptr) {
-      obj->SetTitle((string("FV0 ") + obj->GetTitle()).c_str());
+      obj->SetTitle((std::string("FV0 ") + obj->GetTitle()).c_str());
     }
   }