Skip to content

Commit d5dfdf6

Browse files
jokonigjokonig
andauthored
[EMCAL-792] Adjust warning and error messages in case of raw errors (#2560)
Co-authored-by: jokonig <jokonig@cern.ch>
1 parent 130859c commit d5dfdf6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Modules/EMCAL/src/RawErrorCheck.cxx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -269,13 +269,13 @@ Quality RawErrorCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
269269
if (result != Quality::Bad) {
270270
result = Quality::Bad;
271271
}
272-
result.addFlag(FlagTypeFactory::Unknown(), "Raw error " + std::string(errorhist->GetYaxis()->GetBinLabel(errorcode + 1)) + " above threshold " + std::to_string(thresholdTotalErrBad));
272+
result.addFlag(FlagTypeFactory::Unknown(), "Raw error " + std::string(errorhist->GetYaxis()->GetBinLabel(errorcode + 1)) + " above critical threshold: Call oncall!");
273273

274274
} else if (numErrors > thresholdTotalErrWarn) { // Number of raw error exceeds the threshold but is considered to be okay. Error can be fixed at beam dump
275275
if (result != Quality::Medium) {
276276
result = Quality::Medium;
277277
}
278-
result.addFlag(FlagTypeFactory::Unknown(), "Raw error " + std::string(errorhist->GetYaxis()->GetBinLabel(errorcode + 1)) + " above threshold " + std::to_string(thresholdTotalErrWarn) + " not critical ");
278+
result.addFlag(FlagTypeFactory::Unknown(), "Raw error " + std::string(errorhist->GetYaxis()->GetBinLabel(errorcode + 1)) + " below critical threshold: Call oncall at beam dump");
279279
}
280280
}
281281
} else if (std::find(errorhists.begin(), errorhists.end(), mo->getName()) != errorhists.end()) {
@@ -301,7 +301,7 @@ Quality RawErrorCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
301301
if (result != Quality::Bad) {
302302
result = Quality::Bad;
303303
}
304-
result.addFlag(FlagTypeFactory::Unknown(), "Raw error " + std::string(errorhist->GetYaxis()->GetBinLabel(errorcode + 1)) + " above threshold " + std::to_string(threshold));
304+
result.addFlag(FlagTypeFactory::Unknown(), "Raw error " + std::string(errorhist->GetYaxis()->GetBinLabel(errorcode + 1)) + " above critical threshold: Call oncall!");
305305
}
306306
}
307307
} else if (std::find(gainhists.begin(), gainhists.end(), mo->GetName()) != gainhists.end()) {
@@ -390,7 +390,7 @@ void RawErrorCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkRes
390390
// Notify about found errors on the infoLogger:
391391
if (mNotifyInfologger) {
392392
for (const auto& flag : checkResult.getFlags()) {
393-
ILOG(Warning, Devel) << "Non-critical raw Error in " << mo->GetName() << " found: " << flag.second << " call EMCal oncall at beam dump!" << ENDM;
393+
ILOG(Warning, Devel) << "Non-critical raw Error in " << mo->GetName() << " found: " << flag.second << ENDM;
394394
}
395395
}
396396
}

0 commit comments

Comments
 (0)