-
Notifications
You must be signed in to change notification settings - Fork 14
[OGUI-1776] Create command for getting a token #3116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OmegaCreations
wants to merge
98
commits into
dev
Choose a base branch
from
feature/TKN/OGUI-1776/create-command-for-getting-token
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[OGUI-1776] Create command for getting a token #3116
OmegaCreations
wants to merge
98
commits into
dev
from
feature/TKN/OGUI-1776/create-command-for-getting-token
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sending connections in ConnectionManager
…liceO2Group/WebUi into feature/TKN/OGUI-1703/basic-typescript-interfaces
…liceO2Group/WebUi into feature/TKN/OGUI-1703/basic-typescript-interfaces
…ithub.com:AliceO2Group/WebUi into feature/TKN/OGUI-1704/data-serialization-utils
…ub.com:AliceO2Group/WebUi into feature/TKN/OGUI-1705/client-central-basic-stream
…ithub.com:AliceO2Group/WebUi into feature/TKN/OGUI-1755/secure-connections-with-certificates
…t, function or class Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…o the auth interceptor
…OGUI-1773/handle-token-validation-for-p2p-connections
…logic for token renewal retries
…OGUI-1776/create-command-for-getting-token
Tokenization/backend/wrapper/src/test/client/Commands/revokeToken.test.ts
Fixed
Show fixed
Hide fixed
…t, function or class Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… of github.com:AliceO2Group/WebUi into feature/TKN/OGUI-1776/create-command-for-getting-token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
In the scope of this task, I have created new commands and allowed central system to pass it's own handlers to process them. I have also refactored auth interceptor to properly inform client about specifics of an error. Therefore we could create a token renewal logic.
The token renewal logic is based on a basic queue system. It created
RetryQueueobject and passes any requests there if token is being renewed or error is eligible for it.The queue system stores and schedules requests, and Connection class creates promise (
pendingTokenRefresh) that is being resolved only when token is renewed, making other calls wait for it.