[OGUI-1837] Search in configurations #3213
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deaponn
reviewed
Dec 4, 2025
Collaborator
Deaponn
left a comment
Deaponn
left a comment
There was a problem hiding this comment.
Code looks great, I just have one small question
| it('should show no results message or empty list for non-matching query', async function () { | ||
| await page?.waitForSelector(SELECTORS.searchInput); | ||
|
|
||
| const randomString = 'non_existing_non_existing_non_existing_non_existing_non_existing'; |
Collaborator
There was a problem hiding this comment.
Have you considered changing the name of this variable to something like nonExistingKey?
Collaborator
Author
There was a problem hiding this comment.
It does make sense, I will rename this variable
Deaponn
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Added a search input to filter configurations, automatically updating the left-hand file tree view