refact code

xiemalin · xiemalin · commit 331d4f4ff990 · 2022-12-13T09:07:24.000+08:00
diff --git a/filefanoutqueue.go b/filefanoutqueue.go
@@ -229,9 +229,12 @@ func (q *FileFanoutQueue) Subscribe(fanoutID int64, fn func(int64, []byte, error
 		return ErrSubscribeExistErr
 	}
 
-	q.doLoopSubscribe(fanoutID, fn)
+	// do subsrcibe by async way
+	go func() {
+		q.doLoopSubscribe(fanoutID, fn)
 
-	qf.subscriber = fn
+		qf.subscriber = fn
+	}()
 
 	return nil
 }
diff --git a/filefanoutqueue_test.go b/filefanoutqueue_test.go
@@ -252,7 +252,7 @@ func TestFanoutQueueSubscribe(t *testing.T) {
 			So(err, ShouldBeNil)
 		}
 		for i := 0; i < 5; i++ {
-			fq.Dequeue(fanoutID)
+			fq.Dequeue(fanoutID) // fanoutID dequeue 5 elements directly
 		}
 
 		fq.Subscribe(fanoutID, func(index int64, data []byte, err error) {

Original file line number	Diff line number	Diff line change
`@@ -229,9 +229,12 @@ func (q *FileFanoutQueue) Subscribe(fanoutID int64, fn func(int64, []byte, error`
`229`	`229`	`return ErrSubscribeExistErr`
`230`	`230`	`}`
`231`	`231`
`232`		`- q.doLoopSubscribe(fanoutID, fn)`
	`232`	`+ // do subsrcibe by async way`
	`233`	`+ go func() {`
	`234`	`+ q.doLoopSubscribe(fanoutID, fn)`
`233`	`235`
`234`		`- qf.subscriber = fn`
	`236`	`+ qf.subscriber = fn`
	`237`	`+ }()`
`235`	`238`
`236`	`239`	`return nil`
`237`	`240`	`}`
Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ func TestFanoutQueueSubscribe(t *testing.T) {`
`252`	`252`	`So(err, ShouldBeNil)`
`253`	`253`	`}`
`254`	`254`	`for i := 0; i < 5; i++ {`
`255`		`- fq.Dequeue(fanoutID)`
	`255`	`+ fq.Dequeue(fanoutID) // fanoutID dequeue 5 elements directly`
`256`	`256`	`}`
`257`	`257`
`258`	`258`	`fq.Subscribe(fanoutID, func(index int64, data []byte, err error) {`