-
Notifications
You must be signed in to change notification settings - Fork 839
Forms: Integrations to CTA + Modal #45662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 2 files.
1 file is newly checked for coverage.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
dfa332d to
4c58620
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is testing well. I tested both self hosted instance and on WordPress.com.
Notes:
- Button jump. On Slack, we've noted that the buttons in the header now jump when the Export button pops in because we've moved that button to the far right.
- Tab removal + integrations. I would have preferred to add the integrations modal button, and remove tabs, in two separate PRs to keep thing smaller and safer. Although this PR is named for the integrations modal, the removal of form tabs is really the bigger change.
- Trash/spam/inbox no tabs. Our final design PR show Inbox/Spam/Trash at the top, in place of our old Responses/Integrations/About tabs. This PR does not do that yet. Inbox/Trash/Spam are still buttons on the upper right. I've confirm with others that we're OK if ends up being the case that do a full Jetpack release in this state, before we move those to tabs.
- Calypso tests. This may break calypsos e2e tests we have that login and check form responses. I was trying to test, but I'm having an issue where calypso simply won't start - my system runs out of memory. If we merge/deploy and tests do break, we can mute during the deploy, then fix those separately.
- Changes. I pushed a fix to ensure we show dashboard content (not editor) for integrations, and added some padding so header buttons don't get the bottoms cut off on focus.

Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Testing the changes
After