Skip to content

Conversation

@lezama
Copy link
Contributor

@lezama lezama commented Oct 28, 2025

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Testing the changes

  1. Verify the button appears: You should see an "Integrations" button in the header actions area (next to "Create form")
  2. Click the Integrations button: A modal should open displaying the integrations list
  3. Verify integrations display: The modal should show all available integrations (Akismet, Google Sheets, Jetpack CRM, MailPoet, Salesforce, Hostinger Reach) with their current status
  4. Test modal close:
  • Click the X button in the top right - should close modal and return to responses view
  • Click outside the modal (on the overlay) - should close modal and return to responses view
  1. Verify no tab: Confirm there is no longer an "Integrations" tab in the tab navigation

After

Screenshot 2025-10-28 at 11 07 12 AM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-integrations-button-modal branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-integrations-button-modal

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Oct 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: November 4, 2025
    • Code freeze: November 3, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 28, 2025
@jp-launch-control
Copy link

jp-launch-control bot commented Oct 28, 2025

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/dashboard/components/layout/index.tsx 0/14 (0.00%) 0.00% -17 💚
projects/packages/forms/src/dashboard/integrations/index.tsx 0/10 (0.00%) 0.00% -20 💚

1 file is newly checked for coverage.

File Coverage
projects/packages/forms/src/dashboard/components/integrations-button/index.tsx 0/5 (0.00%) 💔

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@edanzer edanzer changed the base branch from trunk to update/forms-integration-list-component October 28, 2025 20:15
@edanzer edanzer changed the base branch from update/forms-integration-list-component to trunk October 28, 2025 20:15
@lezama lezama force-pushed the update/forms-integrations-button-modal branch from dfa332d to 4c58620 Compare October 30, 2025 16:43
@simison
Copy link
Member

simison commented Oct 30, 2025

Can you also already match the order of buttons from Ilona's design? Thanks!

image

Copy link
Contributor

@edanzer edanzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing well. I tested both self hosted instance and on WordPress.com.

Notes:

  • Button jump. On Slack, we've noted that the buttons in the header now jump when the Export button pops in because we've moved that button to the far right.
  • Tab removal + integrations. I would have preferred to add the integrations modal button, and remove tabs, in two separate PRs to keep thing smaller and safer. Although this PR is named for the integrations modal, the removal of form tabs is really the bigger change.
  • Trash/spam/inbox no tabs. Our final design PR show Inbox/Spam/Trash at the top, in place of our old Responses/Integrations/About tabs. This PR does not do that yet. Inbox/Trash/Spam are still buttons on the upper right. I've confirm with others that we're OK if ends up being the case that do a full Jetpack release in this state, before we move those to tabs.
  • Calypso tests. This may break calypsos e2e tests we have that login and check form responses. I was trying to test, but I'm having an issue where calypso simply won't start - my system runs out of memory. If we merge/deploy and tests do break, we can mute during the deploy, then fix those separately.
  • Changes. I pushed a fix to ensure we show dashboard content (not editor) for integrations, and added some padding so header buttons don't get the bottoms cut off on focus.

@edanzer edanzer merged commit b2d9287 into trunk Oct 30, 2025
66 of 67 checks passed
@edanzer edanzer deleted the update/forms-integrations-button-modal branch October 30, 2025 19:39
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 30, 2025
@github-actions github-actions bot added this to the jetpack/15.2 milestone Oct 30, 2025
enejb added a commit that referenced this pull request Oct 30, 2025
enejb added a commit that referenced this pull request Oct 30, 2025
lezama added a commit that referenced this pull request Oct 30, 2025
@simison simison requested a review from ilonagl October 31, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants