-
Notifications
You must be signed in to change notification settings - Fork 841
ci: Retry WP core downloads in test-plugin-update #45830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
anomiex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me
| # https://github.com/wp-cli/core-command/pull/258 | ||
| # https://github.com/wp-cli/wp-cli/pull/6140 | ||
| # For now this should work well enough | ||
| [ -f /var/www/html/xmlrpc.php ] || wp core download || sleep $(( 30 + RANDOM % 8 )) && wp core download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. We both missed that this should have been something like
[ -f /var/www/html/xmlrpc.php ] || wp core download || { sleep $(( 30 + RANDOM % 8 )) && wp core download; }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes MONOREP-197
Similar to #45779, sometimes WP core downloads fail as well, e.g.:
https://github.com/Automattic/jetpack/actions/runs/19178820882/job/54830260653
For now let's just do a single retry after a variable sleep. A more robust solution might be coming in WP-CLI:
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
The general effect can be tested like so:
wp core download asdf.asdf || sleep $(( 0 + RANDOM % 8 )) && wp core download fdsa.fdsa