Skip to content

Commit 0781784

Browse files
committed
Rename QueueMessage.next_visible_time to time_next_visible
This is to synchronize with the nomenclature in Azure Python SDK Issue #92.
1 parent 51858e5 commit 0781784

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

azure/functions/_abc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ def insertion_time(self) -> typing.Optional[datetime.datetime]:
172172

173173
@property
174174
@abc.abstractmethod
175-
def next_visible_time(self) -> typing.Optional[datetime.datetime]:
175+
def time_next_visible(self) -> typing.Optional[datetime.datetime]:
176176
pass
177177

178178
@property

azure/functions/_queue.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def insertion_time(self) -> typing.Optional[datetime.datetime]:
5050
return None
5151

5252
@property
53-
def next_visible_time(self) -> typing.Optional[datetime.datetime]:
53+
def time_next_visible(self) -> typing.Optional[datetime.datetime]:
5454
"""A datetime object with the time the message will be visible next."""
5555
return None
5656

azure/worker/bindings/queue.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ def __init__(self, *,
1717
dequeue_count=None,
1818
expiration_time=None,
1919
insertion_time=None,
20-
next_visible_time=None,
20+
time_next_visible=None,
2121
pop_receipt=None):
2222
super().__init__(id=id, body=body, pop_receipt=pop_receipt)
2323
self.__dequeue_count = dequeue_count
2424
self.__expiration_time = expiration_time
2525
self.__insertion_time = insertion_time
26-
self.__next_visible_time = next_visible_time
26+
self.__time_next_visible = time_next_visible
2727

2828
@property
2929
def dequeue_count(self):
@@ -38,8 +38,8 @@ def insertion_time(self):
3838
return self.__insertion_time
3939

4040
@property
41-
def next_visible_time(self):
42-
return self.__next_visible_time
41+
def time_next_visible(self):
42+
return self.__time_next_visible
4343

4444
def __repr__(self) -> str:
4545
return (
@@ -88,7 +88,7 @@ def from_proto(cls, data: protos.TypedData, *,
8888
trigger_metadata, 'ExpirationTime'),
8989
insertion_time=cls._parse_datetime_metadata(
9090
trigger_metadata, 'InsertionTime'),
91-
next_visible_time=cls._parse_datetime_metadata(
91+
time_next_visible=cls._parse_datetime_metadata(
9292
trigger_metadata, 'NextVisibleTime'),
9393
pop_receipt=cls._decode_trigger_metadata_field(
9494
trigger_metadata, 'PopReceipt', python_type=str)

tests/queue_functions/queue_trigger/main.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ def main(msg: azf.QueueMessage) -> str:
1111
if msg.expiration_time else None),
1212
'insertion_time': (msg.insertion_time.isoformat()
1313
if msg.insertion_time else None),
14-
'next_visible_time': (msg.next_visible_time.isoformat()
15-
if msg.next_visible_time else None),
14+
'time_next_visible': (msg.time_next_visible.isoformat()
15+
if msg.time_next_visible else None),
1616
'pop_receipt': msg.pop_receipt,
1717
'dequeue_count': msg.dequeue_count
1818
})

tests/test_queue_functions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def test_queue_basic(self):
2727

2828
self.assertEqual(msg['body'], 'test-message')
2929
for attr in {'id', 'expiration_time', 'insertion_time',
30-
'next_visible_time', 'pop_receipt', 'dequeue_count'}:
30+
'time_next_visible', 'pop_receipt', 'dequeue_count'}:
3131
self.assertIsNotNone(msg.get(attr))
3232

3333
def test_queue_return(self):

0 commit comments

Comments
 (0)