From 89b87231f23ccd8345c58fac6e5654f4b4abd245 Mon Sep 17 00:00:00 2001 From: Rickard Liljeberg Date: Wed, 7 Jul 2021 11:38:02 +0200 Subject: [PATCH] Group members set to null fix If Members property of a group is set to null it would fail on Apply with a patch operation to add a member. --- .../Protocol/ProtocolExtensions.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Microsoft.SystemForCrossDomainIdentityManagement/Protocol/ProtocolExtensions.cs b/Microsoft.SystemForCrossDomainIdentityManagement/Protocol/ProtocolExtensions.cs index f448e095..bb381177 100644 --- a/Microsoft.SystemForCrossDomainIdentityManagement/Protocol/ProtocolExtensions.cs +++ b/Microsoft.SystemForCrossDomainIdentityManagement/Protocol/ProtocolExtensions.cs @@ -159,6 +159,11 @@ private static void Apply(this Core2Group group, PatchOperation2 operation) IList buffer = new List(); foreach (Member member in membersToAdd) { + if(group.Members == null) + { + group.Members = Enumerable.Empty(); + } + //O(n) with the number of group members, so for large groups this is not optimal if (!group.Members.Any((Member item) => string.Equals(item.Value, member.Value, StringComparison.OrdinalIgnoreCase)))