From 5bcd738765f990a6eafa5792f5eca1ea909c8120 Mon Sep 17 00:00:00 2001 From: "Manuha Vancha (from Dev Box)" Date: Mon, 5 May 2025 12:12:25 -0700 Subject: [PATCH 1/2] Add changes from PR 421 --- .vscode/settings.json | 4 ++++ CHANGELOG.md | 10 +++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index f6850ec2..f66c3e9b 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -1,10 +1,14 @@ { "cSpell.words": [ "authflow", + "azureauth", "Corext", "devicecode", "MSAL", "prompthint", + "regkey", + "SETTINGCHANGE", + "setx", "validargs" ] } \ No newline at end of file diff --git a/CHANGELOG.md b/CHANGELOG.md index f1de09f1..2505bb4a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,11 +10,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [0.9.1] - 2024-12-09 ### Changed -- Removed ChachedAuth mode if Broker is already present in auth modes on windows 10 or 11 since Broker already tries CachedAuth in a compliant way. +- Removed CachedAuth mode if Broker is already present in auth modes on windows 10 or 11 since Broker already tries CachedAuth in a compliant way. ## [0.9.0] - 2024-11-07 ### Removed -- Removed IWA from default authentcation mode. +- Removed IWA from default authentication mode. ### Changed - Temporarily paused the publishing of Linux binaries. @@ -61,7 +61,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [0.8.1] - 2023-05-23 ### Changed - The `azureauth ado token` command uses `microsoft.com` as the default `--domain` option value. -- MSAL Cache usage is now isolated to it's own "auth flow" always injected as the first type of auth to attempt, regardless of mode. This creates a separate telemetry event for `pca_cache` as a new authflow type, which is always silent. The remaining authflows no longer attempt to use the cache first. +- MSAL Cache usage is now isolated to it's own "auth flow" always injected as the first type of auth to attempt, regardless of mode. This creates a separate telemetry event for `pca_cache` as a new authflow type, which is always silent. The remaining auth flows no longer attempt to use the cache first. - Upgraded Lasso to 2023.5.11.1 to reduce the number of log files in temp folder. ### Fixed @@ -130,7 +130,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [0.5.4] - 2022-09-29 ### Fixed -- Enable IWA authmode when interactive authentication is disabled. +- Enable IWA auth mode when interactive authentication is disabled. ## [0.5.3] - 2022-09-28 ### Fixed @@ -206,7 +206,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Initial project release. [Unreleased]: https://github.com/AzureAD/microsoft-authentication-cli/compare/0.9.1...HEAD -[0.9.0]: https://github.com/AzureAD/microsoft-authentication-cli/compare/0.9.0...0.9.1 +[0.9.1]: https://github.com/AzureAD/microsoft-authentication-cli/compare/0.9.0...0.9.1 [0.9.0]: https://github.com/AzureAD/microsoft-authentication-cli/compare/0.8.6...0.9.0 [0.8.6]: https://github.com/AzureAD/microsoft-authentication-cli/compare/0.8.5...0.8.6 [0.8.5]: https://github.com/AzureAD/microsoft-authentication-cli/compare/0.8.4...0.8.5 From d5a115db6d8d72a5c124f3bea76d459041bc38d7 Mon Sep 17 00:00:00 2001 From: "Manuha Vancha (from Dev Box)" Date: Tue, 6 May 2025 10:56:03 -0700 Subject: [PATCH 2/2] update auth mode error message --- src/AzureAuth/Commands/Ado/CommandPat.cs | 2 +- src/AzureAuth/Commands/Ado/CommandToken.cs | 2 +- src/AzureAuth/Commands/CommandAad.cs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/AzureAuth/Commands/Ado/CommandPat.cs b/src/AzureAuth/Commands/Ado/CommandPat.cs index 4dc4c870..0d361b1b 100644 --- a/src/AzureAuth/Commands/Ado/CommandPat.cs +++ b/src/AzureAuth/Commands/Ado/CommandPat.cs @@ -135,7 +135,7 @@ public int OnExecute(ILogger logger, IPublicClientAuth publicClientA this.AuthModes ??= env.ReadAuthModeFromEnvOrSetDefault(); if (!this.AuthModes.Any()) { - logger.LogError($"Invalid value specified for environment variable {EnvVars.AuthMode}. Allowed values are: {CommandAad.AuthModeHelperText}"); + logger.LogError($"Invalid value specified for environment variable {EnvVars.AuthMode}. Allowed values are: {CommandAad.AuthModeAllowedValues}"); return 1; } diff --git a/src/AzureAuth/Commands/Ado/CommandToken.cs b/src/AzureAuth/Commands/Ado/CommandToken.cs index 7e57c6c4..47b02fb5 100644 --- a/src/AzureAuth/Commands/Ado/CommandToken.cs +++ b/src/AzureAuth/Commands/Ado/CommandToken.cs @@ -102,7 +102,7 @@ public int OnExecute(ILogger logger, IEnv env, ITelemetryService t this.AuthModes ??= env.ReadAuthModeFromEnvOrSetDefault(); if (!this.AuthModes.Any()) { - logger.LogError($"Invalid value specified for environment variable {EnvVars.AuthMode}. Allowed values are: {CommandAad.AuthModeHelperText}"); + logger.LogError($"Invalid value specified for environment variable {EnvVars.AuthMode}. Allowed values are: {CommandAad.AuthModeAllowedValues}"); return 1; } diff --git a/src/AzureAuth/Commands/CommandAad.cs b/src/AzureAuth/Commands/CommandAad.cs index 4540cf04..96b1ed09 100644 --- a/src/AzureAuth/Commands/CommandAad.cs +++ b/src/AzureAuth/Commands/CommandAad.cs @@ -286,7 +286,7 @@ public bool EvaluateOptions() this.AuthModes ??= env.ReadAuthModeFromEnvOrSetDefault(); if (!this.AuthModes.Any()) { - this.logger.LogError($"Invalid value specified for environment variable {EnvVars.AuthMode}. Allowed values are: {CommandAad.AuthModeHelperText}"); + this.logger.LogError($"Invalid value specified for environment variable {EnvVars.AuthMode}. Allowed values are: {CommandAad.AuthModeAllowedValues}"); return false; }