remove deprecated deferOnce, defer and setTimeout
#290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekzod
force-pushed
the
remove-depricated
branch
from
3ede4f7 to
8583461
Compare
rwjblue
reviewed
Dec 4, 2017
Collaborator
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Can you rename the tests/defer-once-test.jsalso?
bekzod
force-pushed
the
remove-depricated
branch
4 times, most recently
from
57c7e51 to
941520d
Compare
Contributor
Author
|
done |
Contributor
Author
|
this is ready for merge 😉 |
bekzod
force-pushed
the
remove-depricated
branch
from
941520d to
9e0aa8e
Compare
Contributor
Author
|
rebased again, ping ping |
Collaborator
|
ya, we just need to land this before the next major, which should be soonish (after #306 lands)... |
Contributor
Author
|
this is also ready to merge |
Contributor
Author
|
ping |
Collaborator
|
We can only merge this when we are ready to do a major bump. |
Contributor
Author
|
what is stoping merging and doing major bump :P |
Contributor
Author
|
maybe it is time remove this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think they have been deprecated enough to remove them, and since they are not used in ember for long time