feat: 课程 Client #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoForceX
force-pushed
the
feat/course
branch
2 times, most recently
from
ec99fe0 to
18864f5
Compare
Member
|
宝宝你是一头生产队的驴😍😍😍 |
Member
|
我喜欢你 |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new course client to handle course-related functionalities across different platforms, including practice courses, physics courses, normal courses, and exam arrangements.
- Adds support for course-related endpoints in the client (practice, physics, and normal courses)
- Extends type definitions to include course-specific responses and schedules
- Updates the CAS authentication flows and main index integration for the new CourseClient
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| types/hust.ts | Added a new enum entry for 'course' to extend available client types |
| types/clients/course/practice.ts | Introduced type definitions for practice course schedule responses |
| types/clients/course/physics.ts | Introduced type definitions for physics course schedule and grade responses |
| types/clients/course/common.ts | Added common types related to course scheduling |
| package.json | Added dayjs dependency for date manipulation |
| index.ts | Integrated the CourseClient into the main SDK and updated login flows |
| clients/course/practice.ts | Implemented practice course schedule retrieval logic |
| clients/course/physics.ts | Implemented physics course schedule and grade retrieval logic |
| clients/course/course.ts | Implemented normal course schedule, grade retrieval, and exam arrangements mapping |
| clients/course-client.ts | Created CourseClient class to encapsulate all course-related API calls |
| auth/cas.ts | Updated authentication flows to support additional course login routes |
Comments suppressed due to low confidence (1)
types/clients/course/practice.ts:24
- [nitpick] The comment '工位名称？' is ambiguous. Consider clarifying its intent for better code documentation.
* 工位名称？
| courseId: cls.KCBH, | ||
| courseName: cls.KCMC, | ||
| teacherName: cls.JSMC, | ||
| roomName: cls.JSMC, |
There was a problem hiding this comment.
Both teacherName and roomName are assigned the value from 'cls.JSMC'. Confirm whether this mapping is intended or if roomName should use a different field.
Suggested change
| roomName: cls.JSMC, | |
| roomName: cls.JSLB || '', // Assuming 'JSLB' represents the room name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @wangyinyuan