rpc tests: assertInternalType deprecated fix

Author: afk11

tests-rpc/RbfTransactionTest.php

@@ -35,7 +35,7 @@ public function __construct($name = null, array $data = [], $dataName = '')
 
     private function assertSendRawTransaction($result)
     {
-        $this->assertInternalType('array', $result);
+        $this->assertIsArray($result);
         $this->assertArrayHasKey('error', $result);
         $this->assertEquals(null, $result['error']);
 
@@ -45,9 +45,9 @@ private function assertSendRawTransaction($result)
 
     private function assertBitcoindError($errorCode, $result)
     {
-        $this->assertInternalType('array', $result);
+        $this->assertIsArray($result);
         $this->assertArrayHasKey('error', $result);
-        $this->assertInternalType('array', $result['error']);
+        $this->assertIsArray($result['error']);
         $this->assertEquals($errorCode, $result['error']['code']);
 
         $this->assertArrayHasKey('error', $result);

tests-rpc/ServerTest.php

@@ -30,7 +30,7 @@ public function testIfRegtest()
         $server = $this->rpcFactory->startBitcoind();
 
         $result = $server->makeRpcRequest("getblockchaininfo");
-        $this->assertInternalType('array', $result);
+        $this->assertIsArray($result);
         $this->assertArrayHasKey('result', $result);
         $this->assertArrayHasKey('chain', $result['result']);
         $this->assertEquals('regtest', $result['result']['chain']);
@@ -44,12 +44,12 @@ public function testStartStop()
 
         // First bitcoind, generate block
         $result = $bitcoind->request("generate", [1]);
-        $this->assertInternalType("array", $result['result']);
+        $this->assertIsArray($result['result']);
         $this->assertEquals(64, strlen($result['result'][0]));
 
         // First bitcoind, get block height - 1
         $info = $bitcoind->request("getblockchaininfo");
-        $this->assertInternalType("array", $info['result']);
+        $this->assertIsArray($info['result']);
         $this->assertEquals(1, $info['result']['blocks']);
 
         // Destroy that instance
@@ -60,7 +60,7 @@ public function testStartStop()
         $bitcoind = $this->rpcFactory->startBitcoind();
 
         $info = $bitcoind->request("getblockchaininfo");
-        $this->assertInternalType("array", $info['result']);
+        $this->assertIsArray($info['result']);
         $this->assertEquals(0, $info['result']['blocks']);
 
         $bitcoind->destroy();