the search by paystring and X-address is broken in React #625
Conversation
|
@ihomp |
components/Layout/SearchBlock.js
Outdated
| if (!option) return | ||
| if (option.username && !option.username.includes('-')) { | ||
| onSearch(option.username) | ||
| onSearch(option.username, option?.tag) |
There was a problem hiding this comment.
you don't need "?", as on line 155 there is a check that it exists
There was a problem hiding this comment.
thats why option.username doesn't have the "?"
components/Layout/SearchBlock.js
Outdated
| onSearch(option.username, option?.tag) | ||
| } else { | ||
| onSearch(option.address) | ||
| onSearch(option.address, option?.tag) |
| } | ||
|
|
||
| if (isValidPayString(searchFor) || isValidXAddress(searchFor)) { | ||
| if (isValidPayString(searchItem) || isValidXAddress(searchItem)) { |
There was a problem hiding this comment.
why did you change searchFor to searchItem ?
I can see on lines 287 and lower it is still searchFor
components/Layout/SearchBlock.js
Outdated
| // if there is a tag - | ||
| // get the new page which we can show an address and a tag | ||
| router.push('/account/' + encodeURI(searchFor) + addParams) //replace with a new page to show a tag | ||
| if(tag) { |
There was a problem hiding this comment.
it seems no prettify used, it should be a space between if and (tag). please use prettify before sending the PR
pages/account/tag/[...id].js
Outdated
| // Fetch account data for the resolved address | ||
| const accountResponse = await axiosServer({ | ||
| method: 'get', | ||
| url: `v2/address/${address}?username=true&service=true&verifiedDomain=true&parent=true&nickname=true&inception=true&flare=true&blacklist=true&payString=true&ledgerInfo=true&xamanMeta=true&bithomp=true&obligations=true`, |
There was a problem hiding this comment.
do you really need all those flags here?
do you show all this info?
pages/account/tag/[...id].js
Outdated
| <> | ||
| <SEO | ||
| page="Account with Tag" | ||
| title={`${t('explorer.header.account')} ${userData.service || userData.username || userData.address} - Tag: ${destinationTag}`} |
ihomp
left a comment
ihomp
left a comment
There was a problem hiding this comment.
-
PayString is not resolved
/account/username$paystring.crypto.com -
x-Address opens an account page without the tag
/account/XVVFXHFdehYhofb7XRWeJYV6kjTEwbq2mLScCiYyDTHKu9E -
Direct searching for paystring / xAddress in the landing search - doesn't end up in the right page. (it works if chose from the dropdown)
-
we don't need /account/tag route; we need to reuse the /account/
-
the /account/tag should become a component like Xaddress
-
css need an update, it added some new styles - that are not common in our design.
-
also the social icons shouldn't be grey - it looks like they are disabled/not active
|
@ihomp |
pages/account/[id].js
Outdated
| import { serverSideTranslations } from 'next-i18next/serverSideTranslations' | ||
| import Image from 'next/image' | ||
| import { axiosServer, getFiatRateServer, passHeaders } from '../../utils/axios' | ||
| import { isValidXAddress } from 'ripple-address-codec' |
There was a problem hiding this comment.
it's better to import function to check if X-address Valid from our file '../../utils'
in case we will update it later, so, it will be updated in the whole app at once.
pages/_app.js
Outdated
| import '../styles/globals.css' | ||
| import '../styles/ui.scss' | ||
| import '../styles/components/nprogress.css' | ||
| import '../styles/pages/xaddress-details.scss' |
There was a problem hiding this comment.
we should not load css specific for xaddress page to the whole app.
that css should be loaded on the component level.
ihomp
left a comment
ihomp
left a comment
There was a problem hiding this comment.
css file in a wrong dir and should be loaded on the component lvl
|
The css file should be in the same sub dir as the component it used for
it should not be loadded in the app.js, it should be loaded in the component xaddress-details.js |
|
@ihomp |
2 participants
Issue
1. Resolve paystring / xAddress (you need to find all the details, similiar to what you get in searchBlock), the most important part is the TAG.
2. if xAddress/paystring has a TAG, then show a new VIEW similiar to php
3. if no tag, show normal account page