From 8501d142f2acd2ec4b615365da03a820ebbe89aa Mon Sep 17 00:00:00 2001 From: thuannd86 Date: Mon, 9 Jan 2017 12:58:14 +0700 Subject: [PATCH 1/2] OutlineThickness could not resolved if initalizing value from xaml --- Src/Bratched.Tools/RatingControl/RatingControl.xaml.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Src/Bratched.Tools/RatingControl/RatingControl.xaml.cs b/Src/Bratched.Tools/RatingControl/RatingControl.xaml.cs index 2416bf4..116ab0e 100644 --- a/Src/Bratched.Tools/RatingControl/RatingControl.xaml.cs +++ b/Src/Bratched.Tools/RatingControl/RatingControl.xaml.cs @@ -264,14 +264,15 @@ private double GenerateRateItem(double localValue, List def IRateItemDefinition fullItemDefinition = GetDefinitionFromIndex(FullItemsDefinition, i); item.FullBackgroundColor = fullItemDefinition != null && fullItemDefinition.BackgroundColor != null ? fullItemDefinition.BackgroundColor : fullDefaultDefinition.BackgroundColor; item.FullOutlineColor = fullItemDefinition != null && fullItemDefinition.OutlineColor != null ? fullItemDefinition.OutlineColor : fullDefaultDefinition.OutlineColor; - item.FullOutlineThickness = fullItemDefinition != null && fullItemDefinition.OutlineThickness is Double ? Convert.ToDouble(fullItemDefinition.OutlineThickness) : Convert.ToDouble(fullDefaultDefinition.OutlineThickness); + double r; + item.FullOutlineThickness = fullItemDefinition != null && Double.TryParse(fullItemDefinition.OutlineThickness, r) ? r : Convert.ToDouble(fullDefaultDefinition.OutlineThickness); item.FullPathData = fullItemDefinition != null && fullItemDefinition.PathData is String ? Convert.ToString(fullItemDefinition.PathData) : Convert.ToString(fullDefaultDefinition.PathData); IRateItemDefinition emptyDefaultDefinition = GetDefinitionFromIndex(defaultEmpty, i); IRateItemDefinition emptyItemDefinition = GetDefinitionFromIndex(EmptyItemsDefinition, i); item.EmptyBackgroundColor = emptyItemDefinition != null && emptyItemDefinition.BackgroundColor != null ? emptyItemDefinition.BackgroundColor : emptyDefaultDefinition.BackgroundColor; item.EmptyOutlineColor = emptyItemDefinition != null && emptyItemDefinition.OutlineColor != null ? emptyItemDefinition.OutlineColor : emptyDefaultDefinition.OutlineColor; - item.EmptyOutlineThickness = emptyItemDefinition != null && emptyItemDefinition.OutlineThickness is Double ? Convert.ToDouble(emptyItemDefinition.OutlineThickness) : Convert.ToDouble(emptyDefaultDefinition.OutlineThickness); + item.EmptyOutlineThickness = emptyItemDefinition != null && Double.TryParse(emptyItemDefinition.OutlineThickness,r) ? r : Convert.ToDouble(emptyDefaultDefinition.OutlineThickness); item.EmptyPathData = emptyItemDefinition != null && emptyItemDefinition.PathData is String ? Convert.ToString(emptyItemDefinition.PathData) : Convert.ToString(emptyDefaultDefinition.PathData); if (localValue > 1) From 4a9df10dad000f79ee4947f59f056ddd84462885 Mon Sep 17 00:00:00 2001 From: thuannd86 Date: Mon, 9 Jan 2017 13:06:37 +0700 Subject: [PATCH 2/2] OutlineThickness could not resolved if initalizing value from xaml --- Src/Bratched.Tools/RatingControl/RatingControl.xaml.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Src/Bratched.Tools/RatingControl/RatingControl.xaml.cs b/Src/Bratched.Tools/RatingControl/RatingControl.xaml.cs index 116ab0e..12aa0d5 100644 --- a/Src/Bratched.Tools/RatingControl/RatingControl.xaml.cs +++ b/Src/Bratched.Tools/RatingControl/RatingControl.xaml.cs @@ -265,14 +265,14 @@ private double GenerateRateItem(double localValue, List def item.FullBackgroundColor = fullItemDefinition != null && fullItemDefinition.BackgroundColor != null ? fullItemDefinition.BackgroundColor : fullDefaultDefinition.BackgroundColor; item.FullOutlineColor = fullItemDefinition != null && fullItemDefinition.OutlineColor != null ? fullItemDefinition.OutlineColor : fullDefaultDefinition.OutlineColor; double r; - item.FullOutlineThickness = fullItemDefinition != null && Double.TryParse(fullItemDefinition.OutlineThickness, r) ? r : Convert.ToDouble(fullDefaultDefinition.OutlineThickness); + item.FullOutlineThickness = fullItemDefinition != null && Double.TryParse(fullItemDefinition.OutlineThickness, out r) ? r : Convert.ToDouble(fullDefaultDefinition.OutlineThickness); item.FullPathData = fullItemDefinition != null && fullItemDefinition.PathData is String ? Convert.ToString(fullItemDefinition.PathData) : Convert.ToString(fullDefaultDefinition.PathData); IRateItemDefinition emptyDefaultDefinition = GetDefinitionFromIndex(defaultEmpty, i); IRateItemDefinition emptyItemDefinition = GetDefinitionFromIndex(EmptyItemsDefinition, i); item.EmptyBackgroundColor = emptyItemDefinition != null && emptyItemDefinition.BackgroundColor != null ? emptyItemDefinition.BackgroundColor : emptyDefaultDefinition.BackgroundColor; item.EmptyOutlineColor = emptyItemDefinition != null && emptyItemDefinition.OutlineColor != null ? emptyItemDefinition.OutlineColor : emptyDefaultDefinition.OutlineColor; - item.EmptyOutlineThickness = emptyItemDefinition != null && Double.TryParse(emptyItemDefinition.OutlineThickness,r) ? r : Convert.ToDouble(emptyDefaultDefinition.OutlineThickness); + item.EmptyOutlineThickness = emptyItemDefinition != null && Double.TryParse(emptyItemDefinition.OutlineThickness, out r) ? r : Convert.ToDouble(emptyDefaultDefinition.OutlineThickness); item.EmptyPathData = emptyItemDefinition != null && emptyItemDefinition.PathData is String ? Convert.ToString(emptyItemDefinition.PathData) : Convert.ToString(emptyDefaultDefinition.PathData); if (localValue > 1)