-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Area
Backend — API / GraphQL
Category
Test coverage
Description
The storage package handles all session replay data, source maps, and assets across S3 and filesystem backends. It has zero dedicated tests — only indirect coverage via integration tests.
Priority test targets:
- S3Client / FilesystemClient parity — same inputs produce same outputs
- Brotli compression round-trip (compress → decompress)
- Gob encoding round-trip for raw events
- Session bucket versioning (v2/ prefix for sessions >= 150M)
- Source map Redis caching (read cached → miss → read from storage)
- CloudFront URL signing
Structural concerns:
- Single 1,106-line file — should be split into S3Client, FilesystemClient, shared types
- Default filesystem path is /tmp — not durable across restarts
- No streaming — entire files loaded into memory (OOM risk for large sessions)
- Gob encoding for raw events — not inspectable without Go tooling
See src/backend/storage/MODULE.md for full analysis.
Affected Files / Packages
src/backend/storage/storage.go (1,106 lines — single file, 0 tests)
Reactions are currently unavailable