fix(api): encapsulate routing logic in RouteService

Author: BrotherJing

scalable-ot-api/src/main/java/com/brotherjing/controller/DocController.java

@@ -15,12 +15,11 @@
 import org.springframework.web.bind.annotation.ResponseBody;
 import org.springframework.web.bind.annotation.RestController;
 
-import com.brotherjing.core.loadbalance.LoadBalancer;
 import com.brotherjing.core.loadbalance.ServerEntity;
 import com.brotherjing.core.service.DocService;
 import com.brotherjing.producer.OpSender;
 import com.brotherjing.proto.BaseProto;
-import com.brotherjing.service.DiscoveryService;
+import com.brotherjing.service.RouteService;
 
 @Slf4j
 @RestController
@@ -34,10 +33,7 @@ public class DocController {
     private OpSender opSender;
 
     @Autowired
-    private DiscoveryService discoveryService;
-
-    @Autowired
-    private LoadBalancer loadBalancer;
+    private RouteService routeService;
 
     @RequestMapping(value = "/create", method = RequestMethod.POST)
     @ResponseBody
@@ -85,8 +81,7 @@ void save(@PathVariable String docId, @RequestBody BaseProto.Command command) {
      */
     @GetMapping(value = "/{docId}/channel")
     String getChannel(@PathVariable String docId) {
-        List<ServerEntity> allServers = discoveryService.getAllServers();
-        ServerEntity entity = loadBalancer.select(allServers, docId);
+        ServerEntity entity = routeService.getRoute(docId);
         log.info("Select channel {} for docId {}", entity.toString(), docId);
         return entity.getServerAddress();
     }

scalable-ot-api/src/main/java/com/brotherjing/grpc/BroadcastServiceImpl.java

@@ -12,11 +12,10 @@
 
 import com.brotherjing.Const;
 import com.brotherjing.api.Broadcast;
-import com.brotherjing.core.loadbalance.LoadBalancer;
 import com.brotherjing.core.loadbalance.ServerEntity;
 import com.brotherjing.proto.BaseProto;
 import com.brotherjing.proto.BroadcastServiceGrpc;
-import com.brotherjing.service.DiscoveryService;
+import com.brotherjing.service.RouteService;
 import com.google.protobuf.AbstractMessageLite;
 
 @GrpcService
@@ -26,10 +25,7 @@ public class BroadcastServiceImpl extends BroadcastServiceGrpc.BroadcastServiceI
     private Broadcast broadcast;
 
     @Autowired
-    private DiscoveryService discoveryService;
-
-    @Autowired
-    private LoadBalancer loadBalancer;
+    private RouteService routeService;
 
     @Override
     public void sendTo(BaseProto.SendRequest request, StreamObserver<BaseProto.BroadcastResponse> responseObserver) {
@@ -60,7 +56,7 @@ public void sendToAll(BaseProto.BroadcastRequest request,
      * Get broadcast server ip by docId, and put in RPC context.
      */
     private void setBroadcastIP(String docId) {
-        ServerEntity entity = loadBalancer.select(discoveryService.getAllServers(), docId);
+        ServerEntity entity = routeService.getRoute(docId);
         RpcContext.getContext().set(Const.BROADCAST_ADDR_CONTEXT, entity);
     }
 }

scalable-ot-api/src/main/java/com/brotherjing/service/RouteService.java

@@ -0,0 +1,24 @@
+package com.brotherjing.service;
+
+import java.util.List;
+
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
+
+import com.brotherjing.core.loadbalance.LoadBalancer;
+import com.brotherjing.core.loadbalance.ServerEntity;
+
+@Service
+public class RouteService {
+
+    @Autowired
+    private DiscoveryService discoveryService;
+
+    @Autowired
+    private LoadBalancer loadBalancer;
+
+    public ServerEntity getRoute(String docId) {
+        List<ServerEntity> allServers = discoveryService.getAllServers();
+        return loadBalancer.select(allServers, docId);
+    }
+}