Merge branch 'ChromeDevTools:main' into main

Author: tysonthomas9

AUTHORS

@@ -40,6 +40,7 @@ Feng Yu <f3n67u@gmail.com>
 Gabriel Luong <gabriel.luong@gmail.com>
 Gautham Banasandra <gautham.bangalore@gmail.com>
 Han Xu <suyanhanx@gmail.com>
+Helmut Januschka <helmut@januschka.com>
 Henry Lim <henry@limhenry.xyz>
 Jacky Hu <flameddd@gmail.com>
 Jake Mulhern <mulherje@gmail.com>
@@ -112,4 +113,3 @@ The Chromium Authors <*@chromium.org>
 The Qt Company <*@qt.io>
 # Please DO NOT APPEND here. See comments at the top of the file.
 # END organizations section.
-

DEPS

@@ -15,24 +15,24 @@ vars = {
   'build_revision': 'e13953ced04ed05f45aa3c961bd6d802aced74ec',
 
   'buildtools_url': 'https://chromium.googlesource.com/chromium/src/buildtools.git',
-  'buildtools_revision': 'cd169314af80e77a75eb25e2c0df8798f35bc04a',
+  'buildtools_revision': '8f29aa25232198e7955c675f6f66d6d6e1f04d73',
 
   'depot_tools_url': 'https://chromium.googlesource.com/chromium/tools/depot_tools.git',
-  'depot_tools_revision': '0888983e473613d853c419245b97294e46497798',
+  'depot_tools_revision': '3be09c6d74ab3e69c99a4dfef5cac79d075b7142',
 
   'inspector_protocol_url': 'https://chromium.googlesource.com/deps/inspector_protocol',
   'inspector_protocol_revision': '6d1ae0f13aae6ad381ca31b17b88a0f5af29ca94',
 
   # Keeping track of the last time we rollerd the browser protocol files.
-  'chromium_browser_protocol_revision' : '3313d9b6b84ff455dbf0edfee0bb15bbc23b30ba',
+  'chromium_browser_protocol_revision' : '1cbea9a67e6b8a957e370ab258e26bbdae9cbd29',
 
   'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
   'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',
 
   'emscripten_tag': 'ade9d780ff17c88d81aa13860361743e3c1e1396',
 
   # GN CIPD package version.
-  'gn_version': 'git_revision:cad8f67e2dd0cea00bbe4566efe2fdf4c1821563',
+  'gn_version': 'git_revision:a84e399f9999003472192286abc03d752c9cb1f0',
 
   'cmake_version': 'version:2@3.21.3',
 
@@ -49,7 +49,7 @@ vars = {
   # Chrome version used for tests. It should be regularly updated to
   # match the Canary version listed here:
   # https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json
-  'chrome': '138.0.7190.0',
+  'chrome': '139.0.7211.0',
 
   # 'magic' text to tell depot_tools that git submodules should be accepted but
   # but parity with DEPS file is expected.
@@ -59,7 +59,7 @@ vars = {
   'non_git_source': 'True',
 
   # siso CIPD package version
-  'siso_version': 'git_revision:d9393c2115244b6e4a797189055e4a2b6769a64d',
+  'siso_version': 'git_revision:df8adf712c5b5605b438fdfcd44235107811e5ef',
 }
 
 # Only these hosts are allowed for dependencies in this DEPS file.

OWNERS

@@ -12,6 +12,7 @@ per-file htaccess=file://config/owner/INFRA_OWNERS
 per-file package-lock.json=file://config/owner/INFRA_OWNERS
 per-file package.json=file://config/owner/INFRA_OWNERS
 per-file tsconfig.json=file://config/owner/INFRA_OWNERS
+per-file eslint.config.mjs=file://config/owner/COMMON_OWNERS
 
 # git submodules
 per-file build=devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

buildtools

@@ -660,7 +660,6 @@ grd_files_release_sources = [
   "front_end/panels/console_counters/console_counters.js",
   "front_end/panels/coverage/coverage-meta.js",
   "front_end/panels/coverage/coverage.js",
-  "front_end/panels/css_overview/components/components.js",
   "front_end/panels/css_overview/css_overview-meta.js",
   "front_end/panels/css_overview/css_overview.js",
   "front_end/panels/developer_resources/developer_resources-meta.js",
@@ -1027,6 +1026,7 @@ grd_files_debug_sources = [
   "front_end/generated/protocol.js",
   "front_end/models/ai_assistance/AgentProject.js",
   "front_end/models/ai_assistance/AiHistoryStorage.js",
+  "front_end/models/ai_assistance/AiUtils.js",
   "front_end/models/ai_assistance/ChangeManager.js",
   "front_end/models/ai_assistance/EvaluateAction.js",
   "front_end/models/ai_assistance/ExtensionScope.js",
@@ -1277,9 +1277,11 @@ grd_files_debug_sources = [
   "front_end/panels/ai_assistance/SelectWorkspaceDialog.js",
   "front_end/panels/ai_assistance/aiAssistancePanel.css.js",
   "front_end/panels/ai_assistance/components/ChatView.js",
+  "front_end/panels/ai_assistance/components/ExploreWidget.js",
   "front_end/panels/ai_assistance/components/MarkdownRendererWithCodeBlock.js",
   "front_end/panels/ai_assistance/components/UserActionRow.js",
   "front_end/panels/ai_assistance/components/chatView.css.js",
+  "front_end/panels/ai_assistance/components/exploreWidget.css.js",
   "front_end/panels/ai_assistance/components/userActionRow.css.js",
   "front_end/panels/ai_assistance/selectWorkspaceDialog.css.js",
   "front_end/panels/animation/AnimationGroupPreviewUI.js",
@@ -1431,18 +1433,16 @@ grd_files_debug_sources = [
   "front_end/panels/coverage/coverageListView.css.js",
   "front_end/panels/coverage/coverageView.css.js",
   "front_end/panels/css_overview/CSSOverviewCompletedView.js",
-  "front_end/panels/css_overview/CSSOverviewController.js",
   "front_end/panels/css_overview/CSSOverviewModel.js",
   "front_end/panels/css_overview/CSSOverviewPanel.js",
   "front_end/panels/css_overview/CSSOverviewProcessingView.js",
   "front_end/panels/css_overview/CSSOverviewSidebarPanel.js",
+  "front_end/panels/css_overview/CSSOverviewStartView.js",
   "front_end/panels/css_overview/CSSOverviewUnusedDeclarations.js",
-  "front_end/panels/css_overview/components/CSSOverviewStartView.js",
-  "front_end/panels/css_overview/components/cssOverviewStartView.css.js",
-  "front_end/panels/css_overview/cssOverview.css.js",
   "front_end/panels/css_overview/cssOverviewCompletedView.css.js",
   "front_end/panels/css_overview/cssOverviewProcessingView.css.js",
   "front_end/panels/css_overview/cssOverviewSidebarPanel.css.js",
+  "front_end/panels/css_overview/cssOverviewStartView.css.js",
   "front_end/panels/developer_resources/DeveloperResourcesListView.js",
   "front_end/panels/developer_resources/DeveloperResourcesView.js",
   "front_end/panels/developer_resources/developerResourcesListView.css.js",
@@ -1488,7 +1488,6 @@ grd_files_debug_sources = [
   "front_end/panels/elements/classesPaneWidget.css.js",
   "front_end/panels/elements/components/AccessibilityTreeNode.js",
   "front_end/panels/elements/components/AdornerManager.js",
-  "front_end/panels/elements/components/AnchorFunctionLinkSwatch.js",
   "front_end/panels/elements/components/CSSHintDetailsView.js",
   "front_end/panels/elements/components/CSSPropertyDocsView.js",
   "front_end/panels/elements/components/CSSPropertyIconResolver.js",
@@ -1505,7 +1504,6 @@ grd_files_debug_sources = [
   "front_end/panels/elements/components/QueryContainer.js",
   "front_end/panels/elements/components/StylePropertyEditor.js",
   "front_end/panels/elements/components/accessibilityTreeNode.css.js",
-  "front_end/panels/elements/components/anchorFunctionLinkSwatch.css.js",
   "front_end/panels/elements/components/computedStyleProperty.css.js",
   "front_end/panels/elements/components/computedStyleTrace.css.js",
   "front_end/panels/elements/components/cssHintDetailsView.css.js",
@@ -1918,6 +1916,7 @@ grd_files_debug_sources = [
   "front_end/panels/timeline/ModificationsManager.js",
   "front_end/panels/timeline/NetworkTrackAppender.js",
   "front_end/panels/timeline/SaveFileFormatter.js",
+  "front_end/panels/timeline/StatusDialog.js",
   "front_end/panels/timeline/TargetForEvent.js",
   "front_end/panels/timeline/ThirdPartyTreeView.js",
   "front_end/panels/timeline/ThreadAppender.js",
@@ -2031,6 +2030,7 @@ grd_files_debug_sources = [
   "front_end/panels/timeline/timelinePanel.css.js",
   "front_end/panels/timeline/timelineSelectorStatsView.css.js",
   "front_end/panels/timeline/timelineStatusDialog.css.js",
+  "front_end/panels/timeline/timelineTreeView.css.js",
   "front_end/panels/timeline/utils/AICallTree.js",
   "front_end/panels/timeline/utils/EntityMapper.js",
   "front_end/panels/timeline/utils/EntryName.js",
@@ -2617,6 +2617,7 @@ grd_files_debug_sources = [
   "front_end/ui/legacy/treeoutline.css.js",
   "front_end/ui/legacy/viewContainers.css.js",
   "front_end/ui/lit/i18n-template.js",
+  "front_end/ui/lit/strip-whitespace.js",
   "front_end/ui/visual_logging/Debugging.js",
   "front_end/ui/visual_logging/DomState.js",
   "front_end/ui/visual_logging/KnownContextValues.js",

config/gni/devtools_grd_files.gni

@@ -309,7 +309,7 @@ send it to us as described on that page.
 
 ### First-time contributors
 
-Add your or your organization's name and contact info to the [`AUTHORS`](./AUTHORS)
+Add your or your organization's name and contact info to the [`AUTHORS`](../../AUTHORS)
 file for Chromium DevTools. Please include this as part of your first patch and
 not as a separate standalone patch.
 
@@ -320,11 +320,11 @@ contribution can be accepted:
 
 -   Definition: The "author" is the email address that owns the code review
     request on <https://chromium-review.googlesource.com>
--   Ensure the author is already listed in the [`AUTHORS`](./AUTHORS).
+-   Ensure the author is already listed in the [`AUTHORS`](../../AUTHORS).
     In some cases, the author's company might have a wildcard rule
     (e.g. `*@google.com`).
 -   If the author or their company is not listed, the CL should include a new
-    [`AUTHORS`](./AUTHORS) entry.
+    [`AUTHORS`](../../AUTHORS) entry.
     -    Ensure the new entry is reviewed by a reviewer who works for Google.
     -    Contributor License Agreement can be verified by Googlers at http://go/cla.
     -    If there is a corporate CLA for the author's company, it must list the

docs/contributing/README.md

@@ -34,9 +34,6 @@ Timeline category of the [UMA](http://uma/) page.
     *Sources* panels sidebar.
 *   `DevTools.Workspaces.PopulateWallClockTime` records the wall clock time in
     milliseconds elapsed while populating a project folder in the workspace.
-*   `DevTools.SidebarPaneShown` records the `navigator-files` (*Sources -
-    Filesystem*) enum whenever the *Filesystem* tab is revealed in the *Sources*
-    panels sidebar.
 
 ## How to add UMA metrics in DevTools frontend
 

docs/cookbook/uma_metrics.md

@@ -137,7 +137,7 @@ button.addEventListener('click', event => onClick(event));
   * [Icon
     buttons](https://www.figma.com/design/A5iQBBNAe5zPFpJvUzUgW8/CDT-design-kit?node-id=571-616&m=dev)
 
-## Combo Boxes
+## Combo Boxes and Single Select menus
 
 ![Combo Box component](images/combo-box-variations.png)
 
@@ -167,6 +167,7 @@ Usage with lit-html:
 ```js
 html`<select aria-label="Choose your champion"
              @onchange=${onChange}>
+  <option hidden value="Choose your champion"></option>
   <option jslog=${VisualLogging.item('hamster').track({click: true})}
           value="Hamster">Hamster</option>
   <option jslog=${VisualLogging.item('mouse').track({click: true})}

docs/styleguide/ux/components.md

@@ -3,11 +3,11 @@
 // found in the LICENSE file.
 
 import stylisticPlugin from '@stylistic/eslint-plugin';
-import { defineConfig, globalIgnores } from 'eslint/config';
 import eslintPlugin from 'eslint-plugin-eslint-plugin';
 import importPlugin from 'eslint-plugin-import';
 import jsdocPlugin from 'eslint-plugin-jsdoc';
 import mochaPlugin from 'eslint-plugin-mocha';
+import { defineConfig, globalIgnores } from 'eslint/config';
 import globals from 'globals';
 import { join } from 'path';
 import typescriptEslint from 'typescript-eslint';
@@ -251,6 +251,7 @@ export default defineConfig([
       // no-implicit-globals will prevent accidental globals
       'no-implicit-globals': 'off',
       'no-unused-private-class-members': 'error',
+      'no-useless-constructor': 'error',
 
       // Sort imports first
       'import/first': 'error',
@@ -542,6 +543,9 @@ export default defineConfig([
 
       '@typescript-eslint/consistent-indexed-object-style': 'error',
 
+      'no-useless-constructor': 'off',
+      '@typescript-eslint/no-useless-constructor': 'error',
+
       'rulesdir/no-underscored-properties': 'error',
       'rulesdir/inline-type-imports': 'error',
 
@@ -608,6 +612,7 @@ export default defineConfig([
       'rulesdir/no-bound-component-methods': 'error',
       'rulesdir/no-adopted-style-sheets': 'error',
       'rulesdir/no-customized-builtin-elements': 'error',
+      'rulesdir/no-deprecated-component-usages': 'error',
       'rulesdir/no-self-closing-custom-element-tagnames': 'error',
       'rulesdir/no-a-tags-in-lit': 'error',
       'rulesdir/check-css-import': 'error',
@@ -699,6 +704,7 @@ export default defineConfig([
       'rulesdir/prefer-sinon-assert': 'error',
       'rulesdir/prefer-url-string': 'error',
       'rulesdir/trace-engine-test-timeouts': 'error',
+      'rulesdir/no-widget-show-document-body': 'error',
       'rulesdir/enforce-custom-element-definitions-location': 'off',
     },
 
@@ -724,11 +730,6 @@ export default defineConfig([
           type: 'suite',
           interfaces: ['BDD', 'TDD'],
         },
-        {
-          name: 'describeWithRealConnection',
-          type: 'suite',
-          interfaces: ['BDD', 'TDD'],
-        },
         {
           name: 'itScreenshot',
           type: 'testCase',

eslint.config.mjs

@@ -25,10 +25,6 @@ export class CreditsItem extends HTMLElement {
   readonly #shadow = this.attachShadow({mode: 'open'});
   #data: Readonly<CreditsItemData> = {title: '', homepage: '', license: ''};
 
-  constructor() {
-    super();
-  }
-
   get data(): Readonly<CreditsItemData> {
     return this.#data;
   }