Minor changes to gen_boostrap.sh #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdoardo
force-pushed
the
default-channel-bootstrap
branch
from
9d6ff08 to
eca7d10
Compare
+ small fixes to selected backend when running in CI on main.
xdoardo
force-pushed
the
default-channel-bootstrap
branch
from
eca7d10 to
38bfa39
Compare
seharris
reviewed
Dec 5, 2025
| - apt-get install -y clang ninja-build lld cmake ccache perl | ||
| gen_bootstrap_script: ./cheri/gen_bootstrap.sh | ||
| - apt-get install -y pkg-config clang ninja-build lld cmake ccache perl libssl-dev | ||
| gen_bootstrap_script: ./cheri/gen_bootstrap.sh && cat bootstrap.toml |
Collaborator
There was a problem hiding this comment.
This cat looks like it could be forgotten debugging code, is it meant to be here?
Collaborator
Author
There was a problem hiding this comment.
I think it's harmless and can give some insights if we see strange failures in the other tasks!
seharris
reviewed
Dec 5, 2025
| else | ||
| # TODO: change this to `dev` once we add rustfmt to the beta branch, so | ||
| # that fmt --check is part of the tests. | ||
| CHANNEL="beta" |
Collaborator
There was a problem hiding this comment.
This might be overkill, but we could create issues for these two TODOs when this PR is merged just so they don't get forgotten.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to take into account, if available, the branch in which CI is executing, that is, setting the channel to
nightlyif the script is executed in CI targeting themainbranch.Piggybacking on this patch there's also the one to turn off the GCC backend on
main, which was giving problems unrelated to our changes.Requires #46 to be merged first.