-
Notifications
You must be signed in to change notification settings - Fork 3
Minor changes to gen_boostrap.sh #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xdoardo
wants to merge
2
commits into
CHERIoT-Platform:beta
Choose a base branch
from
xdoardo:default-channel-bootstrap
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,35 @@ elif [ -z "${CUSTOM_CMAKE_FLAGS+set}" ]; then | |
| CUSTOM_CMAKE_FLAGS="" | ||
| fi | ||
|
|
||
| # Check if we're running CI for a PR to main. | ||
| if [ -n "${CIRRUS_BASE_BRANCH+set}" ]; then | ||
| if [ "$CIRRUS_BASE_BRANCH" == "main" ]; then | ||
| CHANNEL="nightly" | ||
| # We are seeing some faults unrelated to our changes when CI runs from | ||
| # main, specifically tied to gcc. When running like that (CI from main) | ||
| # we want to restrict the backend to LLVM and cranelift only, so that | ||
| # we don't get stuck on things that aren't our fault. Ideally, we | ||
| # should restore the normal behaviour once the error is fixed. | ||
| CODEGEN_BACKENDS="codegen-backends = [\"llvm\",\"cranelift\"]" | ||
| else | ||
| # TODO: change this to `dev` once we add rustfmt to the beta branch, so | ||
| # that fmt --check is part of the tests. | ||
| CHANNEL="beta" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This might be overkill, but we could create issues for these two TODOs when this PR is merged just so they don't get forgotten. |
||
| fi | ||
| # Otherwise we may be running for a direct push to main. | ||
| elif [ -n "${CIRRUS_BRANCH+set}" ]; then | ||
| if [ "$CIRRUS_BRANCH" == "main" ]; then | ||
| CHANNEL="nightly" | ||
|
|
||
| # See comment above. | ||
| CODEGEN_BACKENDS="codegen-backends = [\"llvm\",\"cranelift\"]" | ||
| else | ||
| CHANNEL="beta" | ||
| fi | ||
| else | ||
| CHANNEL="beta" | ||
| fi | ||
|
|
||
| if [ -e "$FILE" ]; then | ||
| echo "$FILE already exists!" | ||
| exit 1 | ||
|
|
@@ -26,14 +55,14 @@ cat > "$FILE" <<- EOF | |
| # See bootstrap.example.toml for documentation of available options | ||
| # | ||
| profile = "compiler" # Includes one of the default files in src/bootstrap/defaults | ||
| change-id = 140732 | ||
| change-id = "ignore" | ||
|
|
||
| [build] | ||
| ccache = true | ||
|
|
||
| [rust] | ||
| channel = "beta" | ||
| #codegen-backends = ["llvm"] | ||
| channel = "$CHANNEL" | ||
| $CODEGEN_BACKENDS | ||
| #debug = true | ||
| #debuginfo-level = 2 | ||
| std-features = ["compiler-builtins-mem"] | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
catlooks like it could be forgotten debugging code, is it meant to be here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's harmless and can give some insights if we see strange failures in the other tasks!