-
Notifications
You must be signed in to change notification settings - Fork 149
Implement quantiles and median for hazard and impact forecasts #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+214
−0
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
7da50f1
Return impactForecast object in _return_impact
luseverin bd3502f
Return impactForecast object in _return_empty
luseverin dfa0198
Add full impactcalc test for impactForecast
luseverin 59c0e5b
Correct mistakes in _return_empty and _return_impact
luseverin 4b5ae95
Raise value error when computing impact with impact forecast without …
luseverin 9a516e1
Cosmetics: Improve error message, move test to own class
d571bb7
Merge branch 'forecast-class' into impactCalc_block_nonsense_attrs
luseverin 6fe29f0
Merge branch 'impactCalc_return_impactForecast' into impactCalc_block…
luseverin 899d8f0
add test to check that eai_exp and aai_agg are nan for forecasts
luseverin db32170
Write nans for eai_exp and aai_agg when forecast is used
luseverin d2f035f
update tests using pytest
luseverin c10a4b3
Fix error in test fixtures
luseverin d3a5642
Returns nans for eai_exp and aai_agg when exposures is empty
luseverin d43a46c
add warning when at_event is used with forecast
luseverin e197566
Update ImpactCalc tests for forecasts
peanutfun 0a324b2
Merge branch 'impactCalc_return_impactForecast' of https://github.com…
peanutfun 554cfc8
Review ImpactCalc forecast handling
peanutfun 30ed14d
Block local_exceedance_impact
luseverin f3ab44a
Fix bug in test
peanutfun 612a53c
Merge branch 'impactCalc_return_impactForecast' of https://github.com…
peanutfun 9e4f2bb
Block return_period and exceedance_freq_curve
luseverin 727357e
Log warning for at_event getter
luseverin 0bc5846
Add mean max min methods to impact forecast and tests
luseverin a55ab3b
Merge branch 'forecast-class' into implement_mean_min_max
luseverin 0aad2a5
Reduce lead time and member and update test
luseverin 102f9be
Update docstrings
luseverin dfce16f
Remove useless comments
luseverin 0b6e1e4
Add min max mean for hazard forecast
luseverin 3fc25af
Correct some mistakes in mean min max on hazard forecast
luseverin a4fe3b0
Add tests for hazard forecast mean min max
luseverin 4a80344
Merge branch 'implement_mean_min_max' into implement_quantiles
luseverin 2feb7d2
Add quantiles and median for hazard forecast
luseverin e099868
Set reduced date to 0 and cosmetic changes
luseverin 23660de
Set reduced date to 0 in impact forecast
luseverin efc1ac2
Merge branch 'implement_mean_min_max' into implement_quantiles
luseverin ab5b551
Correct quantile computation with np.quantile and toarray
luseverin b11e9c5
Add test for quantile calc
luseverin 64149df
Simplify code and tests
peanutfun 3b4048e
Add quantile and median for impact forecast
luseverin df20622
Merge branch 'implement_mean_min_max' into implement_quantiles
luseverin 66ee290
Merge branch 'forecast-class' into implement_quantiles
luseverin b9524d6
Merge branch 'forecast-class' into implement_quantiles
peanutfun 35cb0fa
Remove accidentally doubled members
peanutfun 2e3c26e
Review
peanutfun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.