Skip to content

Avoid asking user to use template if templateName exists #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid asking user to use template if templateName exists #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39090fa
Avoid asking user to use template if `templateName` exists
troym9731 Nov 15, 2018
cb68e11
Add back asking to use a template when none is specified
troym9731 Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed src/.DS_Store
View file
Open in desktop
Binary file not shown.
3 changes: 2 additions & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ async function getTemplatesPath(templateName = null) {
}

async function getTemplateOption() {
const templateArg = args.t || args.template
const templateArg = config.t || config.template || config.templateName
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your catch!
This line is ok ;)

if (templateArg) {
return getTemplatesPath(templateArg)
}
Expand All @@ -48,6 +48,7 @@ async function getTemplateOption() {
if (template) {
return getTemplatesPath()
}

return null
}

Expand Down